From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2177C04E53 for ; Wed, 15 May 2019 08:26:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EFB220843 for ; Wed, 15 May 2019 08:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726325AbfEOI0J (ORCPT ); Wed, 15 May 2019 04:26:09 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:52674 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726136AbfEOI0J (ORCPT ); Wed, 15 May 2019 04:26:09 -0400 Date: 15 May 2019 17:26:07 +0900 X-IronPort-AV: E=Sophos;i="5.60,471,1549897200"; d="scan'208";a="15795180" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 15 May 2019 17:26:07 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id F1659420EF21; Wed, 15 May 2019 17:26:06 +0900 (JST) Message-ID: <871s106ssi.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Chris Brandt Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda , Geert Uytterhoeven , Sergei Shtylyov , Chunfeng Yun , , , Subject: Re: [PATCH v3 11/15] usb: renesas_usbhs: Add support for RZ/A2 In-Reply-To: <20190514145605.19112-12-chris.brandt@renesas.com> References: <20190514145605.19112-1-chris.brandt@renesas.com> <20190514145605.19112-12-chris.brandt@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Chris > +static int usbhs_rza2_hardware_exit(struct platform_device *pdev) > +{ > + struct usbhs_priv *priv = usbhs_pdev_to_priv(pdev); > + > + if (priv->phy) { > + phy_put(priv->phy); > + priv->phy = NULL; > + } > + > + return 0; > +} phy_put() will do nothing if priv->phy was NULL. We can remove if() here ? Thank you for your help !! Best regards --- Kuninori Morimoto