From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Takashi Iwai <tiwai@suse.de>, Linux-SH <linux-sh@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Jaroslav Kysela <perex@perex.cz>
Subject: Re: [alsa-devel] [PATCH] ALSA: hda/ca0132: need CONFIG_PCI for compile
Date: 05 Feb 2019 17:06:44 +0900 [thread overview]
Message-ID: <875ztyk6u1.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <s5hzhraeko4.wl-tiwai@suse.de>
Forward to Renesas / SH ML
arch/sh need to be fixed pci_iounmap()
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > commit d99501b8575d ("ALSA: hda/ca0132 - Call pci_iounmap() instead of
> > iounmap()") started to use pci_iounmap() on ca0132, but then, it should
> > be depends on CONFIG_PCI.
> > Otherwise, non CONFIG_PCI compile will be failed, like below
> >
> > linux/sound/pci/hda/patch_ca0132.c: In function 'ca0132_free':
> > linux/sound/pci/hda/patch_ca0132.c:8455:3: error: implicit\
> > declaration of function 'pci_iounmap'; did you mean\
> > 'pcim_iounmap'? [-Werror=implicit-function-declaration]
> > pci_iounmap(codec->bus->pci, spec->mem_base);
> > ^~~~~~~~~~~
>
> No, the driver doesn't depend on PCI, it can be built and work fine
> without it, too. The only problem is the broken pci_iounmap()
> implementation in sh.
>
> We have added CONFIG_PCI check but obviously this isn't effective.
> It needs to be an explicit #ifdef, instead. Will fix it.
>
> Ideally it should be fixed in arch/sh side. I tried to fix it, but it
> turned out to be much deeper than I thought, so I gave up scratching
> it for now.
>
>
> thanks,
>
> Takashi
>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > sound/pci/hda/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
> > index 4235907..03af159 100644
> > --- a/sound/pci/hda/Kconfig
> > +++ b/sound/pci/hda/Kconfig
> > @@ -171,6 +171,7 @@ comment "Set to Y if you want auto-loading the codec driver"
> >
> > config SND_HDA_CODEC_CA0132
> > tristate "Build Creative CA0132 codec support"
> > + depends on CONFIG_PCI
> > help
> > Say Y or M here to include Creative CA0132 codec support in
> > snd-hda-intel driver.
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
parent reply other threads:[~2019-02-05 8:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <s5hzhraeko4.wl-tiwai@suse.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ztyk6u1.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).