linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Cc: "Luis Oliveira" <lolivei@synopsys.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Michael Rodin" <mrodin@de.adit-jv.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Hugues Fruchet" <hugues.fruchet@st.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Adam Ford" <aford173@gmail.com>,
	"Todor Tomov" <todor.tomov@linaro.org>,
	"Suresh Udipi" <sudipi@jp.adit-jv.com>,
	"Andrew Gabbasov" <andrew_gabbasov@mentor.com>,
	"Eugeniu Rosca" <erosca@de.adit-jv.com>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.org>,
	"Roman Kovalivskyi" <roman.kovalivskyi@globallogic.com>
Subject: [PATCH v2 1/6] media: ov5647: Add set_fmt and get_fmt calls.
Date: Tue, 19 May 2020 04:16:16 +0300	[thread overview]
Message-ID: <8a4c0d157d26251c9916b32866e6a4a91c023ef9.1589850165.git.roman.kovalivskyi@globallogic.com> (raw)
In-Reply-To: <cover.1589847910.git.roman.kovalivskyi@globallogic.com>
In-Reply-To: <cover.1589850165.git.roman.kovalivskyi@globallogic.com>

From: Dave Stevenson <dave.stevenson@raspberrypi.org>

There's no way to query the subdevice for the supported
resolutions. Add set_fmt and get_fmt implementations. Since there's
only one format supported set_fmt does nothing and get returns single
format.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
Signed-off-by: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/media/i2c/ov5647.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
index e7d2e5b4ad4b..3e587eb0a30e 100644
--- a/drivers/media/i2c/ov5647.c
+++ b/drivers/media/i2c/ov5647.c
@@ -463,8 +463,30 @@ static int ov5647_enum_mbus_code(struct v4l2_subdev *sd,
 	return 0;
 }
 
+static int ov5647_set_get_fmt(struct v4l2_subdev *sd,
+			      struct v4l2_subdev_pad_config *cfg,
+			      struct v4l2_subdev_format *format)
+{
+	struct v4l2_mbus_framefmt *fmt = &format->format;
+
+	if (format->pad != 0)
+		return -EINVAL;
+
+	/* Only one format is supported, so return that */
+	memset(fmt, 0, sizeof(*fmt));
+	fmt->code = MEDIA_BUS_FMT_SBGGR8_1X8;
+	fmt->colorspace = V4L2_COLORSPACE_SRGB;
+	fmt->field = V4L2_FIELD_NONE;
+	fmt->width = 640;
+	fmt->height = 480;
+
+	return 0;
+}
+
 static const struct v4l2_subdev_pad_ops ov5647_subdev_pad_ops = {
 	.enum_mbus_code = ov5647_enum_mbus_code,
+	.set_fmt =	  ov5647_set_get_fmt,
+	.get_fmt =	  ov5647_set_get_fmt,
 };
 
 static const struct v4l2_subdev_ops ov5647_subdev_ops = {
-- 
2.17.1


  parent reply	other threads:[~2020-05-19  1:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  1:16 [PATCH v2 0/6] ov5647 driver improvement Roman Kovalivskyi
     [not found] ` <cover.1589850165.git.roman.kovalivskyi@globallogic.com>
2020-05-19  1:16   ` Roman Kovalivskyi [this message]
2020-05-19 11:24     ` [PATCH v2 1/6] media: ov5647: Add set_fmt and get_fmt calls Sakari Ailus
2020-05-19 11:51       ` Sakari Ailus
2020-05-19  1:16   ` [PATCH v2 2/6] media: ov5647: Add support for PWDN GPIO Roman Kovalivskyi
2020-06-18 15:54     ` Jacopo Mondi
2020-05-19  1:16   ` [PATCH v2 3/6] media: ov5647: Add support for non-continuous clock mode Roman Kovalivskyi
2020-05-19 11:57     ` Sakari Ailus
2020-06-18 10:13       ` Jacopo Mondi
     [not found]         ` <7d718df8-5256-3ff6-01ec-2f1a14f53580@globallogic.com>
2020-06-22  8:35           ` Jacopo Mondi
2020-05-19  1:16   ` [PATCH v2 4/6] media: ov5647: Use gpiod_set_value_cansleep Roman Kovalivskyi
2020-05-19 11:57     ` Sakari Ailus
2020-05-19  1:16   ` [PATCH v2 5/6] media: dt-bindings: ov5647: Add property for PWDN control Roman Kovalivskyi
2020-05-19 11:51     ` Sakari Ailus
2020-05-19  1:16   ` [PATCH v2 6/6] media: dt-bindings: ov5647: Add property for non-continuous clock Roman Kovalivskyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a4c0d157d26251c9916b32866e6a4a91c023ef9.1589850165.git.roman.kovalivskyi@globallogic.com \
    --to=roman.kovalivskyi@globallogic.com \
    --cc=aford173@gmail.com \
    --cc=andrew_gabbasov@mentor.com \
    --cc=dave.stevenson@raspberrypi.org \
    --cc=erosca@de.adit-jv.com \
    --cc=hugues.fruchet@st.com \
    --cc=jacopo@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lolivei@synopsys.com \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=mrodin@de.adit-jv.com \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sudipi@jp.adit-jv.com \
    --cc=todor.tomov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).