linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nguyen An Hoan <na-hoan@jinso.co.jp>,
	linux-renesas-soc@vger.kernel.org, broonie@kernel.org,
	geert+renesas@glider.be
Cc: magnus.damm@gmail.com, linux-spi@vger.kernel.org,
	kuninori.morimoto.gx@renesas.com,
	yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp,
	nv-dung@jinso.co.jp, cv-dong@jinso.co.jp
Subject: Re: [PATCH 1/2] spi: sh-msiof: fix *info pointer in request_dma()
Date: Fri, 11 Jan 2019 13:15:17 +0300	[thread overview]
Message-ID: <8fd1a446-f40d-4fd3-a810-bfef6d1df9f0@cogentembedded.com> (raw)
In-Reply-To: <1547197109-637-1-git-send-email-na-hoan@jinso.co.jp>

Hello!

On 01/11/2019 11:58 AM, Nguyen An Hoan wrote:

> From: Hoan Nguyen An <na-hoan@jinso.co.jp>
> 
> msiof_spi_infor struct pointer was initialized in the probe() function,

   infor?

> no need to get back and keep consistency.
> 
> Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>
> ---
>  drivers/spi/spi-sh-msiof.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
> index d14b407..64adf34 100644
> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
[...]
> @@ -1469,3 +1469,4 @@ MODULE_DESCRIPTION("SuperH MSIOF SPI Master Interface Driver");
>  MODULE_AUTHOR("Magnus Damm");
>  MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:spi_sh_msiof");
> +
> 

   Huh?

MBR, Sergei

  parent reply	other threads:[~2019-01-11 10:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11  8:58 [PATCH 1/2] spi: sh-msiof: fix *info pointer in request_dma() Nguyen An Hoan
2019-01-11  8:58 ` [PATCH 2/2] spi: sh-msiof: Use DMA if possible Nguyen An Hoan
2019-01-11  9:09   ` Geert Uytterhoeven
2019-01-11  9:27     ` Hoan
2019-01-11 10:05       ` Geert Uytterhoeven
2019-01-18  8:19         ` Hoan
2019-01-11  9:01 ` [PATCH 1/2] spi: sh-msiof: fix *info pointer in request_dma() Geert Uytterhoeven
2019-01-11 10:15 ` Sergei Shtylyov [this message]
2019-01-11 13:26 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fd1a446-f40d-4fd3-a810-bfef6d1df9f0@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=broonie@kernel.org \
    --cc=cv-dong@jinso.co.jp \
    --cc=geert+renesas@glider.be \
    --cc=h-inayoshi@jinso.co.jp \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=na-hoan@jinso.co.jp \
    --cc=nv-dung@jinso.co.jp \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).