* [PATCH v2 0/2] Add R8A77970/Eagle GPIO support
@ 2018-02-13 11:18 Sergei Shtylyov
2018-02-13 11:22 ` [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add " Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Sergei Shtylyov @ 2018-02-13 11:18 UTC (permalink / raw)
To: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
linux-renesas-soc, devicetree
Cc: Magnus Damm, Mark Rutland, linux-arm-kernel
Hello!
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20180213-v4.16-rc1' tag. We're adding the R8A77970 GPIO
nodes and then describing the PHY IRQ for EtherAVB device declared earlier.
[1/2] arm64: dts: renesas: r8a77970: add GPIO support
[2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ
WBR, Sergei
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add GPIO support
2018-02-13 11:18 [PATCH v2 0/2] Add R8A77970/Eagle GPIO support Sergei Shtylyov
@ 2018-02-13 11:22 ` Sergei Shtylyov
2018-02-14 10:01 ` Geert Uytterhoeven
2018-02-13 11:24 ` [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ Sergei Shtylyov
2019-01-08 19:56 ` [PATCH] arm64: dts: renesas: v3msk: " Sergei Shtylyov
2 siblings, 1 reply; 11+ messages in thread
From: Sergei Shtylyov @ 2018-02-13 11:22 UTC (permalink / raw)
To: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
linux-renesas-soc, devicetree
Cc: Magnus Damm, Mark Rutland, linux-arm-kernel
Describe all 6 GPIO controllers in the R8A77970 device tree.
Based on the original (and large) patch by Daisuke Matsushita
<daisuke.matsushita.ns@hitachi.com>.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Changes in version 2:
- made use of the SYSC power domain #define's;
- mentioned the original patch this one was based upon and added Vladimir's
signoff..
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 90 ++++++++++++++++++++++++++++++
1 file changed, 90 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -183,6 +183,96 @@
reg = <0 0xe6060000 0 0x504>;
};
+ gpio0: gpio@e6050000 {
+ compatible = "renesas,gpio-r8a77970",
+ "renesas,rcar-gen3-gpio";
+ reg = <0 0xe6050000 0 0x50>;
+ interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 0 22>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 912>;
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ resets = <&cpg 912>;
+ };
+
+ gpio1: gpio@e6051000 {
+ compatible = "renesas,gpio-r8a77970",
+ "renesas,rcar-gen3-gpio";
+ reg = <0 0xe6051000 0 0x50>;
+ interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 32 28>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 911>;
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ resets = <&cpg 911>;
+ };
+
+ gpio2: gpio@e6052000 {
+ compatible = "renesas,gpio-r8a77970",
+ "renesas,rcar-gen3-gpio";
+ reg = <0 0xe6052000 0 0x50>;
+ interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 64 17>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 910>;
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ resets = <&cpg 910>;
+ };
+
+ gpio3: gpio@e6053000 {
+ compatible = "renesas,gpio-r8a77970",
+ "renesas,rcar-gen3-gpio";
+ reg = <0 0xe6053000 0 0x50>;
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 96 17>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 909>;
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ resets = <&cpg 909>;
+ };
+
+ gpio4: gpio@e6054000 {
+ compatible = "renesas,gpio-r8a77970",
+ "renesas,rcar-gen3-gpio";
+ reg = <0 0xe6054000 0 0x50>;
+ interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 128 6>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 908>;
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ resets = <&cpg 908>;
+ };
+
+ gpio5: gpio@e6055000 {
+ compatible = "renesas,gpio-r8a77970",
+ "renesas,rcar-gen3-gpio";
+ reg = <0 0xe6055000 0 0x50>;
+ interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 160 15>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 907>;
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ resets = <&cpg 907>;
+ };
+
intc_ex: interrupt-controller@e61c0000 {
compatible = "renesas,intc-ex-r8a77970", "renesas,irqc";
#interrupt-cells = <2>;
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ
2018-02-13 11:18 [PATCH v2 0/2] Add R8A77970/Eagle GPIO support Sergei Shtylyov
2018-02-13 11:22 ` [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add " Sergei Shtylyov
@ 2018-02-13 11:24 ` Sergei Shtylyov
2018-02-14 10:02 ` Geert Uytterhoeven
2018-02-15 15:16 ` Simon Horman
2019-01-08 19:56 ` [PATCH] arm64: dts: renesas: v3msk: " Sergei Shtylyov
2 siblings, 2 replies; 11+ messages in thread
From: Sergei Shtylyov @ 2018-02-13 11:24 UTC (permalink / raw)
To: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
linux-renesas-soc, devicetree
Cc: Magnus Damm, Mark Rutland, linux-arm-kernel
Specify EtherAVB PHY IRQ in the Eagle board's device tree, now that we
have the GPIO support (previously phylib had to resort to polling).
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 2 ++
1 file changed, 2 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
@@ -44,6 +44,8 @@
phy0: ethernet-phy@0 {
rxc-skew-ps = <1500>;
reg = <0>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
};
};
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add GPIO support
2018-02-13 11:22 ` [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add " Sergei Shtylyov
@ 2018-02-14 10:01 ` Geert Uytterhoeven
2018-02-15 15:13 ` Simon Horman
0 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2018-02-14 10:01 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Mark Rutland, linux-arm-kernel
On Tue, Feb 13, 2018 at 12:22 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Describe all 6 GPIO controllers in the R8A77970 device tree.
>
> Based on the original (and large) patch by Daisuke Matsushita
> <daisuke.matsushita.ns@hitachi.com>.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ
2018-02-13 11:24 ` [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ Sergei Shtylyov
@ 2018-02-14 10:02 ` Geert Uytterhoeven
2018-02-15 8:51 ` Sergei Shtylyov
2018-02-15 15:16 ` Simon Horman
1 sibling, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2018-02-14 10:02 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Mark Rutland, linux-arm-kernel
On Tue, Feb 13, 2018 at 12:24 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Specify EtherAVB PHY IRQ in the Eagle board's device tree, now that we
> have the GPIO support (previously phylib had to resort to polling).
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
You've dropped my:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ
2018-02-14 10:02 ` Geert Uytterhoeven
@ 2018-02-15 8:51 ` Sergei Shtylyov
0 siblings, 0 replies; 11+ messages in thread
From: Sergei Shtylyov @ 2018-02-15 8:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Mark Rutland, linux-arm-kernel
Hello!
On 2/14/2018 1:02 PM, Geert Uytterhoeven wrote:
>> Specify EtherAVB PHY IRQ in the Eagle board's device tree, now that we
>> have the GPIO support (previously phylib had to resort to polling).
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> You've dropped my:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Sorry, I was too hasty to resubmit. :-/
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add GPIO support
2018-02-14 10:01 ` Geert Uytterhoeven
@ 2018-02-15 15:13 ` Simon Horman
0 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2018-02-15 15:13 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Sergei Shtylyov, Rob Herring, Catalin Marinas, Will Deacon,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Mark Rutland, linux-arm-kernel
On Wed, Feb 14, 2018 at 11:01:26AM +0100, Geert Uytterhoeven wrote:
> On Tue, Feb 13, 2018 at 12:22 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Describe all 6 GPIO controllers in the R8A77970 device tree.
> >
> > Based on the original (and large) patch by Daisuke Matsushita
> > <daisuke.matsushita.ns@hitachi.com>.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, applied.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ
2018-02-13 11:24 ` [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ Sergei Shtylyov
2018-02-14 10:02 ` Geert Uytterhoeven
@ 2018-02-15 15:16 ` Simon Horman
1 sibling, 0 replies; 11+ messages in thread
From: Simon Horman @ 2018-02-15 15:16 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Rob Herring, Catalin Marinas, Will Deacon, linux-renesas-soc,
devicetree, Magnus Damm, Mark Rutland, linux-arm-kernel
On Tue, Feb 13, 2018 at 02:24:14PM +0300, Sergei Shtylyov wrote:
> Specify EtherAVB PHY IRQ in the Eagle board's device tree, now that we
> have the GPIO support (previously phylib had to resort to polling).
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks, applied with Geert's tag.
> ---
> arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> ===================================================================
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> @@ -44,6 +44,8 @@
> phy0: ethernet-phy@0 {
> rxc-skew-ps = <1500>;
> reg = <0>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
Could you consider following-up with a patch to add:
reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> };
> };
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] arm64: dts: renesas: v3msk: specify EtherAVB PHY IRQ
2018-02-13 11:18 [PATCH v2 0/2] Add R8A77970/Eagle GPIO support Sergei Shtylyov
2018-02-13 11:22 ` [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add " Sergei Shtylyov
2018-02-13 11:24 ` [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ Sergei Shtylyov
@ 2019-01-08 19:56 ` Sergei Shtylyov
2019-01-09 8:29 ` Geert Uytterhoeven
2 siblings, 1 reply; 11+ messages in thread
From: Sergei Shtylyov @ 2019-01-08 19:56 UTC (permalink / raw)
To: Simon Horman, Rob Herring, linux-renesas-soc, devicetree
Cc: Magnus Damm, Mark Rutland
Specify EtherAVB PHY IRQ in the V3M Starter Kit board's device tree, now
that we have the GPIO support (previously phylib had to resort to polling).
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against the 'renesas-devel-20190107-v5.0-rc1' tag of Simon
Horman's 'renesas.git' repo...
arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts | 2 ++
1 file changed, 2 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
@@ -108,6 +108,8 @@
phy0: ethernet-phy@0 {
rxc-skew-ps = <1500>;
reg = <0>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
};
};
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: v3msk: specify EtherAVB PHY IRQ
2019-01-08 19:56 ` [PATCH] arm64: dts: renesas: v3msk: " Sergei Shtylyov
@ 2019-01-09 8:29 ` Geert Uytterhoeven
2019-01-10 9:39 ` Simon Horman
0 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2019-01-09 8:29 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Simon Horman, Rob Herring, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Mark Rutland
On Tue, Jan 8, 2019 at 8:57 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Specify EtherAVB PHY IRQ in the V3M Starter Kit board's device tree, now
> that we have the GPIO support (previously phylib had to resort to polling).
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: v3msk: specify EtherAVB PHY IRQ
2019-01-09 8:29 ` Geert Uytterhoeven
@ 2019-01-10 9:39 ` Simon Horman
0 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2019-01-10 9:39 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Sergei Shtylyov, Rob Herring, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Mark Rutland
On Wed, Jan 09, 2019 at 09:29:12AM +0100, Geert Uytterhoeven wrote:
> On Tue, Jan 8, 2019 at 8:57 PM Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Specify EtherAVB PHY IRQ in the V3M Starter Kit board's device tree, now
> > that we have the GPIO support (previously phylib had to resort to polling).
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, applied for v5.1
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-01-10 9:40 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-13 11:18 [PATCH v2 0/2] Add R8A77970/Eagle GPIO support Sergei Shtylyov
2018-02-13 11:22 ` [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add " Sergei Shtylyov
2018-02-14 10:01 ` Geert Uytterhoeven
2018-02-15 15:13 ` Simon Horman
2018-02-13 11:24 ` [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ Sergei Shtylyov
2018-02-14 10:02 ` Geert Uytterhoeven
2018-02-15 8:51 ` Sergei Shtylyov
2018-02-15 15:16 ` Simon Horman
2019-01-08 19:56 ` [PATCH] arm64: dts: renesas: v3msk: " Sergei Shtylyov
2019-01-09 8:29 ` Geert Uytterhoeven
2019-01-10 9:39 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).