From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>,
David Miller <davem@davemloft.net>
Cc: Magnus Damm <magnus.damm@gmail.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [net-next 3/3] ravb: TROCR register is only present on R-Car Gen3
Date: Mon, 2 Sep 2019 20:54:04 +0300 [thread overview]
Message-ID: <92f5fa81-39c9-4d98-539b-bb6ea7374472@cogentembedded.com> (raw)
In-Reply-To: <20190902080603.5636-4-horms+renesas@verge.net.au>
On 09/02/2019 11:06 AM, Simon Horman wrote:
> Only use the TROCR register on R-Car Gen3.
> It is not present on other SoCs.
>
> Offsets used for the undocumented registers are also considered reserved
> and should not be written to.
>
> After some internal investigation with Renesas it remains unclear why this
> driver accesses these fields on R-Car Gen2 but regardless of what the
> historical reasons are the current code is considered incorrect.
Most probably copy&paste from sh_eth.c...
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[...]
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
next prev parent reply other threads:[~2019-09-02 17:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 8:06 [net-next 0/3] ravb: Remove use of undocumented registers Simon Horman
2019-09-02 8:06 ` [net-next 1/3] ravb: correct typo in FBP field of SFO register Simon Horman
2019-09-02 10:47 ` Yoshihiro Shimoda
2019-09-02 17:12 ` Sergei Shtylyov
2019-09-02 18:33 ` David Miller
2019-09-05 8:34 ` Simon Horman
2019-09-02 8:06 ` [net-next 2/3] ravb: Remove undocumented processing Simon Horman
2019-09-02 10:49 ` Yoshihiro Shimoda
2019-09-02 17:41 ` Sergei Shtylyov
2019-09-05 8:34 ` Simon Horman
2019-09-02 8:06 ` [net-next 3/3] ravb: TROCR register is only present on R-Car Gen3 Simon Horman
2019-09-02 10:51 ` Yoshihiro Shimoda
2019-09-02 17:54 ` Sergei Shtylyov [this message]
2019-09-02 8:16 ` [net-next 0/3] ravb: Remove use of undocumented registers Geert Uytterhoeven
2019-09-02 13:16 ` Chris Paterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92f5fa81-39c9-4d98-539b-bb6ea7374472@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).