From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] drm: rcar-du: lvds: use dev_err_probe()
Date: Wed, 23 Jun 2021 09:48:00 +0100 [thread overview]
Message-ID: <9a71feae-b4e5-f512-c5ed-b1155914940f@ideasonboard.com> (raw)
In-Reply-To: <20210623030646.7720-1-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
On 23/06/2021 04:06, Laurent Pinchart wrote:
> Simplify error handling by using the dev_err_probe() function.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 5909173b26eb..165be31c4c45 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -839,9 +839,8 @@ static struct clk *rcar_lvds_get_clock(struct rcar_lvds *lvds, const char *name,
> if (PTR_ERR(clk) == -ENOENT && optional)
> return NULL;
>
> - if (PTR_ERR(clk) != -EPROBE_DEFER)
> - dev_err(lvds->dev, "failed to get %s clock\n",
> - name ? name : "module");
> + dev_err_probe(lvds->dev, PTR_ERR(clk), "failed to get %s clock\n",
> + name ? name : "module");
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> return clk;
> }
>
prev parent reply other threads:[~2021-06-23 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 3:06 [PATCH] drm: rcar-du: lvds: use dev_err_probe() Laurent Pinchart
2021-06-23 8:48 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a71feae-b4e5-f512-c5ed-b1155914940f@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).