From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 750DBC636CD for ; Fri, 16 Jul 2021 08:31:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C974613F1 for ; Fri, 16 Jul 2021 08:31:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237315AbhGPIeB (ORCPT ); Fri, 16 Jul 2021 04:34:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237240AbhGPIeA (ORCPT ); Fri, 16 Jul 2021 04:34:00 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADFF7C06175F; Fri, 16 Jul 2021 01:31:05 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id g5so13558733ybu.10; Fri, 16 Jul 2021 01:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QjjQyZufxkvm/4FnY8ErggVvo5phblypQQ5y56lc8Bc=; b=cuq0WO3alXyDsSlh+srE/yCTOOd9pcBEDQYDlbjHgwC1Zk8dPwyQUJHW8/fpSOYVHI v2sEWgIKW5zwm9QhMYzzaWG6ogzooKcywroRAeceJuG+RVVFxOmQGuA61/yrblFOw0M9 /ujre2xc3WOQu2FdzbDrtkzHk9mVvcIfxAceBO3jJo8hU6trZWD4RuE2szX6Le3gYeOj ug3UkegE9rmGkFGUdtnXL7dmsmCs7S6R56J9mfK6ECwhUb3D4NNtRa0bxtoEJ+gOMjFj T0+uigcuZ2gMFAB+FVfN0ipfh4/TrUCa4JTONqXa3mNsmaRAwlTwMtVn58B5MGigcrsR vp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QjjQyZufxkvm/4FnY8ErggVvo5phblypQQ5y56lc8Bc=; b=mkX03HP43xRexKgMtvBRUbqH5qATXe89nMTrJD+ve51FUttAFkMAwXEC831+qp4We5 1XsDkcgi6cxUb8bWSb3d6reOe7v29mYFkQKlBF5sw0qOHCL+YGVC4g6VQONTxVROOtke Qs/5RnYtdEtT5onZsEj5G8fgcCrMW0ZgDXUxJsGTEu1u7T8VCqpa6ARM35ELhnBsTess 76Dk2LBGtGFRAbz+aEGDDnYBK7q1ooP/EC2aGBDw8byK7asR5n7qcQAEiKWEWlUl20or JOfaWzjk7gjxlAIFh8cziHjYXQS2avQElsTd4YTW8hSCALekcUvgt+GOfZZRlwQ5FOGw c8vQ== X-Gm-Message-State: AOAM5327Y5U48RjXJROEeWYHNH+ee2OeI/edP+tixmht06nP5iFL1u1q 5KycUvkInMuIKwHLCDQoYkitwyUrMcdH1qwxfuB+XakG6UVnkw== X-Google-Smtp-Source: ABdhPJxlQJksjPJyV51FNmVvfIOljU/i4uBmy//eqWN9Jxqs5lH3GejT/0DmpS9seYOkVZrG7fbQLHEqCT5UAGgTjKA= X-Received: by 2002:a5b:94d:: with SMTP id x13mr10472941ybq.47.1626424264964; Fri, 16 Jul 2021 01:31:04 -0700 (PDT) MIME-Version: 1.0 References: <20210715182123.23372-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210715182123.23372-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Fri, 16 Jul 2021 09:30:39 +0100 Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/G2L SoC To: Geert Uytterhoeven Cc: Lad Prabhakar , Rob Herring , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Michael Turquette , Stephen Boyd , Philipp Zabel , linux-can@vger.kernel.org, netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-clk , Linux Kernel Mailing List , Linux-Renesas , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, Thank you for the review. On Fri, Jul 16, 2021 at 8:38 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Thu, Jul 15, 2021 at 8:21 PM Lad Prabhakar > wrote: > > Add CANFD binding documentation for Renesas RZ/G2L SoC. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Biju Das > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > > > @@ -78,6 +79,38 @@ patternProperties: > > node. Each child node supports the "status" property only, which > > is used to enable/disable the respective channel. > > > > +if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - renesas,rzg2l-canfd > > +then: > > + properties: > > + interrupts: > > + items: > > + - description: CAN global error interrupt > > + - description: CAN receive FIFO interrupt > > + - description: CAN0 error interrupt > > + - description: CAN0 transmit interrupt > > + - description: CAN0 transmit/receive FIFO receive completion interrupt > > + - description: CAN1 error interrupt > > + - description: CAN1 transmit interrupt > > + - description: CAN1 transmit/receive FIFO receive completion interrupt > > Does it make sense to add interrupt-names? > Agreed will drop this and add interrupt-names instead. Also I will update the driver to pick up the interrupts based on names. > > + > > + resets: > > + maxItems: 2 > > Same here, for reset-names? > Or a list of descriptions, so we know which reset serves what purpose. > OK I'll add the reset-names. Cheers, Prabhakar > > + > > +else: > > + properties: > > + interrupts: > > + items: > > + - description: Channel interrupt > > + - description: Global interrupt > > + > > + resets: > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > The rest looks good to me. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds