From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media <linux-media@vger.kernel.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 1/2] media: i2c: ov772x: Add support for BT656 mode
Date: Sat, 1 Aug 2020 09:54:38 +0100 [thread overview]
Message-ID: <CA+V-a8scKj-9+zi2zSet4t7cPAzaPjoPqSz0vgwxGi4NOu3Cdg@mail.gmail.com> (raw)
In-Reply-To: <20200731160247.GC5201@valkosipuli.retiisi.org.uk>
Hi Sakari,
Thank you for the review.
On Fri, Jul 31, 2020 at 5:03 PM Sakari Ailus <sakari.ailus@iki.fi> wrote:
>
> Hi Prabhakar,
>
> On Fri, Jul 24, 2020 at 04:08:15PM +0100, Lad Prabhakar wrote:
> > Add support to read the bus-type and enable BT656 mode if needed.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> The DT bindings should also be changed.
>
I'll get this done in V2.
> The default should be parallel, I guess, since the type hasn't been
> documented. Parsing should be also updated so the driver can set meaningful
> defaults for the flags --- this btw. also applies to the corresponding
> ov5640 patch.
>
Agreed, will do.
Cheers,
Prabhakar
> --
> Sakari Ailus
next prev parent reply other threads:[~2020-08-01 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 15:08 [PATCH 0/2] media: i2c: ov772x: Enable BT656 mode and test pattern support Lad Prabhakar
2020-07-24 15:08 ` [PATCH 1/2] media: i2c: ov772x: Add support for BT656 mode Lad Prabhakar
2020-07-31 16:02 ` Sakari Ailus
2020-08-01 8:54 ` Lad, Prabhakar [this message]
2020-07-24 15:08 ` [PATCH 2/2] media: i2c: ov772x: Add test pattern control Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8scKj-9+zi2zSet4t7cPAzaPjoPqSz0vgwxGi4NOu3Cdg@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).