From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D30C43217 for ; Thu, 29 Sep 2022 13:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235376AbiI2N60 convert rfc822-to-8bit (ORCPT ); Thu, 29 Sep 2022 09:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235044AbiI2N6Z (ORCPT ); Thu, 29 Sep 2022 09:58:25 -0400 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E619814DAEF; Thu, 29 Sep 2022 06:58:23 -0700 (PDT) Received: by mail-qv1-f42.google.com with SMTP id s13so929209qvq.10; Thu, 29 Sep 2022 06:58:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=j2eS2oYTh9Esr2YqEh75jDi4MmL4n4Pma3h/bszXlXg=; b=JHkw2ED6N+6vDgkpaluIQ0M/eGBd/6C37lL4moRwFXrE3rc5vPbt+742/0s6RAv32Y Fx1WfiUyOc0eSYX/3Ka9uox+NwORxiOopuwjG3g4nR/5a5+x6n7ziHHS37hLA5nPNMgC oqnxY7ORu0gfAF00PvYEoFE2SS2j2t+/IZ7U47QL7PhXLs0bk/jcvPMjE45XawrisUKw MsU8NA2FRWsa9M5ybn51Hy4ecFcnyCpaVUMKdOl14gK0nMmvgGwYwUBuikJTkwDX149g tqjJf/WIvloHnc4dH7neDOgeilCDIGztEAAMxhcxR8jb3SJhrMPFgT4KiCe8VeB7hTc6 nR2Q== X-Gm-Message-State: ACrzQf05KldJqOtWvx6IGV6kgcAPNqaoeH4VkzRWL1S7LVtHIzfV4fNw IdnljfWKkZvEcHXDyfBxVYNiKvPVcLI8LFlYInY= X-Google-Smtp-Source: AMsMyM4AySKi6X3qswEVoCCAsrAbASFeJ+Cin4SOyYreY9KboClevIW+n0aulgtbybFccZ7D03ytU7kp5buKL8yuZEs= X-Received: by 2002:ad4:4ea3:0:b0:4af:646a:9787 with SMTP id ed3-20020ad44ea3000000b004af646a9787mr2549068qvb.15.1664459902561; Thu, 29 Sep 2022 06:58:22 -0700 (PDT) MIME-Version: 1.0 References: <20220928210059.891387-1-daniel.lezcano@linaro.org> In-Reply-To: From: "Rafael J. Wysocki" Date: Thu, 29 Sep 2022 15:58:11 +0200 Message-ID: Subject: Re: [PATCH v7 00/29] Rework the trip points creation To: Daniel Lezcano Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, Raju Rangoju , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peter Kaestle , Hans de Goede , Mark Gross , Miquel Raynal , Amit Kucheria , Nicolas Saenz Julienne , Broadcom Kernel Team , Florian Fainelli , Ray Jui , Scott Branden , Support Opensource , Lukasz Luba , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thara Gopinath , Andy Gross , Bjorn Andersson , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , Eduardo Valentin , Keerthy , Kunihiko Hayashi , Masami Hiramatsu , Antoine Tenart , Srinivas Pandruvada , Dmitry Osipenko , netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Sep 29, 2022 at 2:26 PM Daniel Lezcano wrote: > > > Hi Rafael, > > are you happy with the changes? I'll have a look and let you know. > I would like to integrate those changes with the thermal pull request Sure, but it looks like you've got only a few ACKs for these patches from the driver people. Wouldn't it be prudent to give them some more time to review the changes? > On 28/09/2022 23:00, Daniel Lezcano wrote: > > This work is the pre-requisite of handling correctly when the trip > > point are crossed. For that we need to rework how the trip points are > > declared and assigned to a thermal zone. > > > > Even if it appears to be a common sense to have the trip points being > > ordered, this no guarantee neither documentation telling that is the > > case. > > > > One solution could have been to create an ordered array of trips built > > when registering the thermal zone by calling the different get_trip* > > ops. However those ops receive a thermal zone pointer which is not > > known as it is in the process of creating it. > > > > This cyclic dependency shows we have to rework how we manage the trip > > points. > > > > Actually, all the trip points definition can be common to the backend > > sensor drivers and we can factor out the thermal trip structure in all > > of them. > > > > Then, as we register the thermal trips array, they will be available > > in the thermal zone structure and a core function can return the trip > > given its id. > > > > The get_trip_* ops won't be needed anymore and could be removed. The > > resulting code will be another step forward to a self encapsulated > > generic thermal framework. > > > > Most of the drivers can be converted more or less easily. This series > > does a first round with most of the drivers. Some remain and will be > > converted but with a smaller set of changes as the conversion is a bit > > more complex. > > > > Changelog: > > v7: > > - Added missing return 0 in the x86_pkg_temp driver > > v6: > > - Improved the code for the get_crit_temp() function as suggested by Rafael > > - Removed inner parenthesis in the set_trip_temp() function and invert the > > conditions. Check the type of the trip point is unchanged > > - Folded patch 4 with 1 > > - Add per thermal zone info message in the bang-bang governor > > - Folded the fix for an uninitialized variable in int340x_thermal_zone_add() > > v5: > > - Fixed a deadlock when calling thermal_zone_get_trip() while > > handling the thermal zone lock > > - Remove an extra line in the sysfs change > > - Collected tags > > v4: > > - Remove extra lines on exynos changes as reported by Krzysztof Kozlowski > > - Collected tags > > v3: > > - Reorg the series to be git-bisect safe > > - Added the set_trip generic function > > - Added the get_crit_temp generic function > > - Removed more dead code in the thermal-of > > - Fixed the exynos changelog > > - Fixed the error check for the exynos drivers > > - Collected tags > > v2: > > - Added missing EXPORT_SYMBOL_GPL() for thermal_zone_get_trip() > > - Removed tab whitespace in the acerhdf driver > > - Collected tags > > > > Cc: Raju Rangoju > > Cc: "David S. Miller" > > Cc: Eric Dumazet > > Cc: Jakub Kicinski > > Cc: Paolo Abeni > > Cc: Peter Kaestle > > Cc: Hans de Goede > > Cc: Mark Gross > > Cc: Miquel Raynal > > Cc: "Rafael J. Wysocki" > > Cc: Daniel Lezcano > > Cc: Amit Kucheria > > Cc: Zhang Rui > > Cc: Nicolas Saenz Julienne > > Cc: Broadcom Kernel Team > > Cc: Florian Fainelli > > Cc: Ray Jui > > Cc: Scott Branden > > Cc: Support Opensource > > Cc: Lukasz Luba > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > Cc: Thara Gopinath > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Cc: "Niklas Söderlund" > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Krzysztof Kozlowski > > Cc: Alim Akhtar > > Cc: Thierry Reding > > Cc: Jonathan Hunter > > Cc: Eduardo Valentin > > Cc: Keerthy > > Cc: Kunihiko Hayashi > > Cc: Masami Hiramatsu > > Cc: Antoine Tenart > > Cc: Srinivas Pandruvada > > Cc: Dmitry Osipenko > > Cc: netdev@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: platform-driver-x86@vger.kernel.org > > Cc: linux-pm@vger.kernel.org > > Cc: linux-rpi-kernel@lists.infradead.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-arm-msm@vger.kernel.org > > Cc: linux-renesas-soc@vger.kernel.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-tegra@vger.kernel.org > > Cc: linux-omap@vger.kernel.org > > > > Daniel Lezcano (29): > > thermal/core: Add a generic thermal_zone_get_trip() function > > thermal/sysfs: Always expose hysteresis attributes > > thermal/core: Add a generic thermal_zone_set_trip() function > > thermal/core/governors: Use thermal_zone_get_trip() instead of ops > > functions > > thermal/of: Use generic thermal_zone_get_trip() function > > thermal/of: Remove unused functions > > thermal/drivers/exynos: Use generic thermal_zone_get_trip() function > > thermal/drivers/exynos: of_thermal_get_ntrips() > > thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by > > thermal_zone_get_trip() > > thermal/drivers/tegra: Use generic thermal_zone_get_trip() function > > thermal/drivers/uniphier: Use generic thermal_zone_get_trip() function > > thermal/drivers/hisi: Use generic thermal_zone_get_trip() function > > thermal/drivers/qcom: Use generic thermal_zone_get_trip() function > > thermal/drivers/armada: Use generic thermal_zone_get_trip() function > > thermal/drivers/rcar_gen3: Use the generic function to get the number > > of trips > > thermal/of: Remove of_thermal_get_ntrips() > > thermal/of: Remove of_thermal_is_trip_valid() > > thermal/of: Remove of_thermal_set_trip_hyst() > > thermal/of: Remove of_thermal_get_crit_temp() > > thermal/drivers/st: Use generic trip points > > thermal/drivers/imx: Use generic thermal_zone_get_trip() function > > thermal/drivers/rcar: Use generic thermal_zone_get_trip() function > > thermal/drivers/broadcom: Use generic thermal_zone_get_trip() function > > thermal/drivers/da9062: Use generic thermal_zone_get_trip() function > > thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / > > ti_thermal_trip_is_valid() > > thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function > > thermal/drivers/cxgb4: Use generic thermal_zone_get_trip() function > > thermal/intel/int340x: Replace parameter to simplify > > thermal/drivers/intel: Use generic thermal_zone_get_trip() function > > > > drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 2 - > > .../ethernet/chelsio/cxgb4/cxgb4_thermal.c | 41 +---- > > drivers/platform/x86/acerhdf.c | 73 +++----- > > drivers/thermal/armada_thermal.c | 39 ++--- > > drivers/thermal/broadcom/bcm2835_thermal.c | 8 +- > > drivers/thermal/da9062-thermal.c | 52 +----- > > drivers/thermal/gov_bang_bang.c | 39 +++-- > > drivers/thermal/gov_fair_share.c | 18 +- > > drivers/thermal/gov_power_allocator.c | 51 +++--- > > drivers/thermal/gov_step_wise.c | 22 ++- > > drivers/thermal/hisi_thermal.c | 11 +- > > drivers/thermal/imx_thermal.c | 72 +++----- > > .../int340x_thermal/int340x_thermal_zone.c | 33 ++-- > > .../int340x_thermal/int340x_thermal_zone.h | 4 +- > > .../processor_thermal_device.c | 10 +- > > drivers/thermal/intel/x86_pkg_temp_thermal.c | 120 +++++++------ > > drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 39 ++--- > > drivers/thermal/rcar_gen3_thermal.c | 2 +- > > drivers/thermal/rcar_thermal.c | 53 +----- > > drivers/thermal/samsung/exynos_tmu.c | 57 +++---- > > drivers/thermal/st/st_thermal.c | 47 +---- > > drivers/thermal/tegra/soctherm.c | 33 ++-- > > drivers/thermal/tegra/tegra30-tsensor.c | 17 +- > > drivers/thermal/thermal_core.c | 161 +++++++++++++++--- > > drivers/thermal/thermal_core.h | 24 +-- > > drivers/thermal/thermal_helpers.c | 28 +-- > > drivers/thermal/thermal_netlink.c | 21 +-- > > drivers/thermal/thermal_of.c | 116 ------------- > > drivers/thermal/thermal_sysfs.c | 133 +++++---------- > > drivers/thermal/ti-soc-thermal/ti-thermal.h | 15 -- > > drivers/thermal/uniphier_thermal.c | 27 ++- > > include/linux/thermal.h | 10 ++ > > 32 files changed, 560 insertions(+), 818 deletions(-) > > > > > -- > Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: Facebook | > Twitter | > Blog