Re: [PATCH v2] dt-bindings: irqchip: renesas: intc-irqpin: convert bindings to json-schema

From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshihiro Kaneko <ykaneko0929@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: irqchip: renesas: intc-irqpin: convert bindings to json-schema
Date: Fri, 11 Oct 2019 12:46:10 -0500	[thread overview]
Message-ID: <CAL_Jsq+9Am1KPE_=TX7_c+sdMt09hPzxXfz0kk53+pF13WtVxw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWR3HnT1-yp+i0OXAr2xF-6MANJDuXz1hj9WC1eUJjRAQ@mail.gmail.com>

On Fri, Oct 11, 2019 at 1:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob, Kaneko-san,
>
> On Fri, Oct 11, 2019 at 12:07 AM Rob Herring <robh@kernel.org> wrote:
> > On Fri, Sep 27, 2019 at 04:59:37AM +0900, Yoshihiro Kaneko wrote:
> > > Convert R-/SH-Mobile IRQPin Controller bindings documentation to json-schema.
> > >
> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.yaml
> > > @@ -0,0 +1,102 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/interrupt-controller/renesas,intc-irqpin.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: DT bindings for the R-/SH-Mobile irqpin controller
> > > +
> > > +maintainers:
> > > +  - Geert Uytterhoeven <geert+renesas@glider.be>
>
> Looks like I received many maintainerships recently ;-)

Maybe I should have called it something else, but I view this as who's
the owner not who applies it. There are lots of binding files with no
maintainer, so it's me by default. I wanted to avoid that and not by
having 4K MAINTAINERS entries.

> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:
> > > +      - enum:
> > > +          - renesas,intc-irqpin-r8a7740  # R-Mobile A1
> > > +          - renesas,intc-irqpin-r8a7778  # R-Car M1A
> > > +          - renesas,intc-irqpin-r8a7779  # R-Car H1
> > > +          - renesas,intc-irqpin-sh73a0   # SH-Mobile AG5
> > > +      - const: renesas,intc-irqpin
> > > +
> > > +  reg:
> > > +    # Base address and length of each register bank used by the external
> > > +    # IRQ pins driven by the interrupt controller hardware module. The base
> > > +    # addresses, length and number of required register banks varies with
> > > +    # soctype.
> > > +    minItems: 1
>
> minItems: 5
>
> > > +    maxItems: 6
> >
> > Every entry is the same thing?
>
> No they're not.
>
> First entry is the Interrupt control register.
> Second entry is the Interrupt priority register.
> Third entry is the Interrupt source register.
> Fourth entry is the Interrupt mask register.
> Fifth entry is the Interrupt mask clear register.
> Sixth entry is the optional Interrupt control register for ICR0 with IRLM bit.

So this should be an 'items' list with these descriptions.

Rob