From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63011C3A5A6 for ; Thu, 19 Sep 2019 19:34:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E07921924 for ; Thu, 19 Sep 2019 19:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568921653; bh=+CUvJCI/7IqSBXgdN6sRGavx1MrvIYeHONfgefFzPa0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=qCNboNfnb+0/1gArWWBwo/pi+O1Dor6KoXtsvrzAHPk499YxJtttHQa60G51jwWVl tduoR3hX+x60UGmGuG7G6OPpJFUrwGSshvGhkIxtf4rxPhGgpqdFoKSAjCgTQMwD4K LwcucPaekPkZb1L91bb750ciUTELjPJK5sBG6Ljg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392349AbfISTeM (ORCPT ); Thu, 19 Sep 2019 15:34:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:35394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389652AbfISTeM (ORCPT ); Thu, 19 Sep 2019 15:34:12 -0400 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9C7821924; Thu, 19 Sep 2019 19:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568921650; bh=+CUvJCI/7IqSBXgdN6sRGavx1MrvIYeHONfgefFzPa0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OjS0DkYtAstelI4CpKwFNkgnV0gd/3XeeK6yYCYeen3m408okyXwQ8SCJ+GG52mU5 2WM0CEIeNqQXgo3lLVOFtRE+gyMVL3eYkPfd/OaOve0LlJcZC9eDb+7VqxAZCpFDjA 1HDQojQ0LsrMMmSwG+xfE9RZFnfLd4nv9uzxaO+E= Received: by mail-qk1-f178.google.com with SMTP id u186so4664653qkc.5; Thu, 19 Sep 2019 12:34:10 -0700 (PDT) X-Gm-Message-State: APjAAAXBugqUQjtMaSIIg5iuzxbaKuKotSvIzZCasvDQKIZnM9MQXabZ 2LrVwxzorQVymQ4vcSSZONkN+u2ECtaQKui6kA== X-Google-Smtp-Source: APXvYqxTlzvU5G/7LsOlYQACfFRz4zpMe53+UHI+WV7ey+sGaDpo7n0xj91CXan1FYrIm19OBu7/ojsz4yxo2HQcEW4= X-Received: by 2002:a37:682:: with SMTP id 124mr4620208qkg.393.1568921649856; Thu, 19 Sep 2019 12:34:09 -0700 (PDT) MIME-Version: 1.0 References: <20190916153357.3880-1-horms+renesas@verge.net.au> <20190916153357.3880-2-horms+renesas@verge.net.au> <20190919151014.4azdfh2feg5ot6no@verge.net.au> In-Reply-To: <20190919151014.4azdfh2feg5ot6no@verge.net.au> From: Rob Herring Date: Thu, 19 Sep 2019 14:33:58 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: bus: simple-pm-bus: convert bindings to json-schema To: Simon Horman Cc: Mark Rutland , Geert Uytterhoeven , Magnus Damm , Yoshihiro Kaneko , devicetree@vger.kernel.org, "open list:MEDIA DRIVERS FOR RENESAS - FCP" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Sep 19, 2019 at 10:10 AM Simon Horman wrote: > > On Tue, Sep 17, 2019 at 07:12:16AM -0500, Rob Herring wrote: > > On Mon, Sep 16, 2019 at 10:35 AM Simon Horman > > wrote: > > > > > > Convert Simple Power-Managed Bus bindings documentation to json-schem= a. > > > > > > As a side effect of this change only simple-pm-bus is used in example= . A > > > follow-up patch will provide an example for the separately documented > > > Renesas Bus State Controller (BSC) that uses "renesas,bsc-sh73a0" and > > > "renesas,bsc" compat strings. > > > > > > Signed-off-by: Simon Horman > > > --- > > > * Tested using: > > > # ARCH=3Darm64 make dtbs_check DT_SCHEMA_FILES=3DDocumentation/devi= cetree/bindings/bus/simple-pm-bus.yaml > > > # ARCH=3Darm make dtbs_check DT_SCHEMA_FILES=3DDocumentation/devi= cetree/bindings/bus/simple-pm-bus.yaml > > > --- > > > .../devicetree/bindings/bus/simple-pm-bus.txt | 44 ------------= -- > > > .../devicetree/bindings/bus/simple-pm-bus.yaml | 68 ++++++++++++= ++++++++++ > > > 2 files changed, 68 insertions(+), 44 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/bus/simple-pm-b= us.txt > > > create mode 100644 Documentation/devicetree/bindings/bus/simple-pm-b= us.yaml > > > > > diff --git a/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml= b/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml > > > new file mode 100644 > > > index 000000000000..72a3644974e3 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml > > > @@ -0,0 +1,68 @@ > > > > SPDX tag? > > > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Simple Power-Managed Bus > > > + > > > +maintainers: > > > + - Geert Uytterhoeven > > > + > > > +description: | > > > + A Simple Power-Managed Bus is a transparent bus that doesn't need = a real > > > + driver, as it's typically initialized by the boot loader. > > > + > > > + However, its bus controller is part of a PM domain, or under the c= ontrol > > > + of a functional clock. Hence, the bus controller's PM domain and/= or > > > + clock must be enabled for child devices connected to the bus (eith= er > > > + on-SoC or externally) to function. > > > + > > > + While "simple-pm-bus" follows the "simple-bus" set of properties, = as > > > + specified in the Devicetree Specification, it is not an extension = of > > > + "simple-bus". > > > + > > > + > > > +properties: > > > > Add $nodename in here. > > > For now I have gone with: > > $nodename: > pattern: "^bus@[0-9a-f]+$" > > But this implies updating both msm8996.dtsi and the proposed > example (see below) to use bus@ rather than agnoc@. > > If this is the right way to to then perhaps it is best to use the > following until msm8996.dtsi is updated. I prefer to leave the warning there. > > $nodename: > pattern: "^(bus|agnoc)@[0-9a-f]+$" > > > > > > + compatible: > > > + items: > > > + - const: simple-pm-bus > > > > extra leading space. > > > > > + > > > + '#address-cells': > > > + const: 1 > > > + > > > + '#size-cells': > > > + const: 1 > > > > 1 or 2 should be valid... > > > > > + > > > + ranges: > > > + # Mapping between parent address and child address spaces. > > > + maxItems: 1 > > > > empty or multiple ranges should be possible. > > > > > + > > > + clocks: > > > + # Functional clocks > > > + # Required if power-domains is absent, optional otherwise > > > + minItems: 1 > > > > This will imply maxItems is 1 which I don't think you want. > > > > Though more than 1 starts to mean you need to know specifically what th= e h/w is. > > I have changed this to: > > clocks: true > # Functional clocks > # Required if power-domains is absent, optional otherwise > > > > + > > > + power-domains: > > > + # Required if clocks is absent, optional otherwise > > > + minItems: 1 > > > + > > > +required: > > > + - compatible > > > + - '#address-cells' > > > + - '#size-cells' > > > + - ranges > > > > This will capture what you commented above: > > > > oneOf: > > - required: > > - clocks > > - required: > > - power-domains > > Thanks. Unfortunately dtbs_check does not seem happy > if both clocks and power-domains are present. I was thinking it was either or. Use 'anyOf' instead. > > # cr make dtbs_check DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/= bus/simple-pm-bus.yaml > ... > /home/horms/projects/linux/renesas/arch/arm/boot/dts/r8a73a4-ape6evm.dt.y= aml: bus@fec10000: {'compatible': ['renesas,bsc-r8a73a4', 'renesas,bsc', 's= imple-pm-bus'], '#address-cells': [[1]], '#size-cells': [[1]], 'ranges': [[= 0, 0, 0, 536870912]], 'reg': [[0, 4274061312, 0, 1024]], 'clocks': [[27]], = 'power-domains': [[15]], 'flash@0': {'compatible': ['cfi-flash', 'mtd-rom']= , 'reg': [[0, 134217728]], 'bank-width': [[2]], 'partitions': {'compatible'= : ['fixed-partitions'], '#address-cells': [[1]], '#size-cells': [[1]], 'par= tition@0': {'label': ['uboot'], 'reg': [[0, 262144]], 'read-only': True}, '= partition@40000': {'label': ['uboot-env'], 'reg': [[262144, 262144]], 'read= -only': True}, 'partition@80000': {'label': ['flash'], 'reg': [[524288, 133= 693440]]}}}, 'ethernet@8000000': {'compatible': ['smsc,lan9220', 'smsc,lan9= 115'], 'reg': [[134217728, 4096]], 'interrupt-parent': [[18]], 'interrupts'= : [[8, 4]], 'phy-mode': ['mii'], 'reg-io-width': [[4]], 'smsc,irq-active-hi= gh': True, 'smsc,irq-push-pull': True, 'vdd33a-supply': [[23]], 'vddvario-s= upply': [[28]]}, '$nodename': ['bus@fec10000']} is valid under each of {'re= quired': ['power-domains']}, {'required': ['clocks']} > {'$filename': '/home/horms/projects/linux/renesas/Documentation/devicetre= e/bindings/bus/simple-pm-bus.yaml', > '$id': 'http://devicetree.org/schemas/bus/simple-pm-bus.yaml#', > '$schema': 'http://devicetree.org/meta-schemas/core.yaml#', > '$select_validator': .Validator ob= ject at 0x7fa9f2596048>, > 'oneOf': [{'required': ['clocks']}, {'required': ['power-domains']}], > 'patternProperties': {'pinctrl-[0-9]+': True}, > 'properties': {'#address-cells': {'items': {'items': {'const': 1}, > 'type': 'array'}, > 'type': 'array'}, > '#size-cells': {'items': {'items': {'enum': [1, 2]}, > 'type': 'array'}, > 'type': 'array'}, > '$nodename': {'additionalItems': False, > 'items': [{'pattern': '^(bus|agnoc)(@.*|-[0= -9a-f])*$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > 'clocks': True, > 'compatible': {'contains': {'const': 'simple-pm-bus'}}, > 'phandle': True, > 'pinctrl-names': True, > 'power-domains': {'maxItems': 1, 'minItems': 1}, > 'ranges': True, > 'status': True}, > 'required': ['compatible', '#address-cells', '#size-cells', 'ranges'], > 'select': {'properties': {'compatible': {'contains': {'enum': ['simple-p= m-bus']}}}, > 'required': ['compatible']}, > 'title': 'Simple Power-Managed Bus'} > > > > + > > > +examples: > > > + - | > > > + #include > > > + > > > + bsc: bus@fec10000 { > > > + compatible =3D "simple-pm-bus"; > > > + #address-cells =3D <1>; > > > + #size-cells =3D <1>; > > > + ranges =3D <0 0 0x20000000>; > > > + reg =3D <0xfec10000 0x400>; > > > > If you have reg, then it shouldn't be "simple-pm-bus" unless you can > > function without accessing the regs. > > > > > + interrupts =3D <0 39 IRQ_TYPE_LEVEL_HIGH>; > > > > Not documented? > > > > > + clocks =3D <&zb_clk>; > > > + power-domains =3D <&pd_a4s>; > > > + }; > > As per discussion elsewhere in this thread, I have updated this to the > example in msm8996.dtsi. > > agnoc@0 { s/agnoc/bus/ Also there shouldn't be a unit address unless there's 'reg' or non-empty ra= nges. There's no reason that examples have to match anything real. Doing so just invites pointless fixes to examples. > power-domains =3D <&gcc AGGRE0_NOC_GDSC>; > compatible =3D "simple-pm-bus"; > #address-cells =3D <1>; > #size-cells =3D <1>; > ranges; > }; > > > > -- > > > 2.11.0 > > > > >