linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Chris Brandt <chris.brandt@renesas.com>,
	linux-devicetree <devicetree@vger.kernel.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: Add support for CAT9554
Date: Thu, 21 Mar 2019 10:03:48 +0100	[thread overview]
Message-ID: <CAMpxmJUSwR8FSkMAQsSvpRHYRDLiheJb02r7imkA=zOhoQFkJg@mail.gmail.com> (raw)
In-Reply-To: <20190320103600.20875-1-geert+renesas@glider.be>

śr., 20 mar 2019 o 11:36 Geert Uytterhoeven <geert+renesas@glider.be>
napisał(a):
>
> The ON Semiconductor CAT9554 is a variant of the PCA953x GPIO expander,
> with 8 GPIOs and interrupt functionality.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
>  drivers/gpio/gpio-pca953x.c                             | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> index fb144e2b65226601..8678df2a5713a9af 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> @@ -30,6 +30,7 @@ Required properties:
>         ti,tca6424
>         ti,tca9539
>         ti,tca9554
> +       onnn,cat9554
>         onnn,pca9654
>         exar,xra1202
>   - gpio-controller: if used as gpio expander.
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 7e76830b33682aa3..88c94d155e218535 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -1167,6 +1167,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
>         { .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
>         { .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
>
> +       { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
>         { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
>
>         { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
> --
> 2.17.1
>

Hi Geert,

I'm seeing that historically we always would split the patches adding
the new compatible to the DT bindings and the actual support
implementation into separate commits. Could you do the same here?

Thanks,
Bart

      reply	other threads:[~2019-03-21  9:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 10:36 [PATCH] gpio: pca953x: Add support for CAT9554 Geert Uytterhoeven
2019-03-21  9:03 ` Bartosz Golaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMpxmJUSwR8FSkMAQsSvpRHYRDLiheJb02r7imkA=zOhoQFkJg@mail.gmail.com' \
    --to=bgolaszewski@baylibre.com \
    --cc=chris.brandt@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).