From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEADEC742B9 for ; Fri, 12 Jul 2019 12:38:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B45D220645 for ; Fri, 12 Jul 2019 12:38:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728569AbfGLM3c (ORCPT ); Fri, 12 Jul 2019 08:29:32 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:35829 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728998AbfGLM3a (ORCPT ); Fri, 12 Jul 2019 08:29:30 -0400 Received: by mail-ot1-f68.google.com with SMTP id j19so9289632otq.2; Fri, 12 Jul 2019 05:29:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oEdcVtCqnAmcikhOKq8zHJ48dzBynV9gjlaZHvc/aWA=; b=f4crqYI8oUH7sZA3Zkze8ETa5sFKl6o48gI3P4GH1UaISPKPKFrkztxP9vDHLWb/WT cRDnH6VCdMsHQmY/eAFzHTxyME0W4JL3m7MJXJVKMAuQmyRMWudpArQr4Hg0lQScr/6j Ru0n3RY/P+nzzD8/ZfBDHPSb8QRlmL9Ou+xCjOssI7SLnSZnY5356wUUG4GhY5KwAc4X eXyWkHyAd2Kf8SOVmWD2ZskTLXNicpWMKfRyeIdCX9dtie22qllbPNyRFm920BK9t4RO rLB+gszkbXnyjHCNned8f7pjuiKtDudCD5ATSsNMebRKXN77fDlHgro8H1DPqt/9Nr/K WkPw== X-Gm-Message-State: APjAAAUx3KE57D6YOPbcR/68YM6MyoGXr/3EIoUUnMLokzeVBfCEt/pb sFqD2HzU064Dsy7o3lV72ZPTuo+XhZC3HFfvbKg= X-Google-Smtp-Source: APXvYqw9RWe0Lk5Iw2vrCQIx/W+CQhgWkC9teDx9sc3MNmIW16eMpmIpD1KwHThNlDLBfxc6yXSTao6gi9bFb0xYxfI= X-Received: by 2002:a9d:69ce:: with SMTP id v14mr8468916oto.39.1562934569988; Fri, 12 Jul 2019 05:29:29 -0700 (PDT) MIME-Version: 1.0 References: <1562321720-18735-1-git-send-email-biju.das@bp.renesas.com> <1562321720-18735-2-git-send-email-biju.das@bp.renesas.com> In-Reply-To: <1562321720-18735-2-git-send-email-biju.das@bp.renesas.com> From: Geert Uytterhoeven Date: Fri, 12 Jul 2019 14:29:18 +0200 Message-ID: Subject: Re: [PATCH 1/3] arm64: dts: renesas: hihope-common: Add PCA9654 I/O expander To: Biju Das Cc: Rob Herring , Mark Rutland , Simon Horman , Geert Uytterhoeven , Magnus Damm , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Fabrizio Castro Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Biju, On Fri, Jul 5, 2019 at 12:20 PM Biju Das wrote: > Enable PCA9654 GPIO expander, so that we can configure its GPIOs later. > > Signed-off-by: Biju Das > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > @@ -162,6 +162,13 @@ > clock-frequency = <400000>; > status = "okay"; > > + gpio_expander: gpio@20 { > + compatible = "onnn,pca9654"; > + reg = <0x20>; > + gpio-controller; > + #gpio-cells = <2>; You may want to describe that the interrupt output is tied to GP5_25? > + }; > + Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds