From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE8BBC31E5B for ; Tue, 18 Jun 2019 15:10:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2B79213F2 for ; Tue, 18 Jun 2019 15:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727105AbfFRPKe (ORCPT ); Tue, 18 Jun 2019 11:10:34 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:46267 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbfFRPKe (ORCPT ); Tue, 18 Jun 2019 11:10:34 -0400 Received: by mail-lj1-f195.google.com with SMTP id v24so13487389ljg.13; Tue, 18 Jun 2019 08:10:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqHa7v+zRz/0tP12kNuD3++mOq4qacpMRNqcsvo74fg=; b=Pr/F3sRzK/jhhCm7XPrSEuuKZHKSIKPQmPRDk6F/8LA+Z/e4vyZ2bH2SJyuYxMFJ1E R81HjPo8ZgjI+DYmVpDgEM2VBEoZWys2yIcP7Y08jCWzS7gaAZ2W6floTPZVdcSWXVyV GnzDETA1vgE7HQEqb8m8Wcf0zU5XHoBDZulaNZi7XauD+zCOCRsYdUmhER/rLeM3ZvZy nfQXct45IbJ7AX5qnS5+VC3iM7EnVgtNXh/eXI+o3FIp8LCEiCtIOh1MdEzzq6u4wtm/ tuuJYd/IuJOdcIAy8zHa0+xUC0rnbRpSeMiT/ga4aqNArON9MBXSCLUgujIiEAI0birG BzKA== X-Gm-Message-State: APjAAAWIKSbYDC6D6klWGRbXZpjYksv2lkllj+IAuFxsTkycwAShmhMd VycTBzWY53W2QSCQAHC5Ae8aJXXqEJ8HoKVt4/A= X-Google-Smtp-Source: APXvYqw1fdB/y1vZFxbdUmlNShYTaVT+8vEn2zAimF9nYv/bG9SWMVnXfSvmGlQtqPX6Gn/G2Rj4SW8LQvkAUlL1OZk= X-Received: by 2002:a2e:9a87:: with SMTP id p7mr14854442lji.133.1560870632312; Tue, 18 Jun 2019 08:10:32 -0700 (PDT) MIME-Version: 1.0 References: <1560518075-2254-1-git-send-email-fabrizio.castro@bp.renesas.com> In-Reply-To: <1560518075-2254-1-git-send-email-fabrizio.castro@bp.renesas.com> From: Geert Uytterhoeven Date: Tue, 18 Jun 2019 17:10:19 +0200 Message-ID: Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support To: Fabrizio Castro Cc: Simon Horman , Geert Uytterhoeven , Rob Herring , Mark Rutland , Magnus Damm , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Biju Das , xu_shunji@hoperun.com Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Fabrizio, On Fri, Jun 14, 2019 at 3:17 PM Fabrizio Castro wrote: > This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board > common device tree. > > Signed-off-by: Fabrizio Castro Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > @@ -17,6 +17,30 @@ > stdout-path = "serial0:115200n8"; > }; > > + leds { > + compatible = "gpio-leds"; > + > + led0 { > + gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>; > + label = "LED0"; There's no need for a label property, if it matches the node name (applies to all four LEDs). Note that this GPIO is shared with a switch, like on Salvator-X(S) and ULCB. As currently Linux cannot handle both, describing the LED precludes adding the switch later. (applies to the first 3 LEDs). > + led3 { > + gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>; > + label = "LED3"; > + }; I cannot find LED3. According to the schematics GP0_0 == CS0n is used as the chipselect for the LVDS switch? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds