Re: [PATCH 1/6] thermal: split thermal_zone_of_sensor_register{,_param}()

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Eduardo Valentin <edubezval@gmail.com>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH 1/6] thermal: split thermal_zone_of_sensor_register{,_param}()
Date: Sat, 15 Dec 2018 21:00:58 +0100	[thread overview]
Message-ID: <CAMuHMdUJPLu2H5dYZjFG1oKYOoXiQGE6_S8BFK8c7Nue_Dfqzg@mail.gmail.com> (raw)
In-Reply-To: <076ebc8e-32a3-99bf-6d8a-7a0bae22b427@gmail.com>

Hi Marek,

On Sat, Dec 15, 2018 at 8:07 PM Marek Vasut <marek.vasut@gmail.com> wrote:
> On 12/15/2018 07:54 PM, Geert Uytterhoeven wrote:
> > On Sat, Dec 15, 2018 at 7:49 PM Marek Vasut <marek.vasut@gmail.com> wrote:
> >> On 12/15/2018 07:47 PM, Geert Uytterhoeven wrote:
> >>> On Sat, Dec 15, 2018 at 7:38 PM Marek Vasut <marek.vasut@gmail.com> wrote:
> >>>> On 12/15/2018 06:23 PM, Eduardo Valentin wrote:
> >>>>> On Wed, Dec 12, 2018 at 02:49:22AM +0100, Marek Vasut wrote:
> >>>>>> Introduce new thermal_zone_of_sensor_register_params() function, which
> >>>>>> allows passing struct thermal_zone_params into it and convert original
> >>>>>> thermal_zone_of_sensor_register() to call it with params set to NULL.
> >>>>>>
> >>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >>>>>
> >>>>> Git complains about mismatch between From: and this SOB.
> >>>>
> >>>> I recall a discussion about gmail stripping the +foo tags from email
> >>>> addresses. I can add a From: tag into the patch to override this
> >>>> braindeath, or is there a better solution ?
> >>>
> >>> Run the "git format-patch" command from a git repo where user.email
> >>> is marek.vasut@gmail.com, so it will retain the original From: tag in the
> >>> email body, as it is different?
> >>
> >> I can also manually patch the From tags or add them, but it's all
> >> workarounds.
> >
> > Use a different outgoing email server? I use my ISP's.
>
> Or maybe it'd make sense to fix git to handle the +tags correctly ?

What needs to be fixed?
If user.email != From, git format-patch generates a From: header, else
it doesn't. Doesn't that make sense?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds