From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Chris Paterson <chris.paterson2@renesas.com>,
"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2] ARM: dts: iwg22d-sodimm: enable LCD panel
Date: Wed, 11 Mar 2020 09:10:36 +0100 [thread overview]
Message-ID: <CAMuHMdUO1OMhGuBK5Q-CxB2gta3c7K4yuOW05hOw6xAUfRD7vQ@mail.gmail.com> (raw)
In-Reply-To: <1583239490-8837-1-git-send-email-marian-cristian.rotariu.rb@bp.renesas.com>
Hi Marian,
On Tue, Mar 3, 2020 at 2:06 PM Marian-Cristian Rotariu
<marian-cristian.rotariu.rb@bp.renesas.com> wrote:
> On the Generic SODIMM Development Platform there is an RGB LCD panel
> directly connected to the DU output. It uses the TPU0 as backlight, one
> GPIO pull-up configuration for power enable, R[2:7], G[2:7], B[2:7],
> VSYNC, HSYNC, DU0_DISP and, DU0_CLK as inputs.
>
> There is no encoder between the DU and the panel, therefore the default
> connector driver is used.
>
> The two variants of the iW-G22D should be mutually exclusive, therefore
> this patch also disables the RGB LCD display when the HDMI extension board
> is used.
>
> Changes for v2:
> - fix the backlight of the panel
> - remove "simple-panel" compatible as it is not needed
> - use only one port for the endpoint connection of the panel
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -150,11 +194,21 @@
> function = "avb";
> };
>
> + backlight_pins: backlight {
> + renesas,groups = "tpu_to3_c";
> + renesas,function = "tpu";
> + };
> +
> can0_pins: can0 {
> groups = "can0_data";
> function = "can0";
> };
>
> + du0_pins: du0 {
> + renesas,groups = "du0_rgb666", "du0_sync", "du0_disp", "du0_clk0_out";
> + renesas,function = "du0";
> + };
> +
> hscif1_pins: hscif1 {
> groups = "hscif1_data", "hscif1_ctrl";
> function = "hscif1";
As discussed on IRC, I've removed the bogus "renesas," prefixes, and
updated my branches for v5.7.
Thanks for reporting!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-03-11 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 12:44 [PATCH v2] ARM: dts: iwg22d-sodimm: enable LCD panel Marian-Cristian Rotariu
2020-03-06 13:03 ` Geert Uytterhoeven
2020-03-11 8:10 ` Geert Uytterhoeven [this message]
2020-03-11 9:00 ` Marian-Cristian Rotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUO1OMhGuBK5Q-CxB2gta3c7K4yuOW05hOw6xAUfRD7vQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=chris.paterson2@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marian-cristian.rotariu.rb@bp.renesas.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).