From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ABFCC433F5 for ; Thu, 23 Sep 2021 07:00:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 807FB610D1 for ; Thu, 23 Sep 2021 07:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239380AbhIWHBx (ORCPT ); Thu, 23 Sep 2021 03:01:53 -0400 Received: from mail-vk1-f176.google.com ([209.85.221.176]:42878 "EHLO mail-vk1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239370AbhIWHBx (ORCPT ); Thu, 23 Sep 2021 03:01:53 -0400 Received: by mail-vk1-f176.google.com with SMTP id o204so2176939vko.9; Thu, 23 Sep 2021 00:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YmpAdGBuoZ2H4vsYmz/gaaH8SFsdh1aIHAgypR+PGH4=; b=RA1yWcbGx086ibONZtnUw1iC/br73vqaUuB61rx0a2folwICoct+brQSpQO3O81ZvS cZhj/V757OumRLCgJhW3VNijE6nS/sewD5wvSe4azkwTLZVAQ5YIT/rrHIv/gE3sl1/f qUaO/QEoiPa4p388R5LcjviHmN2oI51c6z2NBUmyRDmz6WnvpErpWED9gpTOcj8oyTAS S3DL264gjq/HPso5Sc91aErI11i7uogV+MneAfxErre6Z6x6mojDEQiJUj06MvT/V/Wr XbXjXNIC6sfCQnZ+VVaF2ydnqcrKvFhmqUQL3NnrERb3hXWR1p+P37XeJl/nvn/HuVZp okqA== X-Gm-Message-State: AOAM530TNHnYHaVkn/jK1Sfxe1Gyr0u1ZZC81vPwusYRKfBdL1+YQ6Mh 974SuDMwaFIa3MokuGAlzSTYUoiDQWnZd3nLiOhyjm4eaR4= X-Google-Smtp-Source: ABdhPJxrSnRuqRIPIA1q7UmwoFsiu8wwdht1494jD4SuBcubaowOHjiICmyOgzRobpfLJFy7CS+6PGcR734kT66e/3Y= X-Received: by 2002:a1f:3a4b:: with SMTP id h72mr2062529vka.19.1632380421342; Thu, 23 Sep 2021 00:00:21 -0700 (PDT) MIME-Version: 1.0 References: <20210923010402.3418555-1-kieran.bingham@ideasonboard.com> <20210923010402.3418555-2-kieran.bingham@ideasonboard.com> In-Reply-To: <20210923010402.3418555-2-kieran.bingham@ideasonboard.com> From: Geert Uytterhoeven Date: Thu, 23 Sep 2021 09:00:09 +0200 Message-ID: Subject: Re: [PATCH v3 1/3] arm64: dts: renesas: r8a779a0: Add DU support To: Kieran Bingham Cc: Linux-Renesas , Laurent Pinchart , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Kieran, On Thu, Sep 23, 2021 at 3:04 AM Kieran Bingham wrote: > From: Kieran Bingham > Provide the device nodes for the DU on the V3U platforms. > > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart > Signed-off-by: Kieran Bingham > --- > v2 > - Use a single clock specification for the whole DU. > > v3: > - Use 'du.0' clock name instead of 'du' Thanks for the update! > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > @@ -1251,6 +1251,36 @@ vspd1: vsp@fea28000 { > renesas,fcp = <&fcpvd1>; > }; > > + du: display@feb00000 { > + compatible = "renesas,du-r8a779a0"; > + reg = <0 0xfeb00000 0 0x40000>; > + interrupts = , > + ; > + clocks = <&cpg CPG_MOD 411>; > + clock-names = "du.0"; > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > + resets = <&cpg 411>; You missed reset-names. > + vsps = <&vspd0 0>, <&vspd1 0>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + du_out_dsi0: endpoint { > + }; > + }; > + > + port@1 { > + reg = <1>; > + du_out_dsi1: endpoint { > + }; > + }; > + }; > + }; > + > prr: chipid@fff00044 { > compatible = "renesas,prr"; > reg = <0 0xfff00044 0 4>; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds