From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ulrich Hecht <uli@fpond.eu>
Cc: Dirk Behme <dirk.behme@de.bosch.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
"George G. Davis" <george_davis@mentor.com>,
Andy Lowe <andy_lowe@mentor.com>,
Joshua Frkuska <joshua_frkuska@mentor.com>,
Tobias Franzen <tfranzen@de.adit-jv.com>,
Magnus Damm <magnus.damm@gmail.com>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment
Date: Fri, 29 Mar 2019 10:56:15 +0100 [thread overview]
Message-ID: <CAMuHMdUf6rKxUi14DyJ2kJOGoZA2T+ktTpusBpaJD3rRJ0ZZzg@mail.gmail.com> (raw)
In-Reply-To: <1244832967.1529522.1553852778122@webmail.strato.com>
Hi Uli,
On Fri, Mar 29, 2019 at 10:46 AM Ulrich Hecht <uli@fpond.eu> wrote:
> Reviewing the code, I have found another potential issue: the SRR (sampling rate) value is not validated; only values from 7 to 31 are permissible, according to the datasheet. The values in the debug output above would be fine, though.
Isn't that handled by
.sampling_rate_mask = SCI_SR_RANGE(8, 32),
?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-03-29 9:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 15:48 [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment Ulrich Hecht
2018-04-24 15:15 ` Geert Uytterhoeven
2019-03-27 18:35 ` Eugeniu Rosca
2019-03-28 8:33 ` Wolfram Sang
2019-03-28 9:24 ` Geert Uytterhoeven
2019-03-28 10:16 ` Dirk Behme
2019-03-28 11:30 ` Dirk Behme
2019-03-29 7:05 ` Dirk Behme
2019-03-29 9:46 ` Ulrich Hecht
2019-03-29 9:56 ` Geert Uytterhoeven [this message]
2019-03-29 10:35 ` Ulrich Hecht
2019-03-29 11:01 ` Ulrich Hecht
2019-03-29 11:17 ` Dirk Behme
2019-03-29 9:46 ` Geert Uytterhoeven
2019-03-29 12:13 ` Dirk Behme
2019-03-29 13:00 ` Geert Uytterhoeven
2019-03-29 14:11 ` Ulrich Hecht
2019-04-01 6:05 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUf6rKxUi14DyJ2kJOGoZA2T+ktTpusBpaJD3rRJ0ZZzg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=andy_lowe@mentor.com \
--cc=dirk.behme@de.bosch.com \
--cc=erosca@de.adit-jv.com \
--cc=george_davis@mentor.com \
--cc=greg@kroah.com \
--cc=joshua_frkuska@mentor.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=roscaeugeniu@gmail.com \
--cc=tfranzen@de.adit-jv.com \
--cc=uli@fpond.eu \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).