linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Linux PWM List <linux-pwm@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] pwm: Add power management descriptions
Date: Fri, 31 May 2019 11:28:52 +0200	[thread overview]
Message-ID: <CAMuHMdUkYChEX+uaxqAhHRTDKPST9HZNqOKGTf2kxM0F+_nsxQ@mail.gmail.com> (raw)
In-Reply-To: <OSAPR01MB3089658CD2E8DF789BA7737FD8190@OSAPR01MB3089.jpnprd01.prod.outlook.com>

Hi Shimoda-san,

On Fri, May 31, 2019 at 11:22 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > On Thu, May 30, 2019 at 12:21 PM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > This patch adds power management descriptions that consumers should
> > > implement it.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/pwm.txt
> > > +++ b/Documentation/pwm.txt
> >
> > > @@ -141,6 +145,9 @@ The implementation of ->get_state() (a method used to retrieve initial PWM
> > >  state) is also encouraged for the same reason: letting the PWM user know
> > >  about the current PWM state would allow him to avoid glitches.
> > >
> > > +Drivers should not implement any power management. In other words,
> > > +consumers should implement it as described as the "Using PWMs" section.
> >
> > s/as/in/
>
> So, "... in described as ..." ?
>
> I'm not a native speaker, so that any cases below seem not so different to me :)
>
> 1. "... as described as ..."
> 2. "... in described as ..."
> 3. "... as described in ..."
> 4. "... in described in ..."

Sorry for being unclear: "... as described in ..."

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2019-05-31  9:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 10:16 [PATCH v2 0/4] pwm: add power management on sysfs and switch to SPDX Yoshihiro Shimoda
2019-05-30 10:16 ` [PATCH v2 1/4] pwm: Add power management descriptions Yoshihiro Shimoda
2019-05-31  7:20   ` Geert Uytterhoeven
2019-05-31  9:22     ` Yoshihiro Shimoda
2019-05-31  9:28       ` Geert Uytterhoeven [this message]
2019-05-31  9:31         ` Yoshihiro Shimoda
2019-05-30 10:16 ` [PATCH v2 2/4] pwm: sysfs: Switch to SPDX identifier Yoshihiro Shimoda
2019-05-31  7:20   ` Geert Uytterhoeven
2019-05-30 10:16 ` [PATCH v2 3/4] pwm: sysfs: Add suspend/resume support Yoshihiro Shimoda
2019-05-31  7:34   ` Geert Uytterhoeven
2019-05-31  9:24     ` Yoshihiro Shimoda
2019-05-30 10:16 ` [PATCH v2 4/4] pwm: rcar: Remove " Yoshihiro Shimoda
2019-05-31  7:35   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUkYChEX+uaxqAhHRTDKPST9HZNqOKGTf2kxM0F+_nsxQ@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).