Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH 3/3] dt-bindings: PCI: Convert generic host binding to DT schema
       [not found] ` <20191116005240.15722-3-robh@kernel.org>
@ 2019-12-12 14:41   ` Geert Uytterhoeven
  2019-12-30 23:29     ` Rob Herring
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-12-12 14:41 UTC (permalink / raw)
  To: Rob Herring
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, linux-pci, Bjorn Helgaas,
	Lorenzo Pieralisi, Andrew Murray, Zhou Wang, Will Deacon,
	David Daney, Linux-Renesas

Hi Rob,

On Sat, Nov 16, 2019 at 1:53 AM Rob Herring <robh@kernel.org> wrote:
> Convert the generic PCI host binding to DT schema. The derivative Juno,
> PLDA XpressRICH3-AXI, and Designware ECAM bindings all just vary in
> their compatible strings. The simplest way to convert those to
> schema is just add them into the common generic PCI host schema.
>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Andrew Murray <andrew.murray@arm.com>
> Cc: Zhou Wang <wangzhou1@hisilicon.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: David Daney <david.daney@cavium.com>
> Signed-off-by: Rob Herring <robh@kernel.org>

> index 515b2f9542e5..000000000000
> --- a/Documentation/devicetree/bindings/pci/designware-pcie-ecam.txt
> +++ /dev/null

> -Example:
> -
> -    pcie1: pcie@7f000000 {
> -        compatible = "socionext,synquacer-pcie-ecam", "snps,dw-pcie-ecam";
> -        device_type = "pci";
> -        reg = <0x0 0x7f000000 0x0 0xf00000>;
> -        bus-range = <0x0 0xe>;
> -        #address-cells = <3>;
> -        #size-cells = <2>;
> -        ranges = <0x1000000 0x00 0x00010000 0x00 0x7ff00000 0x0 0x00010000>,
> -                 <0x2000000 0x00 0x70000000 0x00 0x70000000 0x0 0x0f000000>,
> -                 <0x3000000 0x3f 0x00000000 0x3f 0x00000000 0x1 0x00000000>;
> -
> -        #interrupt-cells = <0x1>;
> -        interrupt-map-mask = <0x0 0x0 0x0 0x0>;

An all-zeroes interrupt-map-mask seems to be very common on embedded
SoCs, where all devices are mapped to a single interrupt.

However, schemas/pci/pci-bus.yaml says:

  interrupt-map-mask:
    items:
      - description: PCI high address cell
        minimum: 0
        maximum: 0xf800
      - description: PCI mid address cell
        const: 0
      - description: PCI low address cell
        const: 0
      - description: PCI IRQ cell
        minimum: 1
        maximum: 7

and thus complains about an all-zeroes mask, e.g.

    arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dt.yaml:
pcie@fe000000: interrupt-map-mask:0:3: 0 is less than the minimum of 1

> -        interrupt-map = <0x0 0x0 0x0 0x0 &gic 0x0 0x0 0x0 182 0x4>;
> -        msi-map = <0x0 &its 0x0 0x10000>;
> -        dma-coherent;
> -    };

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 3/3] dt-bindings: PCI: Convert generic host binding to DT schema
  2019-12-12 14:41   ` [PATCH 3/3] dt-bindings: PCI: Convert generic host binding to DT schema Geert Uytterhoeven
@ 2019-12-30 23:29     ` Rob Herring
  2019-12-31  8:23       ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2019-12-30 23:29 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, linux-pci, Bjorn Helgaas,
	Lorenzo Pieralisi, Andrew Murray, Zhou Wang, Will Deacon,
	David Daney, Linux-Renesas

On Thu, Dec 12, 2019 at 7:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Sat, Nov 16, 2019 at 1:53 AM Rob Herring <robh@kernel.org> wrote:
> > Convert the generic PCI host binding to DT schema. The derivative Juno,
> > PLDA XpressRICH3-AXI, and Designware ECAM bindings all just vary in
> > their compatible strings. The simplest way to convert those to
> > schema is just add them into the common generic PCI host schema.
> >
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Cc: Andrew Murray <andrew.murray@arm.com>
> > Cc: Zhou Wang <wangzhou1@hisilicon.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: David Daney <david.daney@cavium.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> > index 515b2f9542e5..000000000000
> > --- a/Documentation/devicetree/bindings/pci/designware-pcie-ecam.txt
> > +++ /dev/null
>
> > -Example:
> > -
> > -    pcie1: pcie@7f000000 {
> > -        compatible = "socionext,synquacer-pcie-ecam", "snps,dw-pcie-ecam";
> > -        device_type = "pci";
> > -        reg = <0x0 0x7f000000 0x0 0xf00000>;
> > -        bus-range = <0x0 0xe>;
> > -        #address-cells = <3>;
> > -        #size-cells = <2>;
> > -        ranges = <0x1000000 0x00 0x00010000 0x00 0x7ff00000 0x0 0x00010000>,
> > -                 <0x2000000 0x00 0x70000000 0x00 0x70000000 0x0 0x0f000000>,
> > -                 <0x3000000 0x3f 0x00000000 0x3f 0x00000000 0x1 0x00000000>;
> > -
> > -        #interrupt-cells = <0x1>;
> > -        interrupt-map-mask = <0x0 0x0 0x0 0x0>;
>
> An all-zeroes interrupt-map-mask seems to be very common on embedded
> SoCs, where all devices are mapped to a single interrupt.

Indeed.

> However, schemas/pci/pci-bus.yaml says:
>
>   interrupt-map-mask:
>     items:
>       - description: PCI high address cell
>         minimum: 0
>         maximum: 0xf800
>       - description: PCI mid address cell
>         const: 0
>       - description: PCI low address cell
>         const: 0
>       - description: PCI IRQ cell
>         minimum: 1
>         maximum: 7
>
> and thus complains about an all-zeroes mask, e.g.
>
>     arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dt.yaml:
> pcie@fe000000: interrupt-map-mask:0:3: 0 is less than the minimum of 1

Now fixed.

Thanks,
Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 3/3] dt-bindings: PCI: Convert generic host binding to DT schema
  2019-12-30 23:29     ` Rob Herring
@ 2019-12-31  8:23       ` Geert Uytterhoeven
  2019-12-31 14:31         ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-12-31  8:23 UTC (permalink / raw)
  To: Rob Herring
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, linux-pci, Bjorn Helgaas,
	Lorenzo Pieralisi, Andrew Murray, Zhou Wang, Will Deacon,
	David Daney, Linux-Renesas

Hi Rob,

On Tue, Dec 31, 2019 at 12:30 AM Rob Herring <robh@kernel.org> wrote:
> On Thu, Dec 12, 2019 at 7:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Sat, Nov 16, 2019 at 1:53 AM Rob Herring <robh@kernel.org> wrote:
> > > Convert the generic PCI host binding to DT schema. The derivative Juno,
> > > PLDA XpressRICH3-AXI, and Designware ECAM bindings all just vary in
> > > their compatible strings. The simplest way to convert those to
> > > schema is just add them into the common generic PCI host schema.
> > >
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > Cc: Andrew Murray <andrew.murray@arm.com>
> > > Cc: Zhou Wang <wangzhou1@hisilicon.com>
> > > Cc: Will Deacon <will@kernel.org>
> > > Cc: David Daney <david.daney@cavium.com>
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > > index 515b2f9542e5..000000000000
> > > --- a/Documentation/devicetree/bindings/pci/designware-pcie-ecam.txt
> > > +++ /dev/null
> >
> > > -Example:
> > > -
> > > -    pcie1: pcie@7f000000 {
> > > -        compatible = "socionext,synquacer-pcie-ecam", "snps,dw-pcie-ecam";
> > > -        device_type = "pci";
> > > -        reg = <0x0 0x7f000000 0x0 0xf00000>;
> > > -        bus-range = <0x0 0xe>;
> > > -        #address-cells = <3>;
> > > -        #size-cells = <2>;
> > > -        ranges = <0x1000000 0x00 0x00010000 0x00 0x7ff00000 0x0 0x00010000>,
> > > -                 <0x2000000 0x00 0x70000000 0x00 0x70000000 0x0 0x0f000000>,
> > > -                 <0x3000000 0x3f 0x00000000 0x3f 0x00000000 0x1 0x00000000>;
> > > -
> > > -        #interrupt-cells = <0x1>;
> > > -        interrupt-map-mask = <0x0 0x0 0x0 0x0>;
> >
> > An all-zeroes interrupt-map-mask seems to be very common on embedded
> > SoCs, where all devices are mapped to a single interrupt.
>
> Indeed.
>
> > However, schemas/pci/pci-bus.yaml says:
> >
> >   interrupt-map-mask:
> >     items:
> >       - description: PCI high address cell
> >         minimum: 0
> >         maximum: 0xf800
> >       - description: PCI mid address cell
> >         const: 0
> >       - description: PCI low address cell
> >         const: 0
> >       - description: PCI IRQ cell
> >         minimum: 1
> >         maximum: 7
> >
> > and thus complains about an all-zeroes mask, e.g.
> >
> >     arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dt.yaml:
> > pcie@fe000000: interrupt-map-mask:0:3: 0 is less than the minimum of 1
>
> Now fixed.

Thank you, confirmed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 3/3] dt-bindings: PCI: Convert generic host binding to DT schema
  2019-12-31  8:23       ` Geert Uytterhoeven
@ 2019-12-31 14:31         ` Geert Uytterhoeven
  2019-12-31 17:10           ` Rob Herring
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-12-31 14:31 UTC (permalink / raw)
  To: Rob Herring
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, linux-pci, Bjorn Helgaas,
	Lorenzo Pieralisi, Andrew Murray, Zhou Wang, Will Deacon,
	David Daney, Linux-Renesas

Hi Rob,

On Tue, Dec 31, 2019 at 9:23 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Dec 31, 2019 at 12:30 AM Rob Herring <robh@kernel.org> wrote:
> > On Thu, Dec 12, 2019 at 7:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Sat, Nov 16, 2019 at 1:53 AM Rob Herring <robh@kernel.org> wrote:
> > > > Convert the generic PCI host binding to DT schema. The derivative Juno,
> > > > PLDA XpressRICH3-AXI, and Designware ECAM bindings all just vary in
> > > > their compatible strings. The simplest way to convert those to
> > > > schema is just add them into the common generic PCI host schema.
> > > >
> > > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > > Cc: Andrew Murray <andrew.murray@arm.com>
> > > > Cc: Zhou Wang <wangzhou1@hisilicon.com>
> > > > Cc: Will Deacon <will@kernel.org>
> > > > Cc: David Daney <david.daney@cavium.com>
> > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > >
> > > > index 515b2f9542e5..000000000000
> > > > --- a/Documentation/devicetree/bindings/pci/designware-pcie-ecam.txt
> > > > +++ /dev/null
> > >
> > > > -Example:
> > > > -
> > > > -    pcie1: pcie@7f000000 {
> > > > -        compatible = "socionext,synquacer-pcie-ecam", "snps,dw-pcie-ecam";
> > > > -        device_type = "pci";
> > > > -        reg = <0x0 0x7f000000 0x0 0xf00000>;
> > > > -        bus-range = <0x0 0xe>;
> > > > -        #address-cells = <3>;
> > > > -        #size-cells = <2>;
> > > > -        ranges = <0x1000000 0x00 0x00010000 0x00 0x7ff00000 0x0 0x00010000>,
> > > > -                 <0x2000000 0x00 0x70000000 0x00 0x70000000 0x0 0x0f000000>,
> > > > -                 <0x3000000 0x3f 0x00000000 0x3f 0x00000000 0x1 0x00000000>;
> > > > -
> > > > -        #interrupt-cells = <0x1>;
> > > > -        interrupt-map-mask = <0x0 0x0 0x0 0x0>;
> > >
> > > An all-zeroes interrupt-map-mask seems to be very common on embedded
> > > SoCs, where all devices are mapped to a single interrupt.
> >
> > Indeed.
> >
> > > However, schemas/pci/pci-bus.yaml says:
> > >
> > >   interrupt-map-mask:
> > >     items:
> > >       - description: PCI high address cell
> > >         minimum: 0
> > >         maximum: 0xf800
> > >       - description: PCI mid address cell
> > >         const: 0
> > >       - description: PCI low address cell
> > >         const: 0
> > >       - description: PCI IRQ cell
> > >         minimum: 1
> > >         maximum: 7
> > >
> > > and thus complains about an all-zeroes mask, e.g.
> > >
> > >     arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dt.yaml:
> > > pcie@fe000000: interrupt-map-mask:0:3: 0 is less than the minimum of 1
> >
> > Now fixed.
>
> Thank you, confirmed.

And with latest renesas-drivers, I started seeing:

    arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
interrupt-map:0: [0, 0, 0, 1] is too short
    arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
interrupt-map:1: [5, 0, 113, 4] is too short
    arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
interrupt-map:2: [2048, 0, 0, 1] is too short
    arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
interrupt-map:3: [5, 0, 113, 4] is too short
    arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
interrupt-map:4: [4096, 0, 0, 2] is too short
    arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
interrupt-map:5: [5, 0, 113, 4] is too short

Looks like interrupt-map is split incorrectly: shouldn't each entry have 8
cells?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 3/3] dt-bindings: PCI: Convert generic host binding to DT schema
  2019-12-31 14:31         ` Geert Uytterhoeven
@ 2019-12-31 17:10           ` Rob Herring
  2020-01-02  9:00             ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2019-12-31 17:10 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, linux-pci, Bjorn Helgaas,
	Lorenzo Pieralisi, Andrew Murray, Zhou Wang, Will Deacon,
	David Daney, Linux-Renesas

On Tue, Dec 31, 2019 at 7:31 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Tue, Dec 31, 2019 at 9:23 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Dec 31, 2019 at 12:30 AM Rob Herring <robh@kernel.org> wrote:
> > > On Thu, Dec 12, 2019 at 7:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > On Sat, Nov 16, 2019 at 1:53 AM Rob Herring <robh@kernel.org> wrote:
> > > > > Convert the generic PCI host binding to DT schema. The derivative Juno,
> > > > > PLDA XpressRICH3-AXI, and Designware ECAM bindings all just vary in
> > > > > their compatible strings. The simplest way to convert those to
> > > > > schema is just add them into the common generic PCI host schema.
> > > > >
> > > > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > > > Cc: Andrew Murray <andrew.murray@arm.com>
> > > > > Cc: Zhou Wang <wangzhou1@hisilicon.com>
> > > > > Cc: Will Deacon <will@kernel.org>
> > > > > Cc: David Daney <david.daney@cavium.com>
> > > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > >
> > > > > index 515b2f9542e5..000000000000
> > > > > --- a/Documentation/devicetree/bindings/pci/designware-pcie-ecam.txt
> > > > > +++ /dev/null
> > > >
> > > > > -Example:
> > > > > -
> > > > > -    pcie1: pcie@7f000000 {
> > > > > -        compatible = "socionext,synquacer-pcie-ecam", "snps,dw-pcie-ecam";
> > > > > -        device_type = "pci";
> > > > > -        reg = <0x0 0x7f000000 0x0 0xf00000>;
> > > > > -        bus-range = <0x0 0xe>;
> > > > > -        #address-cells = <3>;
> > > > > -        #size-cells = <2>;
> > > > > -        ranges = <0x1000000 0x00 0x00010000 0x00 0x7ff00000 0x0 0x00010000>,
> > > > > -                 <0x2000000 0x00 0x70000000 0x00 0x70000000 0x0 0x0f000000>,
> > > > > -                 <0x3000000 0x3f 0x00000000 0x3f 0x00000000 0x1 0x00000000>;
> > > > > -
> > > > > -        #interrupt-cells = <0x1>;
> > > > > -        interrupt-map-mask = <0x0 0x0 0x0 0x0>;
> > > >
> > > > An all-zeroes interrupt-map-mask seems to be very common on embedded
> > > > SoCs, where all devices are mapped to a single interrupt.
> > >
> > > Indeed.
> > >
> > > > However, schemas/pci/pci-bus.yaml says:
> > > >
> > > >   interrupt-map-mask:
> > > >     items:
> > > >       - description: PCI high address cell
> > > >         minimum: 0
> > > >         maximum: 0xf800
> > > >       - description: PCI mid address cell
> > > >         const: 0
> > > >       - description: PCI low address cell
> > > >         const: 0
> > > >       - description: PCI IRQ cell
> > > >         minimum: 1
> > > >         maximum: 7
> > > >
> > > > and thus complains about an all-zeroes mask, e.g.
> > > >
> > > >     arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dt.yaml:
> > > > pcie@fe000000: interrupt-map-mask:0:3: 0 is less than the minimum of 1
> > >
> > > Now fixed.
> >
> > Thank you, confirmed.
>
> And with latest renesas-drivers, I started seeing:
>
>     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> interrupt-map:0: [0, 0, 0, 1] is too short
>     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> interrupt-map:1: [5, 0, 113, 4] is too short
>     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> interrupt-map:2: [2048, 0, 0, 1] is too short
>     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> interrupt-map:3: [5, 0, 113, 4] is too short
>     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> interrupt-map:4: [4096, 0, 0, 2] is too short
>     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> interrupt-map:5: [5, 0, 113, 4] is too short
>
> Looks like interrupt-map is split incorrectly: shouldn't each entry have 8
> cells?

That must be with a current dtc which now splits the array before each
phandle. That works for phandle+args, but not *-map properties. :( I
was trying to avoid a bunch of dts updates to add brackets. I think
for now, I'll just drop the interrupt-map size constraint. It's not
all that accurate anyways as it doesn't look at cell sizes.

Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 3/3] dt-bindings: PCI: Convert generic host binding to DT schema
  2019-12-31 17:10           ` Rob Herring
@ 2020-01-02  9:00             ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-01-02  9:00 UTC (permalink / raw)
  To: Rob Herring
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, linux-pci, Bjorn Helgaas,
	Lorenzo Pieralisi, Andrew Murray, Zhou Wang, Will Deacon,
	David Daney, Linux-Renesas

Hi Rob,

On Tue, Dec 31, 2019 at 6:10 PM Rob Herring <robh@kernel.org> wrote:
> On Tue, Dec 31, 2019 at 7:31 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Dec 31, 2019 at 9:23 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Tue, Dec 31, 2019 at 12:30 AM Rob Herring <robh@kernel.org> wrote:
> > > > On Thu, Dec 12, 2019 at 7:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > > On Sat, Nov 16, 2019 at 1:53 AM Rob Herring <robh@kernel.org> wrote:
> > > > > > Convert the generic PCI host binding to DT schema. The derivative Juno,
> > > > > > PLDA XpressRICH3-AXI, and Designware ECAM bindings all just vary in
> > > > > > their compatible strings. The simplest way to convert those to
> > > > > > schema is just add them into the common generic PCI host schema.
> > > > > >
> > > > > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > > > > Cc: Andrew Murray <andrew.murray@arm.com>
> > > > > > Cc: Zhou Wang <wangzhou1@hisilicon.com>
> > > > > > Cc: Will Deacon <will@kernel.org>
> > > > > > Cc: David Daney <david.daney@cavium.com>
> > > > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > > >
> > > > > > index 515b2f9542e5..000000000000
> > > > > > --- a/Documentation/devicetree/bindings/pci/designware-pcie-ecam.txt
> > > > > > +++ /dev/null
> > > > >
> > > > > > -Example:
> > > > > > -
> > > > > > -    pcie1: pcie@7f000000 {
> > > > > > -        compatible = "socionext,synquacer-pcie-ecam", "snps,dw-pcie-ecam";
> > > > > > -        device_type = "pci";
> > > > > > -        reg = <0x0 0x7f000000 0x0 0xf00000>;
> > > > > > -        bus-range = <0x0 0xe>;
> > > > > > -        #address-cells = <3>;
> > > > > > -        #size-cells = <2>;
> > > > > > -        ranges = <0x1000000 0x00 0x00010000 0x00 0x7ff00000 0x0 0x00010000>,
> > > > > > -                 <0x2000000 0x00 0x70000000 0x00 0x70000000 0x0 0x0f000000>,
> > > > > > -                 <0x3000000 0x3f 0x00000000 0x3f 0x00000000 0x1 0x00000000>;
> > > > > > -
> > > > > > -        #interrupt-cells = <0x1>;
> > > > > > -        interrupt-map-mask = <0x0 0x0 0x0 0x0>;
> > > > >
> > > > > An all-zeroes interrupt-map-mask seems to be very common on embedded
> > > > > SoCs, where all devices are mapped to a single interrupt.
> > > >
> > > > Indeed.
> > > >
> > > > > However, schemas/pci/pci-bus.yaml says:
> > > > >
> > > > >   interrupt-map-mask:
> > > > >     items:
> > > > >       - description: PCI high address cell
> > > > >         minimum: 0
> > > > >         maximum: 0xf800
> > > > >       - description: PCI mid address cell
> > > > >         const: 0
> > > > >       - description: PCI low address cell
> > > > >         const: 0
> > > > >       - description: PCI IRQ cell
> > > > >         minimum: 1
> > > > >         maximum: 7
> > > > >
> > > > > and thus complains about an all-zeroes mask, e.g.
> > > > >
> > > > >     arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dt.yaml:
> > > > > pcie@fe000000: interrupt-map-mask:0:3: 0 is less than the minimum of 1
> > > >
> > > > Now fixed.
> > >
> > > Thank you, confirmed.
> >
> > And with latest renesas-drivers, I started seeing:
> >
> >     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> > interrupt-map:0: [0, 0, 0, 1] is too short
> >     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> > interrupt-map:1: [5, 0, 113, 4] is too short
> >     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> > interrupt-map:2: [2048, 0, 0, 1] is too short
> >     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> > interrupt-map:3: [5, 0, 113, 4] is too short
> >     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> > interrupt-map:4: [4096, 0, 0, 2] is too short
> >     arch/arm/boot/dts/r8a7791-koelsch.dt.yaml: pci@ee0d0000:
> > interrupt-map:5: [5, 0, 113, 4] is too short
> >
> > Looks like interrupt-map is split incorrectly: shouldn't each entry have 8
> > cells?
>
> That must be with a current dtc which now splits the array before each
> phandle. That works for phandle+args, but not *-map properties. :( I

Ah, that explains it: renesas-drivers does include your for-next branch.
At first I was a bit puzzled, as the messages weren't introduced by a
dt-schema repo update...

> was trying to avoid a bunch of dts updates to add brackets. I think
> for now, I'll just drop the interrupt-map size constraint. It's not
> all that accurate anyways as it doesn't look at cell sizes.

Too late, I've already applied grouping to the Renesas ARM DTS files ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191116005240.15722-1-robh@kernel.org>
     [not found] ` <20191116005240.15722-3-robh@kernel.org>
2019-12-12 14:41   ` [PATCH 3/3] dt-bindings: PCI: Convert generic host binding to DT schema Geert Uytterhoeven
2019-12-30 23:29     ` Rob Herring
2019-12-31  8:23       ` Geert Uytterhoeven
2019-12-31 14:31         ` Geert Uytterhoeven
2019-12-31 17:10           ` Rob Herring
2020-01-02  9:00             ` Geert Uytterhoeven

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git