From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEB6C31E40 for ; Tue, 6 Aug 2019 08:49:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17E0D2086D for ; Tue, 6 Aug 2019 08:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732213AbfHFItq (ORCPT ); Tue, 6 Aug 2019 04:49:46 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:34026 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732206AbfHFItq (ORCPT ); Tue, 6 Aug 2019 04:49:46 -0400 Received: by mail-oi1-f194.google.com with SMTP id l12so4809950oil.1; Tue, 06 Aug 2019 01:49:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JGsM7pwNfNhypZYgQFIcaWofv38d0hmWofEdR0NtNiQ=; b=VRdKBUsli2gnniTOaZA9MP0FqBhcw26ezjeOlaKnbaKbhE/y++NlMOVrJzgRwNdZ46 vocUO0h7oSdxt70uruqlX+q/TDxplsHaD+z2qvWzDqVOoZE3k1nbsDGDtpzSSWrG2YBQ PS/AnrL1IpvxOMTy//nQwCcHlB3Bo+RI+RgqEZXT/wI1ZrBgAyIse3B/G5ByRAMMFQJE 2WIO2UQgPaj/xvvH/q9ebG9+k7qqcS5QXm9vVhQ6zkteA5p336kv7keNGLEy7I64Xdps v59FR3kEgn02KHIkB7kbT5P95Brtj+/c1wEimE915WNaBq3eIKKvtWgsAsbGAknJabGC CxkA== X-Gm-Message-State: APjAAAXiL1HnULo9hTWJLJUPz3LDVe8+iKnkmubw+qQvg2Q1j4qOB48M ciQgbyHMIZ4rmsAqUeaRhbIZpJ413vLBLWbjq9M= X-Google-Smtp-Source: APXvYqwuOQUfUJbqvnFx04K816C3jKe2zq5l/JtyJF2mmCR5Qu0WkmmFcibhWo6DNxgmpO/XSWdCMjmFXggotgQEEmM= X-Received: by 2002:aca:338a:: with SMTP id z132mr1059577oiz.54.1565081385290; Tue, 06 Aug 2019 01:49:45 -0700 (PDT) MIME-Version: 1.0 References: <1562576868-8124-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1562576868-8124-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 6 Aug 2019 10:49:33 +0200 Message-ID: Subject: Re: [PATCH RFC 2/7] pinctrl: sh-pfc: remove incomplete flag "cfg->type" To: Yoshihiro Shimoda Cc: Linus Walleij , Geert Uytterhoeven , "thierry.reding@gmail.com" , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , "linux-pwm@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Shimoda-san, On Mon, Jul 29, 2019 at 7:16 AM Yoshihiro Shimoda wrote: > > From: Linus Walleij, Sent: Monday, July 29, 2019 8:02 AM > > > > On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda > > wrote: > > > > > The old commit c58d9c1b26e3 ("sh-pfc: Implement generic pinconf > > > support") broke the cfg->type flag to PINMUX_TYPE_FUNCTION because > > > sh_pfc_pinconf_set() didn't call sh_pfc_reconfig_pin(). > > > Now if we fix the cfg->type condition, it gets worse because: > > > - Some drivers might be deferred so that .set_mux() will be called > > > multiple times. > > > - In such the case, the sh-pfc driver returns -EBUSY even if > > > the group is the same, and then that driver fails to probe. > > > > > > Since the pinctrl subsystem already has such conditions according > > > to @set_mux and @gpio_request_enable, this patch just remove > > > the incomplete flag from sh-pfc/pinctrl.c. > > > > > > Signed-off-by: Yoshihiro Shimoda > > > > This looks like it should have a Fixes: tag as well. > > I got it. The Fixes tag should be: > > Fixes: c58d9c1b26e3 ("sh-pfc: Implement generic pinconf support") Reviewed-by: Geert Uytterhoeven > > Geert will decide what to do with this. > > I got it. > > > Can all the pinctrl patches be applied independently of the other > > changes so Geert can apply and send me those patches in his pull > > requests? > > The pinctrl patches (1/7 through 3/7) can be applied on next-20190726 > so I think Geert can apply these patches into his repo. Looks mostly OK to me (I have some comments on 3/7). I'll apply it to my local tree, so it will receive some testing on all boards I have. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds