Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] rcar-vin: Remove redundant compatible values
@ 2020-08-02 17:30 Niklas Söderlund
  2020-08-03 12:26 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Niklas Söderlund @ 2020-08-02 17:30 UTC (permalink / raw)
  To: linux-media; +Cc: linux-renesas-soc, Niklas Söderlund

The compatible value 'renesas,rcar-gen2-vin' have always been mandatory
for all Gen2 platforms. Remove device redundant values.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/media/platform/rcar-vin/rcar-core.c | 16 ----------------
 1 file changed, 16 deletions(-)
---
Hi,

After the recent bindings conversion to YAML which makes it abundantly 
clear that the generic 'renesas,rcar-gen2-vin' compatibility value are 
mandatory (which is always have been) remove values that are not needed 
to reduce size.

diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
index 7440c8965d27e64f..aad8eef2ac9f641b 100644
--- a/drivers/media/platform/rcar-vin/rcar-core.c
+++ b/drivers/media/platform/rcar-vin/rcar-core.c
@@ -1228,22 +1228,6 @@ static const struct of_device_id rvin_of_id_table[] = {
 		.compatible = "renesas,vin-r8a7779",
 		.data = &rcar_info_h1,
 	},
-	{
-		.compatible = "renesas,vin-r8a7790",
-		.data = &rcar_info_gen2,
-	},
-	{
-		.compatible = "renesas,vin-r8a7791",
-		.data = &rcar_info_gen2,
-	},
-	{
-		.compatible = "renesas,vin-r8a7793",
-		.data = &rcar_info_gen2,
-	},
-	{
-		.compatible = "renesas,vin-r8a7794",
-		.data = &rcar_info_gen2,
-	},
 	{
 		.compatible = "renesas,rcar-gen2-vin",
 		.data = &rcar_info_gen2,
-- 
2.28.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] rcar-vin: Remove redundant compatible values
  2020-08-02 17:30 [PATCH] rcar-vin: Remove redundant compatible values Niklas Söderlund
@ 2020-08-03 12:26 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-08-03 12:26 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: Linux Media Mailing List, Linux-Renesas

Hi Niklas,

On Sun, Aug 2, 2020 at 8:05 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The compatible value 'renesas,rcar-gen2-vin' have always been mandatory
> for all Gen2 platforms. Remove device redundant values.

That's not true: the DTS files for R-Car H2, M2-W, and E2 lacked the
family-specific compatible values during the first few years of their
existence.  However, given we dropped support for the old CPG and MSTP
DT bindings, it's reasonable to assume all working systems have them.

> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

With a slight update of the description:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 17:30 [PATCH] rcar-vin: Remove redundant compatible values Niklas Söderlund
2020-08-03 12:26 ` Geert Uytterhoeven

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git