linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Julien Massot <julien.massot@iot.bzh>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] soc: renesas: rcar-rst: Add support to set rproc boot address
Date: Wed, 22 Sep 2021 14:40:13 +0200	[thread overview]
Message-ID: <CAMuHMdV0S50KpUhXFr53Q1Z=LtL9RFGYSKJp2sareW0WTU+gtA@mail.gmail.com> (raw)
In-Reply-To: <9922048a-2278-e3bf-ea23-b07f95ab607b@iot.bzh>

Hi Julien,

On Wed, Sep 22, 2021 at 11:54 AM Julien Massot <julien.massot@iot.bzh> wrote:
> > In general, I think this looks like a good abstraction, which we can
> > also use for further abstraction of R-Car Gen2 (cfr. [1]).
> Yes I was also thinking about future generation like Gen4, but I don't have the documentation
> at this point.
>  From what I understand in [1]: CA7BAR in Gen2 is managed by the SYSC module and not by the RST module
> as for CR7BAR in Gen3. So despite the fact that the procedure is similar, we won't be able to set CA7BAR in
> rcar-rst.c.

On R-Car Gen2, CA7BAR is managed by the RST module.
On R-Mobile APE6, it is managed by the SYSC module.

> > I'm just wondering if we should pass the BAR offset to
> > rcar_rst_set_rproc_boot_addr() explicitly (and rename the function),
> > or have multiple functions for the different BARs.
> Passing BAR offset will imply to spread RST module offsets across different subsystems,
> and the second question will be to be able to do the correct boundary check for the targeted
> processor: CR7BAR is aligned on 4k an it looks like CA7BAR is on 256k. It looks like it's
> manageable thanks to the driver data which already holds the 'mode monitor register' offset per SoC generation.
>
> One missing point will be for future R-Car SoCs: trends on others SoC seems to be to go to have
> several 'realtime', or remote processor. In this case this function will not scale up.

On R-Car V3U, CR52BAR is managed by the APMU module.

There's not much we can do about future processors yet ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2021-09-22 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  9:46 [RFC PATCH 0/1] Add support for setting Cortex R7 boot address Julien Massot
2021-09-14  9:46 ` [RFC PATCH 1/1] soc: renesas: rcar-rst: Add support to set rproc " Julien Massot
2021-09-21 16:30   ` Geert Uytterhoeven
2021-09-22  9:54     ` Julien Massot
2021-09-22 12:40       ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdV0S50KpUhXFr53Q1Z=LtL9RFGYSKJp2sareW0WTU+gtA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=julien.massot@iot.bzh \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).