From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Chris Paterson <chris.paterson2@renesas.com>,
"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 2/2] ARM: dts: iwg22d-sodimm: disable lcd for extension board
Date: Mon, 2 Mar 2020 14:49:47 +0100 [thread overview]
Message-ID: <CAMuHMdV0aOF30FpEzekq65CA6=_UTQA56WOCCv=WymuHapVjaw@mail.gmail.com> (raw)
In-Reply-To: <1580323253-3281-3-git-send-email-marian-cristian.rotariu.rb@bp.renesas.com>
Hi Marian-Cristian,
On Wed, Jan 29, 2020 at 7:58 PM Marian-Cristian Rotariu
<marian-cristian.rotariu.rb@bp.renesas.com> wrote:
> The two variants of the iW-G22D should be mutually exclusive, therefore
> this patch disables the RGB LCD display when the HDMI extension board is
> used.
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Shouldn't this be merged with the previous patch, to avoid bisection
failures?
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
> @@ -108,6 +108,19 @@
> };
> };
>
> +&lcd_panel {
> + status = "disabled";
> +
> + /* null reference to get rid of the dtc warning */
> + ports {
> + port@0 {
> + endpoint {
> + remote-endpoint = <0>;
> + };
> + };
> + };
> +};
> +
> &pfc {
> can1_pins: can1 {
> groups = "can1_data_b";
> diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> index 878113a..444adc6 100644
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -98,7 +98,7 @@
> pinctrl-names = "default";
> };
>
> - lcd {
> + lcd_panel: lcd {
> compatible = "edt,etm043080dh6gp", "simple-panel";
> power-supply = <&vccq_panel>;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-03-02 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 18:40 [PATCH 0/2] iwg22d-sodimm: enable RGB LCD panel Marian-Cristian Rotariu
2020-01-29 18:40 ` [PATCH 1/2] ARM: dts: iwg22d-sodimm: enable " Marian-Cristian Rotariu
2020-03-02 13:39 ` Geert Uytterhoeven
2020-03-03 10:08 ` Marian-Cristian Rotariu
2020-01-29 18:40 ` [PATCH 2/2] ARM: dts: iwg22d-sodimm: disable lcd for extension board Marian-Cristian Rotariu
2020-03-02 13:49 ` Geert Uytterhoeven [this message]
2020-03-03 10:09 ` Marian-Cristian Rotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdV0aOF30FpEzekq65CA6=_UTQA56WOCCv=WymuHapVjaw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=chris.paterson2@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marian-cristian.rotariu.rb@bp.renesas.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).