linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Chris Brandt <chris.brandt@renesas.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 2/8] sound: soc: sh: Add RZ/G2L SSIF-2 driver
Date: Tue, 20 Jul 2021 11:57:39 +0200	[thread overview]
Message-ID: <CAMuHMdV1f3TM3pKsftNkaOrFifAMdLkEcKdWs=wL54uFhEKoZg@mail.gmail.com> (raw)
In-Reply-To: <20210719134040.7964-3-biju.das.jz@bp.renesas.com>

Hi Biju,

On Mon, Jul 19, 2021 at 3:40 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add serial sound interface(SSIF-2) driver support for
> RZ/G2L SoC.
>
> Based on the work done by Chris Brandt for RZ/A SSI driver.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/sound/soc/sh/Kconfig
> +++ b/sound/soc/sh/Kconfig
> @@ -45,6 +45,16 @@ config SND_SOC_RCAR
>         help
>           This option enables R-Car SRU/SCU/SSIU/SSI sound support
>
> +config SND_SOC_RZ
> +       tristate "RZ/G2L series SSIF-2 support"
> +       depends on OF || COMPILE_TEST

ARCH_R9A07G044 implies OF

> +       depends on ARCH_R9A07G044

Is there any hard compile-time dependency on ARCH_R9A07G044?

Perhaps you meant

    depends on ARCH_R9A07G044 || COMPILE_TEST

?

> +       select SND_SIMPLE_CARD
> +       help
> +         This option enables ASoC sound support for the RZ/G2L MPUs.
> +         The simple-audio-card driver and the RZ/G2L built-in serial
> +         sound interface (SSIF-2) driver are used.
> +

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-07-20  9:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 13:40 [PATCH v2 0/8] Add RZ/G2L Sound support Biju Das
2021-07-19 13:40 ` [PATCH v2 1/8] ASoC: dt-bindings: Document RZ/G2L bindings Biju Das
2021-07-19 22:16   ` Rob Herring
2021-07-20 11:24     ` Biju Das
2021-07-29 19:11   ` Rob Herring
2021-07-19 13:40 ` [PATCH v2 2/8] sound: soc: sh: Add RZ/G2L SSIF-2 driver Biju Das
2021-07-20  9:57   ` Geert Uytterhoeven [this message]
2021-07-20 10:24     ` Biju Das
2021-07-19 13:40 ` [PATCH v2 3/8] arm64: dts: renesas: r9a07g044: Add external audio clock nodes Biju Das
2021-07-19 13:40 ` [PATCH v2 4/8] arm64: dts: renesas: r9a07g044: Add SSI support Biju Das
2021-07-19 13:40 ` [PATCH v2 5/8] arm64: defconfig: Enable ASoC sound support for RZ/G2L SoC Biju Das
2021-07-19 13:40 ` [PATCH v2 6/8] ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support Biju Das
2021-07-29 19:13   ` Rob Herring
2021-07-19 13:40 ` [PATCH v2 7/8] sound: sh: rz-ssi: Add SSI DMAC support Biju Das
2021-07-19 13:40 ` [PATCH v2 8/8] arm64: dts: renesas: r9a07g044: Add SSI DMA support Biju Das
2021-07-30 19:03 ` (subset) [PATCH v2 0/8] Add RZ/G2L Sound support Mark Brown
2021-07-30 19:13   ` Prabhakar Mahadev Lad
2021-07-31  6:42     ` Biju Das
2021-08-02 12:16     ` Mark Brown
2021-08-02 12:32       ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdV1f3TM3pKsftNkaOrFifAMdLkEcKdWs=wL54uFhEKoZg@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=chris.brandt@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=perex@perex.cz \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=rdunlap@infradead.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).