From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08048C004C9 for ; Tue, 7 May 2019 08:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA2E420B7C for ; Tue, 7 May 2019 08:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726224AbfEGICI (ORCPT ); Tue, 7 May 2019 04:02:08 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:45082 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbfEGICI (ORCPT ); Tue, 7 May 2019 04:02:08 -0400 Received: by mail-vs1-f67.google.com with SMTP id o10so9787885vsp.12; Tue, 07 May 2019 01:02:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=43ZU946SQ92CMpYex7l7cURwZU0nmkJIjZBNyh5A/iw=; b=poUcP7Cs/qYiyG+4VynBvqvOmEoulaXsmyO6YKiBK82cj0aq3EyV/cZk5v/LDPfaJl lRJoxbzvHOEiZZyRIbM1WsyKvxuVAdvxFSByfIHyVUWHjgHwqhqGg+LLbF4QndR1qwqH u9OQVVuTPEH/FJI8nmJR/TuGRQTymAi27T25wghuMupC6FTVH2DrL947W5qvBqe7vWFd 5vIN3xj/T7s+Uk/auUB3da2eu0tp1w1uJIpjwX8HuwPqm5yNKDYdL9iGy/1n6VZ6J9Pz kyRcEhlTbTCZ6cwq+FGw6Rr9C/GfzV1f89g/zJDftAmlHy/Ng3j5r9nLpMGW+s9yVELs L1Cw== X-Gm-Message-State: APjAAAVv36286GwomNaVvCL0Yjv7THl7RfV5LQgZv4vXP3eKuDrgYj4n nMAZa53preTbcWLP1ioBgbSU0IBieVNF3wI7l38= X-Google-Smtp-Source: APXvYqxyWwXpdASz9ehwyctNLAOr+5D/eECRWmWTQy1RWxuuNHMHLAK/raEq/fOx3i/5SMseULHQa4EzlJV+FzNHVP8= X-Received: by 2002:a67:e2ca:: with SMTP id i10mr8188079vsm.96.1557216127141; Tue, 07 May 2019 01:02:07 -0700 (PDT) MIME-Version: 1.0 References: <20190506234631.113226-1-chris.brandt@renesas.com> <20190506234631.113226-2-chris.brandt@renesas.com> In-Reply-To: <20190506234631.113226-2-chris.brandt@renesas.com> From: Geert Uytterhoeven Date: Tue, 7 May 2019 10:01:55 +0200 Message-ID: Subject: Re: [PATCH 01/10] phy: renesas: rcar-gen3-usb2: Add uses_usb_x1 option To: Chris Brandt Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Chris, On Tue, May 7, 2019 at 1:47 AM Chris Brandt wrote: > The RZ/A2 has optional dedicated 48MHz crystal inputs, which adds a new > register setting when used. > > Signed-off-by: Chris Brandt Thanks for your patch! > --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c > @@ -630,6 +635,9 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev) > } > } > > + if (of_property_read_bool(dev->of_node, "renesas,uses_usb_x1")) > + channel->uses_usb_x1 = true; > + Perhaps this can be checked some other way (e.g. by checking for a non-zero clock rate of the USB_X1 clock referenced from DT), thus removing the need for adding a custom property? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds