From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95577C43387 for ; Mon, 17 Dec 2018 14:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D2BC20874 for ; Mon, 17 Dec 2018 14:15:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726812AbeLQOPv (ORCPT ); Mon, 17 Dec 2018 09:15:51 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:33457 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbeLQOPu (ORCPT ); Mon, 17 Dec 2018 09:15:50 -0500 Received: by mail-ua1-f68.google.com with SMTP id t8so4475754uap.0; Mon, 17 Dec 2018 06:15:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AzjjRDrdjwtVDbRHohhJDZS0pFD7hB2eDWAFH/6Qnhs=; b=tirjMzjcDSE/yNaVA4TSbeHC8j8h21mMfpFztmcQLZpgZm/Wc5cji85v6lqm9Vu7CY Z2XCjAdgvrQP9CZbaSjwWGkRAFgRdgzyBEn/hiEWFszRsVnKgOMkAlIC+iytm1i3l7JY a8lyc/kuuN7WHBUD2aPbtMK5bNJODAzyJ4ABvTUvuC6mPweUowR+6nwjxh7BGaJPbUaR YY1e77UFelzBx9zX65glwjSh9O17IAoKPZDBMBjUQct3J6cXVqhVMb3vA9WH+QAkPJWA 2HAhszrgQuIfQ8Jc5sD6/6Y660SasdrDZufDC+95noS9ujtVP+RFrqLHYxj7f50jWzgj ZbwQ== X-Gm-Message-State: AA+aEWYDmcj6+g7+4B2IOpIHb4zPvJEX9KnCNkCs2VXVJIOGi5J/6GyQ NrxeVZw3fAcWYFrAV7Ix0s31zdPgxICgmWqiwRc= X-Google-Smtp-Source: AFSGD/VxnEHRchPO2PrpkL2IUSuZXUfTrsnvaAFOvyid2desYhyfldoo+jfCk4RNzqwtSPEblR9C4HRuEKxD67p99Tc= X-Received: by 2002:ab0:1393:: with SMTP id m19mr6037953uae.75.1545056148846; Mon, 17 Dec 2018 06:15:48 -0800 (PST) MIME-Version: 1.0 References: <20181212014927.25840-1-marek.vasut+renesas@gmail.com> <270eeb39-140f-7f55-75d3-c2a6d9ab4034@gmail.com> <076ebc8e-32a3-99bf-6d8a-7a0bae22b427@gmail.com> <09902cc4-ef25-cd36-0d4a-effeabcd233f@gmail.com> <31978c47-cd1b-7c61-0d6a-09e443147b52@gmail.com> <04bcb195-0668-4d8d-1f86-c53c3a142183@gmail.com> <74305798-9405-4f82-36a6-1f5cc515eaf6@gmail.com> <726916ff-c2d8-374c-a69d-8b19f9a251b5@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 17 Dec 2018 15:15:36 +0100 Message-ID: Subject: Re: [PATCH 1/6] thermal: split thermal_zone_of_sensor_register{,_param}() To: Marek Vasut Cc: Eduardo Valentin , Linux PM list , Linux-Renesas , Marek Vasut , Daniel Lezcano , Wolfram Sang , Zhang Rui , Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Marek, On Mon, Dec 17, 2018 at 2:41 PM Marek Vasut wrote: > On 12/17/2018 02:36 PM, Geert Uytterhoeven wrote: > > On Mon, Dec 17, 2018 at 2:28 PM Marek Vasut wrote: > >> On 12/17/2018 02:26 PM, Geert Uytterhoeven wrote: > >>> On Sun, Dec 16, 2018 at 9:50 PM Marek Vasut wrote: > >>>> On 12/16/2018 09:08 PM, Geert Uytterhoeven wrote: > >>>> [...] > >>>> > >>>>>>>>> Git actually does that automatically, assumed your user.email config matches > >>>>>>>>> the From: address that is used in your outgoing email delivery path (i.e. the > >>>>>>>>> scrubbed one, when using Gmail's SMTP server). > >>>>>>>>> If you lie to git in your user.email config, git cannot do the right > >>>>>>>>> thing, obviously. > >>>>>>>> > >>>>>>>> My git user.email obviously matches the From: field , before the > >>>>>>>> scrubbing, which I believe is the correct thing to do. > >>>>>>> > >>>>>>> I disagree, because that is not how the emails are actually going out from the > >>>>>>> SMTP server you are using. > >>>>>> > >>>>>> Can you summarize, clearly, what you believe is the right thing to > >>>>>> configure and where ? > >>>>> > >>>>> According to git-send-email(1), you can either pass your scrubbed email > >>>>> address to --from, or configure it in the sendemail.from config option. > >>>>> Does that work for you? > >>>> > >>>> So sendemail.from != user.email , the later has the +tag while the > >>>> former does not ? > >>> > >>> Right. > >>> > >>>>>>>>>> from the same person/email address as the email address in From, so they > >>>>>>>>>> are equal. > >>>>>>>>> > >>>>>>>>> If they differ, they are not equal ;-) > >>>>>>>> > >>>>>>>> Depends on how you define 'equal' . Here I think foo+bar@example.com > >>>>>>>> should be considered equal to foo@example.com . > >>>>>>> > >>>>>>> That is domain-specific knowledge, which you cannot rely upon. > >>>>> > >>>>>>>> Aha, so maybe that enhancement needs further enhancement to scrub the > >>>>>>>> +tags before the check ? > >>>>>>> > >>>>>>> Again, that is domain-specific knowledge, which you cannot rely upon. > >>>>>> > >>>>>> How so, please elaborate . > >>>>> > >>>>> In general, you cannot assume the "+foo" part can be ignored. Only the sender > >>>>> knows. > >>>> > >>>> How so ? > >>> > >>> It depends on the domain. > >>> > >>> Is Bill.Gates@microsoft.com the same email address as > >>> Bill.Gates+foo@microsoft.com? > >>> Is Bill.Gates+1955@microsoft.com the same? > >>> Is Bill.Gates-1955@microsoft.com the same? > >>> > >>> I don't know. Only microsoft.com knows. > >>> So that's why you should compare email addresses verbatim (but case > >>> insensitive). > >> > >> Oh, you mean email-domain. In that case, since gmail treats > >> foo@gmail.com the same as foo+bar@gmail.com , checkpatch should treat > >> them equally as well. In which case, your checkpatch patch which now > >> generates a warning on this is wrong ? > > > > So checkpatch should know about all email domains? > > If correct handling is domain specific knowledge, as you just said, > apparently so. Are you serious? > Otherwise checkpatch produces false positives. Even with gmail, some companies may use a single gmail account for public development, and use the +foo to distinguish between individual developers. So you cannot ignore it. > > Just fix your setup. All patch statistics operate on the author, incl. +foo, so > > your patches will be attributed wrongly. > > Well your suggestion with sendemail.from doesn't seem to change > anything, but I'll keep it in. Sorry to hear that. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds