From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 863BCC4BA21 for ; Wed, 26 Feb 2020 20:48:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C73724653 for ; Wed, 26 Feb 2020 20:48:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbgBZUsr (ORCPT ); Wed, 26 Feb 2020 15:48:47 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:41154 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727379AbgBZUsq (ORCPT ); Wed, 26 Feb 2020 15:48:46 -0500 Received: by mail-ot1-f65.google.com with SMTP id v19so761122ote.8; Wed, 26 Feb 2020 12:48:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vg9cOMro+i98waebif4aU1cclILRMqAhraoxkLqHft0=; b=mu4po8KOeN8+sK3sDalexKmtwZVBXFyHrIlZRx5cQ1QeemIyxggGCTKLNc3NRXqSCQ 6jAKeAUxqiJXmEeZwu8LEGwTtcl8dlUSCM8Juj9jI2N8NMDbAyLKxyhHK0/J4KLLPw5e 8XsjNhQMcgeKJRHw2NQ5A6xLuNGz9Fo2z4Ori5Tch8SO2TcqM/INU6FKQapuZgRnC2KP cd80XDwvDko2inbWRxVXFArHCZGiKVpjsnPxmo2LjyBL2B8FuDPkEtqTLuTf6HZHJ+RI f1zGCW8T5VXEqsWOeCXCtEMgOYs5xwLui3Kb0VAtbriQc81rxEPkWNGJL/TMoBwxds6+ 3Efw== X-Gm-Message-State: APjAAAWUMH/SjQ3FuJ9Tu5lJNgLjM+GTea/cjLcsLgP0qTpNVsRY3Hrp DRJdH9RSb7k9lXbFP6OrrU5leUZHr3xATgb9KJk= X-Google-Smtp-Source: APXvYqwzOCFDwkSx8fqJ8n9QNgT5p20qDoRYME/GR3OFM779WW+FCNzSMRtSIS4BmNIfF2IP3lG/MO8bygAra/IeEMo= X-Received: by 2002:a9d:dc1:: with SMTP id 59mr531250ots.250.1582750125806; Wed, 26 Feb 2020 12:48:45 -0800 (PST) MIME-Version: 1.0 References: <20200225144749.19815-1-geert+renesas@glider.be> <20200226174905.GE25745@shell.armlinux.org.uk> <20200226175723.GF25745@shell.armlinux.org.uk> In-Reply-To: <20200226175723.GF25745@shell.armlinux.org.uk> From: Geert Uytterhoeven Date: Wed, 26 Feb 2020 21:48:34 +0100 Message-ID: Subject: Re: [PATCH] ARM: boot: Fix ATAGs with appended DTB To: Russell King - ARM Linux admin Cc: Marek Szyprowski , Geert Uytterhoeven , Nicolas Pitre , Arnd Bergmann , Eric Miao , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Chris Brandt , Linux ARM , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Russell, On Wed, Feb 26, 2020 at 6:57 PM Russell King - ARM Linux admin wrote: > On Wed, Feb 26, 2020 at 06:56:06PM +0100, Geert Uytterhoeven wrote: > > On Wed, Feb 26, 2020 at 6:49 PM Russell King - ARM Linux admin > > wrote: > > > On Wed, Feb 26, 2020 at 07:35:14AM +0100, Marek Szyprowski wrote: > > > > On 25.02.2020 15:47, Geert Uytterhoeven wrote: > > > > > At early boot, register r8 may contain an ATAGs or DTB pointer. > > > > > When an appended DTB is found, its address is stored in r8, for > > > > > extraction of the RAM base address later. > > > > > > > > > > However, if r8 contained an ATAGs pointer before, that pointer will be > > > > > lost, and the provided ATAGs is no longer folded into the provided DTB. > > > > > > > > > > Fix this by leaving r8 untouched. > > > > > > > > > > Fixes: 137e522593918be2 ("ARM: 8960/1: boot: Obtain start of physical memory from DTB") > > > > > Reported-by: Marek Szyprowski > > > > > Signed-off-by: Geert Uytterhoeven > > > > > > The original commit hasn't been submitted, so it can be fixed before it > > > hits mainline if you want. Let me know what you want to do. Thanks. > > > > Fixing the original is fine for me, of course. > > Thanks! > > Please submit a replacement for 8960/1, thanks. Done. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds