Linux-Renesas-SoC Archive on
 help / color / Atom feed
From: Geert Uytterhoeven <>
To: Nishka Dasgupta <>
Cc: Geert Uytterhoeven <>,
	Linus Walleij <>,
	Linux-Renesas <>,
	"open list:GPIO SUBSYSTEM" <>
Subject: Re: [PATCH] pinctrl: rza1: Add of_node_put() before return
Date: Fri, 16 Aug 2019 09:21:04 +0200
Message-ID: <> (raw)
In-Reply-To: <>

CC Jacopo, Chris

On Thu, Aug 15, 2019 at 8:05 AM Nishka Dasgupta
<> wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return in
> three places.
> Issue found with Coccinelle.
> Signed-off-by: Nishka Dasgupta <>

Reviewed-by: Geert Uytterhoeven <>
i.e. will queue in sh-pfc-for-v5.4.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15  6:05 Nishka Dasgupta
2019-08-16  7:21 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on

Archives are clonable:
	git clone --mirror linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ \
	public-inbox-index linux-renesas-soc

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox