From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF597C04AB2 for ; Fri, 10 May 2019 06:55:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9BE42175B for ; Fri, 10 May 2019 06:55:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726934AbfEJGz0 (ORCPT ); Fri, 10 May 2019 02:55:26 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:36729 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726816AbfEJGz0 (ORCPT ); Fri, 10 May 2019 02:55:26 -0400 Received: by mail-vk1-f194.google.com with SMTP id d74so1239678vka.3; Thu, 09 May 2019 23:55:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5S9csFKbMV0lCD/883Gzapxj9FADXFJIar7vKVVR0O8=; b=km90iV7NH33a49i9BEDtdSMEYPCj1B/rHjgQatWAisPYu8WyIReTz5uWxjsRvSMtIn gnoANa+lF+A3qAGrJZb/GnBCEJjpnxeOyJjS+4VjUi6l9Chd9ptW4ywU/6jtQuOQ9oUo cMvj6j5D/YB6bwcrYIroMsEsxeUPyURk0NvUWr8fZL9XeQBmQv4wf92fBw0htiB7YvrA Gc+VUSKPlpb8oQjYXbd82hSsYV0G0xDMcF4d2hht9TGgYZg2S0pFhWSzneWZkFsSSSar f/c3uTurfwH/ZNRK7rTNap5HVkm1n07TgmGofem4ozeFAJSlZBKOpFa3yW9B1yukbRYD Ueig== X-Gm-Message-State: APjAAAXivKo3jEztFcRhexpkB7COimfPvBm19If3w3fz/R1U6sDr8nNY hmF4KIJ+xx8PmlRjzmxjG6F4tOibAdWHpJZ9SYo= X-Google-Smtp-Source: APXvYqwVOLLjDh9wLuImY1mtAOjaXNdijdjj3OwaDer8wRVyGXiE789bd0xEagP5xJcvcqLHK1+7fEF0aq2bXiX/Nu4= X-Received: by 2002:a1f:62c7:: with SMTP id w190mr4140087vkb.72.1557471324885; Thu, 09 May 2019 23:55:24 -0700 (PDT) MIME-Version: 1.0 References: <20190509201142.10543-1-chris.brandt@renesas.com> <20190509201142.10543-5-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 10 May 2019 08:55:13 +0200 Message-ID: Subject: Re: [PATCH v2 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1 To: Yoshihiro Shimoda , Chris Brandt Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Sergei Shtylyov , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Shimoda-san, Chris, On Fri, May 10, 2019 at 6:38 AM Yoshihiro Shimoda wrote: > > From: Chris Brandt, Sent: Friday, May 10, 2019 5:12 AM > > > > Document the optional renesas,uses_usb_x1 property. > > > > Signed-off-by: Chris Brandt > > --- > > v2: > > * removed 'use_usb_x1' option > > * document that 'usb_x1' clock node will be detected to determine if > > 48MHz clock exists > > --- > > Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > index d46188f450bf..79d8360d92e5 100644 > > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > @@ -28,7 +28,9 @@ Required properties: > > followed by the generic version. > > > > - reg: offset and length of the partial USB 2.0 Host register block. > > -- clocks: clock phandle and specifier pair(s). > > +- clocks: clock phandle and specifier pair(s). For SoCs that have a separate > > + dedicated 48MHz USB_X1 input, if a 'usb_x1' clock node exists and is > > + set to non-zero, the PHY will use the 48MHZ input for the PLL. > > I think we need to add clock-names property for usb_x1 at least. Indeed. "if a 'usb_x1' clock node exists" is too fragile; better reference the clock from "clocks". > I checked the other doc "renesas,du.txt". > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/display/renesas,du.txt#n31 > > I think we can reuse it like below: > > - clock-names: Name of the clocks. This property is model-dependent. > - R-Car Gen3 SoCs use a single functional clock. The clock doesn't need to be > named. > - RZ/A2 uses a single functional clock as a separate dedicated 48MHz and a separate? > USB_X1 input. So, the functional clock must be named "???" and > the USB_X1 input must be named as "usb_x1". > > What do you think? I'm not sure how to be named the functional clock so that > the sample is named as "???". We typically use "fclk" for the functional clock's name. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds