From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F98C433F5 for ; Thu, 7 Oct 2021 17:02:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51B2D601FA for ; Thu, 7 Oct 2021 17:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242922AbhJGREI (ORCPT ); Thu, 7 Oct 2021 13:04:08 -0400 Received: from mail-vs1-f53.google.com ([209.85.217.53]:35706 "EHLO mail-vs1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242929AbhJGREI (ORCPT ); Thu, 7 Oct 2021 13:04:08 -0400 Received: by mail-vs1-f53.google.com with SMTP id w13so7545845vsa.2; Thu, 07 Oct 2021 10:02:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Net6A8uPndAbUJ/QYF9dWGXevGNTqsRWAodqdtCMsEE=; b=a3AH8lJ25c2IqDesnUpgKMiv4JLi4VTKuA6iZnJT7u9QmmFoIVZonTOimgx8Cmo5BA OwQLqP9p3kgdXd46hYX8clAyPMNMYcszKnPOrYrKlP1LanjUdQfVhP4W1nlDTylqkm61 ouS5oD0naWRMghQeGL+RR4fTBYFnShsMiKrMdS1UV+5m6ymQTG+7/VqibVMXBkvWd6p+ 97+qwpZfMJBusBYCtkONl9Lk9lrFqg5XZzcJT5fe1SN8BlcxwoYsn2hvJMn2STicKLPA 8P5BPFtzLBYghvIiAPprAgj8naSK5B+Rw4CusGEDE+JOVjKy+T2SwJM221P2Alq9xat3 rp6A== X-Gm-Message-State: AOAM532sd+ROhdggJyVf6L4py4HQSPoapEO31H6dWu6PsKbx6I9hackS 9Kreddm9KEN57aRyFh7IdKRo9zKkxubNJympOwcqHso6qTo= X-Google-Smtp-Source: ABdhPJzVmcl8PZkb76DK9qwOf9kWSU1i0RLwFeh1d7XJBpKhfCCDagP8eWWePrc2v0sVe7t2WFcWBkJeMX/uQi0Udfs= X-Received: by 2002:a67:2c58:: with SMTP id s85mr5480132vss.35.1633626133545; Thu, 07 Oct 2021 10:02:13 -0700 (PDT) MIME-Version: 1.0 References: <20210930121630.17449-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210930121630.17449-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20210930121630.17449-3-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 7 Oct 2021 19:02:02 +0200 Message-ID: Subject: Re: [RFC PATCH 2/4] pinctrl: pinconf-generic: Add support for "output-impedance" to be extracted from DT files To: Lad Prabhakar Cc: Linus Walleij , Rob Herring , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Prabhakar, On Thu, Sep 30, 2021 at 2:17 PM Lad Prabhakar wrote: > Add "output-impedance" property to generic options used for DT parsing > files. This enables drivers, which use generic pin configurations, to > get the value passed to this property. > > Signed-off-by: Lad Prabhakar Thanks for your patch! > --- a/drivers/pinctrl/pinconf-generic.c > +++ b/drivers/pinctrl/pinconf-generic.c > @@ -46,6 +46,7 @@ static const struct pin_config_item conf_items[] = { > PCONFDUMP(PIN_CONFIG_MODE_LOW_POWER, "pin low power", "mode", true), > PCONFDUMP(PIN_CONFIG_OUTPUT_ENABLE, "output enabled", NULL, false), > PCONFDUMP(PIN_CONFIG_OUTPUT, "pin output", "level", true), > + PCONFDUMP(PIN_CONFIG_OUTPUT_IMPEDANCE, "output impedance", "ohm", true), > PCONFDUMP(PIN_CONFIG_POWER_SOURCE, "pin power source", "selector", true), > PCONFDUMP(PIN_CONFIG_SLEEP_HARDWARE_STATE, "sleep hardware state", NULL, false), > PCONFDUMP(PIN_CONFIG_SLEW_RATE, "slew rate", NULL, true), > @@ -179,6 +180,7 @@ static const struct pinconf_generic_params dt_params[] = { > { "output-disable", PIN_CONFIG_OUTPUT_ENABLE, 0 }, > { "output-enable", PIN_CONFIG_OUTPUT_ENABLE, 1 }, > { "output-high", PIN_CONFIG_OUTPUT, 1, }, > + { "output-impedance", PIN_CONFIG_OUTPUT_IMPEDANCE, 0 }, "output-impedance-ohms", as per DT standardized property units. > { "output-low", PIN_CONFIG_OUTPUT, 0, }, > { "power-source", PIN_CONFIG_POWER_SOURCE, 0 }, > { "sleep-hardware-state", PIN_CONFIG_SLEEP_HARDWARE_STATE, 0 }, With the above fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds