From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3928C4320A for ; Mon, 23 Aug 2021 10:18:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B584A6115A for ; Mon, 23 Aug 2021 10:18:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235955AbhHWKSp (ORCPT ); Mon, 23 Aug 2021 06:18:45 -0400 Received: from mail-vs1-f53.google.com ([209.85.217.53]:38752 "EHLO mail-vs1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233518AbhHWKSo (ORCPT ); Mon, 23 Aug 2021 06:18:44 -0400 Received: by mail-vs1-f53.google.com with SMTP id t4so7850349vsm.5; Mon, 23 Aug 2021 03:18:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fn6frUv3RQ/aTjcmQj/o89ICwJB87FoHT5MS19YzVHM=; b=fiqr3sG6gy0h+XgQeywAVSA2hkFj3Keio8jHmi9liC06PECDccy0t2kCjr3lZ1+Jjr VeMeBGqv734n/BPWiHEdqzxQy13rOC9dPmlOcpoCN/ahGne26TERbyw1Lm8NNx9Fafcp 0P+6+f3VGS5/msLEWIBufYGwhUAxXX/WUo6b0wGUwTK7RbzAgMq4VTaUoBdZSwlvy4n6 fEBw3Pi+YGh+5Tsbkj5om2PmS8alhh0oU9n9rDihUiAWmQCU2SUWT6ETHlAm3lKKED+7 QXqzwfknIEs8jCDKIpvmxp2CdAux+SDrZ1n6iDSDlQG1I7rx1PT3wRRnBz9Ugs8ZJqGd rbtg== X-Gm-Message-State: AOAM533rQMK/YfsC71vQzxLAS8LEDvRJlGBgWPalPanRQIxciD6ICkMV nCYrVPacVSCr17MP3u8bdJtcybBAvYw6qddKm7s= X-Google-Smtp-Source: ABdhPJwlCanF14EHYCKCFLIhNlaGYU+ggYsOisyFUA/DqJkwdSAMQnOyL5VqX+D7DhPY+/mopUoKoyjACSnbySpEy0c= X-Received: by 2002:a67:c789:: with SMTP id t9mr23378055vsk.60.1629713881619; Mon, 23 Aug 2021 03:18:01 -0700 (PDT) MIME-Version: 1.0 References: <92b6718f5618d5469f67b48fbea189cca0c12f4b.1628670468.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 23 Aug 2021 12:17:50 +0200 Message-ID: Subject: Re: [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation To: Mike Rapoport Cc: Rob Herring , Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Nick Kossifidis , Paul Walmsley , Palmer Dabbelt , Albert Ou , Frank Rowand , Dave Young , Baoquan He , Vivek Goyal , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:BROADCOM NVRAM DRIVER" , linux-riscv , kexec@lists.infradead.org, Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Mike, On Mon, Aug 16, 2021 at 7:52 AM Mike Rapoport wrote: > On Wed, Aug 11, 2021 at 10:50:59AM +0200, Geert Uytterhoeven wrote: > > Prepare for early_init_fdt_scan_reserved_mem() reserving the memory > > occupied by an elf core header described in the device tree. > > As arch_mem_init() calls early_init_fdt_scan_reserved_mem() before > > mips_reserve_vmcore(), the latter needs to check if the memory has > > already been reserved before. > > Doing memblock_reserve() for the same region is usually fine, did you > encounter any issues without this patch? Does it also work if the same region is part of an earlier larger reservation? I am no memblock expert, so I don't know. I didn't run into any issues, as my MIPS platform is non-DT, but I assume arch/arm64/mm/init.c:reserve_elfcorehdr() had the check for a reason. Thanks! > > > Note that mips_reserve_vmcore() cannot just be removed, as not all MIPS > > systems use DT. > > > > Signed-off-by: Geert Uytterhoeven > > --- > > v5: > > - New. > > --- > > arch/mips/kernel/setup.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > > index 23a140327a0bac1b..4693add05743d78b 100644 > > --- a/arch/mips/kernel/setup.c > > +++ b/arch/mips/kernel/setup.c > > @@ -429,7 +429,8 @@ static void __init mips_reserve_vmcore(void) > > pr_info("Reserving %ldKB of memory at %ldKB for kdump\n", > > (unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10); > > > > - memblock_reserve(elfcorehdr_addr, elfcorehdr_size); > > + if (!memblock_is_region_reserved(elfcorehdr_addr, elfcorehdr_size) > > + memblock_reserve(elfcorehdr_addr, elfcorehdr_size); > > #endif > > } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds