From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jiri Kosina <trivial@kernel.org>, Mark Brown <broonie@kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Pavel Machek <pavel@denx.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Prabhakar <prabhakar.csengg@gmail.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer()
Date: Fri, 27 Nov 2020 10:34:07 +0100 [thread overview]
Message-ID: <CAMuHMdVfuJ79OR3mUPEux7JC0yDAbgnbx6wuyXMdBtJhHSSFEg@mail.gmail.com> (raw)
In-Reply-To: <20201126191146.8753-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
On Thu, Nov 26, 2020 at 8:12 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> In the error path of rpcif_manual_xfer() the value of ret is overwritten
> by value returned by reset_control_reset() function and thus returning
> incorrect value to the caller.
>
> This patch makes sure the correct value is returned to the caller of
> rpcif_manual_xfer() by dropping the overwrite of ret in error path.
> Also now we ignore the value returned by reset_control_reset() in the
> error path and instead print a error message when it fails.
>
> Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver")
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: stable@vger.kernel.org
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-11-27 9:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 19:11 [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes Lad Prabhakar
2020-11-26 19:11 ` [PATCH v2 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer() Lad Prabhakar
2020-11-27 9:34 ` Geert Uytterhoeven [this message]
2020-11-27 22:38 ` Pavel Machek
2020-11-28 11:32 ` Krzysztof Kozlowski
2020-11-26 19:11 ` [PATCH v2 2/5] memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in rpcif_{enable,disable}_rpm Lad Prabhakar
2020-11-26 19:33 ` Sergei Shtylyov
2020-11-28 11:33 ` Krzysztof Kozlowski
2020-11-26 19:11 ` [PATCH v2 3/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() Lad Prabhakar
2020-11-27 9:33 ` Geert Uytterhoeven
2020-11-27 22:41 ` Pavel Machek
2020-11-28 11:35 ` Krzysztof Kozlowski
2020-11-26 19:11 ` [PATCH v2 4/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline Lad Prabhakar
2020-11-27 22:41 ` Pavel Machek
2020-11-28 11:37 ` Krzysztof Kozlowski
2020-11-26 19:11 ` [PATCH v2 5/5] memory: renesas-rpc-if: Export symbols as GPL Lad Prabhakar
2020-11-28 11:41 ` Krzysztof Kozlowski
2020-11-28 12:46 ` Prabhakar Mahadev Lad
2021-07-03 15:21 ` Pavel Machek
2020-11-26 19:37 ` [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes Sergei Shtylyov
2020-12-03 10:41 ` Lad, Prabhakar
2020-12-03 10:52 ` Geert Uytterhoeven
2020-12-03 12:34 ` Prabhakar Mahadev Lad
2020-12-03 13:19 ` Krzysztof Kozlowski
2020-12-04 9:46 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVfuJ79OR3mUPEux7JC0yDAbgnbx6wuyXMdBtJhHSSFEg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pavel@denx.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sergei.shtylyov@gmail.com \
--cc=stable@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).