linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>
Cc: Rob Herring <robh+dt@kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v4 00/10] Update clock definitions
Date: Mon, 28 Jun 2021 14:18:57 +0200	[thread overview]
Message-ID: <CAMuHMdVohKYf9u6pXh5=FcD_A28F-DzjP_KUanH9W6ozZ-v-Xw@mail.gmail.com> (raw)
In-Reply-To: <20210626081344.5783-1-biju.das.jz@bp.renesas.com>

Hi Biju, Mike, Stephen, Arnd, Olof,

On Sat, Jun 26, 2021 at 10:13 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> This patch series aims to update clock and reset definitions as per
> RZ/G2L_clock_list_r02_02.xlsx and RZ/G2L HW(Rev.0.50) manual.
>
> As per this, we need to separate resets from module clocks in order to
> handle it efficiently.
>
> Added support for multi clock PM support and updated clock driver enties.
>
> This patch series is tested with USB Host, USB Device, I2C, DMAC and SSI.
>
> This patch series is based on [1] and [2]
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=renesas-clk-for-v5.15
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git/
>
> v3->v4:
>  * Fixed the code comment onoff to bit.
> v2->v3
>  * Improved clk/reset code as per Geert's suggestion.
>  * Added Geert's Rb tag
>
> v1->v2
>  * Updated reset entries
>  * Added Geert's Rb tag for multi clock PM support.
>
> v1:
>  * https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=503135

Thanks for your series!

For those who missed the story behind this: after queuing the initial
support for the new Renesas RZ/G2{L,LC} SoCs for v5.14, we discovered
an issue with the way how clocks and resets are handled for modules
more complex than serial ports and i2c controllers.  Fixing that
required a redesign of the DT binding definitions, which are a hard
dependency for both the clock/reset driver and DTS.

Hence to avoid regressions and bisection issues, I plan to queue the
first 7 patches (with patches 5-7 squashed together) in renesas-fixes
for v5.14 after v5.14-rc1 has been released.  The last 3 patches
can be handled normally again, and are to be queued in renesas-devel
for v5.15.

Sorry for the mess, and thanks for your understanding!

> Biju Das (10):
>   drivers: clk: renesas: renesas-rzg2l-cpg: Add multi clock PM support
>   drivers: clk: renesas: r9a07g044-cpg: Rename divider table
>   drivers: clk: renesas: r9a07g044-cpg: Fix P1 Clock
>   drivers: clk: renesas: r9a07g044-cpg: Add P2 Clock support
>   dt-bindings: clk: r9a07g044-cpg: Update clock/reset definitions
>   drivers: clk: renesas: r9a07g044-cpg: Update {GIC,IA55,SCIF}
>     clock/reset entries
>   arm64: dts: renesas: r9a07g044: Update SCIF0 clock/reset
>   drivers: clk: renesas: r9a07g044-cpg: Add I2C clocks/resets
>   drivers: clk: renesas: r9a07g044-cpg: Add DMAC clocks/resets
>   arm64: dts: renesas: r9a07g044: Add I2C nodes
>
>  arch/arm64/boot/dts/renesas/r9a07g044.dtsi |  84 +++++++-
>  drivers/clk/renesas/r9a07g044-cpg.c        |  99 ++++++---
>  drivers/clk/renesas/renesas-rzg2l-cpg.c    | 110 +++++-----
>  drivers/clk/renesas/renesas-rzg2l-cpg.h    |  37 +++-
>  include/dt-bindings/clock/r9a07g044-cpg.h  | 236 ++++++++++++++++-----
>  5 files changed, 419 insertions(+), 147 deletions(-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      parent reply	other threads:[~2021-06-28 12:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-26  8:13 [PATCH v4 00/10] Update clock definitions Biju Das
2021-06-26  8:13 ` [PATCH v4 01/10] drivers: clk: renesas: renesas-rzg2l-cpg: Add multi clock PM support Biju Das
2021-06-26  8:13 ` [PATCH v4 02/10] drivers: clk: renesas: r9a07g044-cpg: Rename divider table Biju Das
2021-06-26  8:13 ` [PATCH v4 03/10] drivers: clk: renesas: r9a07g044-cpg: Fix P1 Clock Biju Das
2021-06-26  8:13 ` [PATCH v4 04/10] drivers: clk: renesas: r9a07g044-cpg: Add P2 Clock support Biju Das
2021-06-26  8:13 ` [PATCH v4 05/10] dt-bindings: clk: r9a07g044-cpg: Update clock/reset definitions Biju Das
2021-07-14  2:42   ` Rob Herring
2021-07-14  8:11     ` Geert Uytterhoeven
2021-06-26  8:13 ` [PATCH v4 06/10] drivers: clk: renesas: r9a07g044-cpg: Update {GIC,IA55,SCIF} clock/reset entries Biju Das
2021-06-28 12:00   ` Geert Uytterhoeven
2021-06-26  8:13 ` [PATCH v4 07/10] arm64: dts: renesas: r9a07g044: Update SCIF0 clock/reset Biju Das
2021-06-26  8:13 ` [PATCH v4 08/10] drivers: clk: renesas: r9a07g044-cpg: Add I2C clocks/resets Biju Das
2021-06-26  8:13 ` [PATCH v4 09/10] drivers: clk: renesas: r9a07g044-cpg: Add DMAC clocks/resets Biju Das
2021-06-26  8:13 ` [PATCH v4 10/10] arm64: dts: renesas: r9a07g044: Add I2C nodes Biju Das
2021-06-28 12:18 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVohKYf9u6pXh5=FcD_A28F-DzjP_KUanH9W6ozZ-v-Xw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=arnd@arndb.de \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=olof@lixom.net \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).