* [PATCH renesas-drivers] dt-bindings: misc: Fix logic analyzer bindings
@ 2021-04-29 9:30 Geert Uytterhoeven
2021-04-29 11:50 ` Niklas Söderlund
2021-04-29 13:32 ` Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-04-29 9:30 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Niklas Söderlund, linux-renesas-soc, Geert Uytterhoeven
When running "make dt_binding_check":
Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: properties:required: ['compatible', 'probe-gpios'] is not of type 'object', 'boolean'
Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'required'
SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: ignoring, error in schema: properties: required
warning: no schema found in file: Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
and:
Error: Documentation/devicetree/bindings/misc/gpio-logic-analyzer.example.dts:22.42-43 syntax error
FATAL ERROR: Unable to parse input tree
Fix this by correcting the indentation of the "required" block, and
adding the missing include.
Fixes: 1c8e77fc12417023 ("misc: add simple logic analyzer using polling")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../devicetree/bindings/misc/gpio-logic-analyzer.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml b/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
index e664cec85a72facd..5516f95b72d53ff1 100644
--- a/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
+++ b/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
@@ -22,14 +22,15 @@ properties:
description:
names used to distinguish the probes
- required:
- - compatible
- - probe-gpios
+required:
+ - compatible
+ - probe-gpios
additionalProperties: false
examples:
- |
+ #include <dt-bindings/gpio/gpio.h>
i2c-analyzer {
compatible = "gpio-logic-analyzer";
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH renesas-drivers] dt-bindings: misc: Fix logic analyzer bindings
2021-04-29 9:30 [PATCH renesas-drivers] dt-bindings: misc: Fix logic analyzer bindings Geert Uytterhoeven
@ 2021-04-29 11:50 ` Niklas Söderlund
2021-04-29 13:32 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Niklas Söderlund @ 2021-04-29 11:50 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Wolfram Sang, linux-renesas-soc
Hi Geert,
Thanks for your work.
On 2021-04-29 11:30:37 +0200, Geert Uytterhoeven wrote:
> When running "make dt_binding_check":
>
> Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: properties:required: ['compatible', 'probe-gpios'] is not of type 'object', 'boolean'
> Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'required'
> SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: ignoring, error in schema: properties: required
> warning: no schema found in file: Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
>
> and:
>
> Error: Documentation/devicetree/bindings/misc/gpio-logic-analyzer.example.dts:22.42-43 syntax error
> FATAL ERROR: Unable to parse input tree
>
> Fix this by correcting the indentation of the "required" block, and
> adding the missing include.
>
> Fixes: 1c8e77fc12417023 ("misc: add simple logic analyzer using polling")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> .../devicetree/bindings/misc/gpio-logic-analyzer.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml b/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
> index e664cec85a72facd..5516f95b72d53ff1 100644
> --- a/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
> +++ b/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
> @@ -22,14 +22,15 @@ properties:
> description:
> names used to distinguish the probes
>
> - required:
> - - compatible
> - - probe-gpios
> +required:
> + - compatible
> + - probe-gpios
>
> additionalProperties: false
>
> examples:
> - |
> + #include <dt-bindings/gpio/gpio.h>
> i2c-analyzer {
> compatible = "gpio-logic-analyzer";
>
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH renesas-drivers] dt-bindings: misc: Fix logic analyzer bindings
2021-04-29 9:30 [PATCH renesas-drivers] dt-bindings: misc: Fix logic analyzer bindings Geert Uytterhoeven
2021-04-29 11:50 ` Niklas Söderlund
@ 2021-04-29 13:32 ` Wolfram Sang
2021-04-29 13:49 ` Geert Uytterhoeven
1 sibling, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2021-04-29 13:32 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Niklas Söderlund, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
> Fix this by correcting the indentation of the "required" block, and
> adding the missing include.
Thank you! But this file is going to be removed in v2. I agree with
LinusW and the GPIO crowd that bindings for debugging do not need to be
"official".
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH renesas-drivers] dt-bindings: misc: Fix logic analyzer bindings
2021-04-29 13:32 ` Wolfram Sang
@ 2021-04-29 13:49 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-04-29 13:49 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Niklas Söderlund, Linux-Renesas
Hi Wolfram,
On Thu, Apr 29, 2021 at 3:33 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > Fix this by correcting the indentation of the "required" block, and
> > adding the missing include.
>
> Thank you! But this file is going to be removed in v2. I agree with
> LinusW and the GPIO crowd that bindings for debugging do not need to be
> "official".
I understand.
I fixed it because it was bugging people working on Renesas DT bindings.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-29 13:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 9:30 [PATCH renesas-drivers] dt-bindings: misc: Fix logic analyzer bindings Geert Uytterhoeven
2021-04-29 11:50 ` Niklas Söderlund
2021-04-29 13:32 ` Wolfram Sang
2021-04-29 13:49 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).