From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FDECC43331 for ; Thu, 26 Mar 2020 09:00:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B99D2070A for ; Thu, 26 Mar 2020 09:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbgCZJAD (ORCPT ); Thu, 26 Mar 2020 05:00:03 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:37812 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726210AbgCZJAC (ORCPT ); Thu, 26 Mar 2020 05:00:02 -0400 Received: by mail-oi1-f193.google.com with SMTP id u20so85384oic.4; Thu, 26 Mar 2020 02:00:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pfBoZ6XWbQ4KrliwGJFyfFIGFoQRaKutoj2iGGBbZ/8=; b=PjgH72PTZxyHhiNPl+U6nqCtGjvFzor94e8Bn+QveG6NE6SyNYIIDFIEoQF/AVlM4c vfmclA5kQfZpKucrTJHQQpYb4nRlCTQfmFHJFboDXNgHmlWzHe6Jdq4C66Aq+85vSuZv 4aYJsWzbCe6bB9iryyrUksRnhzRGfxx1yFf5myMJU3gQxO5Iipup3gsFLxmzE0VRWB10 Zb4YUvMmSBuYP7XHgHZgubhBbNzQdGNIRbEQefx+DpvCDm8CGN4Yog6StJoqDD4eGGvu 9FNRcC2PyollbVv48jxfcXZdWWk0X8zJRRCK3FBY3mgMczd3YDMmdvO+ghDMCp01McZz lzQA== X-Gm-Message-State: ANhLgQ2ypIyuOFgKxw44jsjWA/K4hjUtE8eW4HzzTgCY7iMCo1drQpje TH8jToLztvK/4Tw1cJP34t+y3zh9lQ6xJZFN+oQ= X-Google-Smtp-Source: ADFU+vunNPMm7n4lDtng9ONOCC+CUOSNaxldESCtYKuWG26njMdjPZls8Bkeas3fZwolEuBeS6R5akyYkDNpy9/Z57M= X-Received: by 2002:aca:ad93:: with SMTP id w141mr1128472oie.54.1585213200541; Thu, 26 Mar 2020 02:00:00 -0700 (PDT) MIME-Version: 1.0 References: <1585200559-30033-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1585200559-30033-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: <1585200559-30033-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> From: Geert Uytterhoeven Date: Thu, 26 Mar 2020 09:59:49 +0100 Message-ID: Subject: Re: [PATCH v2 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema To: Yoshihiro Shimoda Cc: Kishon Vijay Abraham I , Rob Herring , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Shimoda-san, On Thu, Mar 26, 2020 at 6:30 AM Yoshihiro Shimoda wrote: > Convert Renesas R-Car generation 3 USB 2.0 PHY bindings documentation > to json-schema. > > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Rob Herring Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: GPL-2.0-only I think Rob would prefer to see # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + reg: > + # base address and length of the registers block for the PHY. The comment is not needed. > + maxItems: 1 > + > + clocks: > + # clock phandle and specifier pair(s). Likewise. > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + # for RZ/A2 if: properties: compatible: items: enum: - renesas,usb2-phy-r7s9210 > + minItems: 1 > + maxItems: 2 > + items: > + - const: fck > + - const: usb_x1 > +examples: > + - | > + #include > + #include > + #include > + > + usb-phy@ee080200 { > + compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy"; > + reg = <0 0xee080200 0 0x700>; Examples are built with #{address,size}-cells = <1>, so reg = <0xee080200 0x700>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 703>; > + #phy-cells = <1>; > + }; > + > + usb-phy@ee0a0200 { > + compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy"; > + reg = <0 0xee0a0200 0 0x700>; reg = <0xee0a0200 0x700>; > + clocks = <&cpg CPG_MOD 702>; > + #phy-cells = <1>; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds