From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7794C3A59E for ; Mon, 26 Aug 2019 07:34:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5101206BA for ; Mon, 26 Aug 2019 07:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730124AbfHZHex (ORCPT ); Mon, 26 Aug 2019 03:34:53 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:37439 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728168AbfHZHex (ORCPT ); Mon, 26 Aug 2019 03:34:53 -0400 Received: by mail-ot1-f66.google.com with SMTP id f17so14330723otq.4; Mon, 26 Aug 2019 00:34:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ay8N/faohD0Lm5RaNx+jFCWBPDb56qWI9o+yg7jXEF4=; b=Jv/Ub004BZFrh7fjZp83Iz8iCkuXfEdYVNJXtbqKpeqNrJj9jNvQyIhjzzbGlU7P9x Gph5BpHm5Kfr/5JQf1n9pvVFsG9OVr25kgtVHt2nWJqfD8IT6AH6T0sHc+vrtElaC4JB EmPrp/vFwxoAVarjqpCcXr94BUJcP1w4d3BzuFINaB23FBnda1EnIedBSJpk6dA+k3r4 Lw+Bsbyyg6AgiPlWrIlqiWUdLFqyFzgMGnNH68jLTw8keDiFsgRu6Q1C4S01mRhjV3VZ 6p5EBCSu4OZGmoIIEFI4iDerr1Fw3AJtZSqye0E/pkDvSRrpTFfwUmkRCbnD0mOVVYY/ J2IA== X-Gm-Message-State: APjAAAVjVpG/gqSPt3fIcqV9oQfMdDUSlmDuPK0Vl37Fr9w4pZHog+Vo kOr83vFMYL21sT6iJSiMJnv1QeinfMEu72Zew+k= X-Google-Smtp-Source: APXvYqzy1veDPd3iL/NVpS6ZbZGKhvD5DPUadhwD8wnxhM0EWUPvpHpdeCesQKBpWxzo5eBHxKlovNB9O0GVLTmCxSE= X-Received: by 2002:a9d:68c5:: with SMTP id i5mr14294327oto.250.1566804892097; Mon, 26 Aug 2019 00:34:52 -0700 (PDT) MIME-Version: 1.0 References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-2-jacopo+renesas@jmondi.org> In-Reply-To: <20190825135154.11488-2-jacopo+renesas@jmondi.org> From: Geert Uytterhoeven Date: Mon, 26 Aug 2019 09:34:41 +0200 Message-ID: Subject: Re: [PATCH v3 01/14] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation To: Jacopo Mondi Cc: Laurent Pinchart , Kieran Bingham , Simon Horman , Ulrich Hecht , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Mark Rutland Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Jacopo, On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > Signed-off-by: Jacopo Mondi Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > @@ -0,0 +1,33 @@ > +* Renesas R-Car Color Management Module (CMM) > + > +Renesas R-Car image enhancement module connected to R-Car DU video channels. > + > +Required properties: > + - compatible: shall be one or more of the following: > + - "renesas,cmm-r8a7795": for R8A7795 (R-Car H3) compatible CMM. > + - "renesas,cmm-r8a7796": for R8A7796 (R-Car M3-W) compatible CMM. > + - "renesas,cmm-r8a77965": for R8A77965 (R-Car M3-N) compatible CMM. > + - "renesas,cmm-r8a77990": for R8A77990 (R-Car E3) compatible CMM. > + - "renesas,cmm-r8a77995": for R8A77995 (R-Car D3) compatible CMM. Please use "renesas,-cmm" instead of "renesas,cmm-". > + - "renesas,rcar-gen3-cmm": for a generic R-Car Gen3 compatible CMM. > + - "renesas,rcar-gen2-cmm": for a generic R-Car Gen2 compatible CMM. > + > + When the generic compatible string is specified, the SoC-specific > + version corresponding to the platform should be listed first. > + > + - reg: the address base and length of the memory area where CMM control > + registers are mapped to. > + > + - clocks: phandle and clock-specifier pair to the CMM functional clock > + supplier. Thinking about yaml validation: power-domains? resets? > +Example: > +-------- > + > + cmm0: cmm@fea40000 { > + compatible = "renesas,cmm-r8a7796"; > + reg = <0 0xfea40000 0 0x1000>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 711>; > + resets = <&cpg 711>; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds