From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E54FC04AB4 for ; Tue, 14 May 2019 10:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 273C22085A for ; Tue, 14 May 2019 10:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbfENKII (ORCPT ); Tue, 14 May 2019 06:08:08 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:34906 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbfENKIH (ORCPT ); Tue, 14 May 2019 06:08:07 -0400 Received: by mail-vs1-f67.google.com with SMTP id q13so5084946vso.2; Tue, 14 May 2019 03:08:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dUhPIQQJZs5Vh3eweO1WtOgzVtv83v6N5NsZQ6JZ7+c=; b=YxNiTXXHoDBFpFTaWS7OqKMlXpPl8foshheVv3W3yV5+1Ss2Os8TxkKZHNQuDYaMys WqMr06byaneCZaHr5b2/T1VPn6HHKFfFEW+nzSZSkyODGX8NaY/SxIeT7OFU8NKSHLQz 29GrbXgDKHkJ97lGVCCF29j4lyWKjnCEhYymxNtWbNdHBR1HlSfk8P/3AtmEzm8xzEoR s7h4FbAORuytl3hOST6tTBF/nmlOnh2h3iPBVyzGB+KP1F9FIbcpACOlMtv4QNnXov8S y4QcbJTBmxkMN2l3YARFcSdyiLCc4nRuicrK39wAyOu8GEsfInzGnyUaZ8oHmRa5UhNj gvqw== X-Gm-Message-State: APjAAAV69evRn/yCRv/Iu+4e1Jgw/tLccKBbsKt9mti0n+v+rAAtRrPi JdvJVCvgGCYSLwYtOT8X8EvsgUqpKJaEb+CZ1sE= X-Google-Smtp-Source: APXvYqyKB1cL40577bS36WrKoIvy12plVmfKdngymvdB6XDyb6Wgl/Dtk2X3JeqP2l9zunBcmzvTb9DUCwWc+RrOsBs= X-Received: by 2002:a67:fdd4:: with SMTP id l20mr12127723vsq.63.1557828486542; Tue, 14 May 2019 03:08:06 -0700 (PDT) MIME-Version: 1.0 References: <1556092536-17095-1-git-send-email-masonccyang@mxic.com.tw> <1556092536-17095-4-git-send-email-masonccyang@mxic.com.tw> <20190424212356.GA27103@bogus> <65853dc2-6f3c-1494-7e72-54877797cdd2@gmail.com> <20190507125730.GD29524@dell> <20190508061119.GB7627@dell> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 14 May 2019 12:07:54 +0200 Message-ID: Subject: Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings To: Mason Yang Cc: Sergei Shtylyov , Lee Jones , Boris Brezillon , Mark Brown , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Simon Horman , juliensu@mxic.com.tw, Linux Kernel Mailing List , Linux-Renesas , linux-spi , Marek Vasut , Mark Rutland , Rob Herring , zhengxunli@mxic.com.tw Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Mason, On Tue, May 14, 2019 at 11:46 AM wrote: > > >> There's precedence for such constructs being an MFD: please see > > >> drivers/mfd/at91-usart.c, which registers a single MFD cell for > > > second for the direct mapping read mode and > > > third for the write buffer area. > > > - reg-names: should contain "regs", "dirmap" and "wbuf" > > > - clocks: should contain 1 entries for the module's clock > > > - clock-names: should contain "rpc" > > > > I suspect we'd need the RPC/RPCD2 clocks mentioned as well (not sure > yet)... > > Need it ? > RPCD2 is derived from RPC and it's value is half of RPC, > i.e., RPC = 160MHz, RPCD2 = 80 MHz That hierarchy depends on the actual SoC, right? AFAIU, both are derived from RPCSRC, and can be controlled individually on some SoCs. BTW, I still haven't seen a patch for drivers/clk/renesas/r8a77995-cpg-mssr.c adding RPC-related clocks, so I have no idea what's the Linux view of the hierarchy on your system. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds