From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3BCEC43331 for ; Tue, 12 Nov 2019 18:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4FD8222C1 for ; Tue, 12 Nov 2019 18:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbfKLSSu (ORCPT ); Tue, 12 Nov 2019 13:18:50 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:35328 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726912AbfKLSSu (ORCPT ); Tue, 12 Nov 2019 13:18:50 -0500 Received: by mail-ot1-f68.google.com with SMTP id z6so15177076otb.2; Tue, 12 Nov 2019 10:18:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XTjrI15sJKpXt7dvewwDXHz0pV+jFPaIY5CBR1+M5B8=; b=RXZsxcyWXB5gzaKeez4c9288OBzj9Zo01HOIeoOMvveHruIEyNKkVi+9s6I1vQd8iF i+dYIsoMTxEf8JcovkcVJTcIYRT+ycop9cdVLSjM6TlecGlUN4I0w8t0Ie1evCREs5XA Fu4XhD6TUw7Hzb0bJ42ImFdOXc5KyjeTQgpiE5qhAfHsOP/5XG2Fz8iV2nBHahEhOsmd Wf4wX9dTfKzWZ0yL22MnPeXcKMDrneO8QMmX7Jxqdd3LOHKeUhHRVbRsP7Dfl+nAxBU3 DSlv2NSKKU9luRve65jltlqT6iaoDL94BF1P7CoAJfOxUnjxb9yCqqkSzYbLg1ZazllQ 37MA== X-Gm-Message-State: APjAAAVT9bCfAHvG7Zphvf40s3IPeB+abFPkC06lFrNgOStTkf9v/yJk vSYpvJcyiobg/f7SS99tA8Ir65o9g7nRVOlXya0= X-Google-Smtp-Source: APXvYqzD+0NmN816zDyFVW7CaZTRm/xP/54mEwEWwWhYEoQSfE5Y17LnYKLFTjDPUOLhknTl9poWdDu1inn62pEqTEM= X-Received: by 2002:a9d:5511:: with SMTP id l17mr2705329oth.145.1573582728911; Tue, 12 Nov 2019 10:18:48 -0800 (PST) MIME-Version: 1.0 References: <20191112141819.GA22076@localhost.localdomain> In-Reply-To: <20191112141819.GA22076@localhost.localdomain> From: Geert Uytterhoeven Date: Tue, 12 Nov 2019 19:18:37 +0100 Message-ID: Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION To: Matti Vaittinen Cc: Matti Vaittinen , Linus Walleij , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sean Wang , Matthias Brugger , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Chen-Yu Tsai , Paul Cercueil , Neil Armstrong , Heiko Stuebner , Geert Uytterhoeven , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Andy Gross , Bjorn Andersson , "open list:GPIO SUBSYSTEM" , linux-rpi-kernel , Linux ARM , Linux Kernel Mailing List , linux-mediatek@lists.infradead.org, linux-oxnas@groups.io, "open list:ARM/Rockchip SoC..." , Linux-Renesas , linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, Nov 12, 2019 at 3:18 PM Matti Vaittinen wrote: > Use newly added GPIO defines GPIO_LINE_DIRECTION_IN and > GPIO_LINE_DIRECTION_OUT instead of using hard-coded 1 and 0. > > Main benefit is to make it easier to see which values mean IN and which > OUT. As a side effect this helps GPIO framework to change the direction > defines to something else if ever needed. > > Please note that return value from get_direction call on > pinctrl-axp209 driver was changed. Previously pinctrl-axp209 might have > returned value 2 for direction INPUT. > > Signed-off-by: Matti Vaittinen For: > drivers/pinctrl/pinctrl-rza1.c | 5 ++++- > drivers/pinctrl/pinctrl-rza2.c | 6 +++--- Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds