From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 808A9C46460 for ; Wed, 15 May 2019 09:04:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CC7A20881 for ; Wed, 15 May 2019 09:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725929AbfEOJEH (ORCPT ); Wed, 15 May 2019 05:04:07 -0400 Received: from mail-vs1-f65.google.com ([209.85.217.65]:44007 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbfEOJEH (ORCPT ); Wed, 15 May 2019 05:04:07 -0400 Received: by mail-vs1-f65.google.com with SMTP id d128so1181649vsc.10; Wed, 15 May 2019 02:04:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gkTbiQzGF1k2N99naRD8r5aIjsz3VLc+98eg7EfqOTI=; b=ucA96ZVdsOdVIsCNX+zdzEELNXcoreMVokEj8OVI1JTMXj4q2Af/NmGDrJmcxa4JRh H/FK07aA6JyaVchhfLb9m6naJ6PpCZP4UIJi+zNXT2BHWiRryBy3z0rxJ7ki2deWHGIW 4LlvkKzaqL4v5kHn+TeP5hQCipd6qJ8T1yH7hvNEWwow/65zTiqsgukxyRoSdqHhTXNP DbLPAihpiDiYCvAXMeS9mSM/FNA/Yj8nXfscw11079kfY13cAS6njzJGSVATNcqnasN+ jmn7/idcc42rZeUZ82VwP3inDSWft0U3Hosylar472wzq1uF0Z3zTOEpbzztouy+nVtf xbjg== X-Gm-Message-State: APjAAAUusjfvWJqpUDR/HIIzRsCayuwJzYtDXHOGk1Gydnyc1+7QXzbO UKyP3+Wi7C0GAzQMIVEDJf2xpivY4cJ3TTy6UdM= X-Google-Smtp-Source: APXvYqztnkymczgKnMVRe9ZCvVpmL+kBZMs2zWM/eCWYj13BUyDK4j+nFEPaMRWT1Ux/G56HvMqtlcdU69dOK5Yo7fs= X-Received: by 2002:a67:8e03:: with SMTP id q3mr19981536vsd.152.1557911045761; Wed, 15 May 2019 02:04:05 -0700 (PDT) MIME-Version: 1.0 References: <20190514145605.19112-1-chris.brandt@renesas.com> <20190514145605.19112-5-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 15 May 2019 11:03:54 +0200 Message-ID: Subject: Re: [PATCH v3 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1 To: Sergei Shtylyov Cc: Chris Brandt , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda , Chunfeng Yun , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Sergei, On Wed, May 15, 2019 at 10:39 AM Sergei Shtylyov wrote: > On 15.05.2019 10:35, Geert Uytterhoeven wrote: > >> Document the USB_X1 input and add clock-names to identify > >> functional and USB_X1 clocks. > >> > >> Signed-off-by: Chris Brandt > > > > Reviewed-by: Geert Uytterhoeven > > > >> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > >> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > >> @@ -28,7 +28,11 @@ Required properties: > >> followed by the generic version. > >> > >> - reg: offset and length of the partial USB 2.0 Host register block. > >> -- clocks: clock phandle and specifier pair(s). > >> +- clocks: clock phandle and specifier pair(s). For SoCs that have a separate > >> + dedicated USB_X1 input for the PLL, that is also listed. > >> +- clock-names: Name of the clocks. The functional clock shall be called "fclk" > > > > Names? > > And I think the module clock name was "fck", not "fclk"... Indeed, sorry for missing that. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds