From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Simon Horman" <horms@verge.net.au>,
"Magnus Damm" <magnus.damm@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Thierry Reding" <treding@nvidia.com>,
"Andreas Färber" <afaerber@suse.de>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Johan Hovold" <johan@kernel.org>,
"Lukasz Majewski" <lukma@denx.de>,
"Michal Simek" <monstr@monstr.eu>,
"Michal Vokáč" <michal.vokac@ysoft.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Ben Whitten" <ben.whitten@gmail.com>,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"Biju Das" <biju.das@bp.renesas.com>,
ebiharaml@si-linux.co.jp
Subject: Re: [PATCH 08/11] clk: renesas: r8a774c0: Add missing CANFD clock
Date: Wed, 16 Jan 2019 20:05:31 +0100 [thread overview]
Message-ID: <CAMuHMdWG6m11eAjvPeFXjsu3jhYnfsxN-EUXw5_SQZ6qMrebYw@mail.gmail.com> (raw)
In-Reply-To: <1547663874-29411-9-git-send-email-fabrizio.castro@bp.renesas.com>
Hi Fabrizio,
Thanks for your patch!
On Wed, Jan 16, 2019 at 7:39 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> This patch adds the missing CANFD clock to the r8a774c0 specific
> clock driver.
Are you sure the CANFD clock exists on RZ/G2E?
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> --- a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> --- a/include/dt-bindings/clock/r8a774c0-cpg-mssr.h
> +++ b/include/dt-bindings/clock/r8a774c0-cpg-mssr.h
> @@ -48,13 +48,14 @@
> #define R8A774C0_CLK_ZA2 37
> #define R8A774C0_CLK_ZA8 38
> #define R8A774C0_CLK_Z2D 39
> -#define R8A774C0_CLK_MSO 40
> -#define R8A774C0_CLK_R 41
> -#define R8A774C0_CLK_OSC 42
> -#define R8A774C0_CLK_LV0 43
> -#define R8A774C0_CLK_LV1 44
> -#define R8A774C0_CLK_CSI0 45
> -#define R8A774C0_CLK_CP 46
> -#define R8A774C0_CLK_CPEX 47
> +#define R8A774C0_CLK_CANFD 40
> +#define R8A774C0_CLK_MSO 41
> +#define R8A774C0_CLK_R 42
> +#define R8A774C0_CLK_OSC 43
> +#define R8A774C0_CLK_LV0 44
> +#define R8A774C0_CLK_LV1 45
> +#define R8A774C0_CLK_CSI0 46
> +#define R8A774C0_CLK_CP 47
> +#define R8A774C0_CLK_CPEX 48
This file is part of the DT ABI, hence list of definitions is append-only.
Please add R8A774C0_CLK_CANFD at the end, i.e.
#define R8A774C0_CLK_CANFD 48
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-01-16 19:05 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 18:37 [PATCH 00/11] Add basic EK874 support Fabrizio Castro
2019-01-16 18:37 ` [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux Fabrizio Castro
2019-01-17 10:44 ` Simon Horman
2019-01-17 11:17 ` Andreas Färber
2019-01-17 12:19 ` Simon Horman
2019-01-17 12:23 ` Chris Paterson
2019-01-22 1:14 ` Rob Herring
2019-02-14 16:21 ` Fabrizio Castro
2019-02-15 6:52 ` Lukasz Majewski
2019-02-15 9:09 ` Andreas Färber
2019-03-01 12:03 ` Fabrizio Castro
2019-03-04 9:40 ` Simon Horman
2019-01-16 18:37 ` [PATCH 02/11] dt-bindings: arm: renesas: Add si-linux cat87[45] boards Fabrizio Castro
2019-01-17 10:51 ` Simon Horman
2019-01-17 12:32 ` Chris Paterson
2019-01-17 12:59 ` Simon Horman
2019-01-22 14:49 ` Simon Horman
2019-01-16 18:37 ` [PATCH 03/11] arm64: dts: renesas: Add Si-Linux CAT874 board support Fabrizio Castro
2019-01-17 11:04 ` Geert Uytterhoeven
2019-01-22 14:52 ` Simon Horman
2019-01-16 18:37 ` [PATCH 04/11] arm64: dts: renesas: Add Si-Linux EK874 " Fabrizio Castro
2019-01-17 11:05 ` Geert Uytterhoeven
2019-01-22 14:53 ` Simon Horman
2019-01-16 18:37 ` [PATCH 05/11] arm64: dts: renesas: r8a774c0-cat874: Add pincontrol support to scif2 Fabrizio Castro
2019-01-17 11:06 ` Geert Uytterhoeven
2019-01-22 14:54 ` Simon Horman
2019-01-16 18:37 ` [PATCH 06/11] arm64: dts: renesas: r8a774c0-cat874: Add uSD support Fabrizio Castro
2019-01-17 11:11 ` Simon Horman
2019-01-17 13:19 ` Fabrizio Castro
2019-01-20 8:28 ` Simon Horman
2019-01-22 14:55 ` Simon Horman
2019-01-16 18:37 ` [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet support Fabrizio Castro
2019-01-17 11:59 ` Simon Horman
2019-01-17 13:27 ` Fabrizio Castro
2019-01-20 8:28 ` Simon Horman
2019-01-22 14:55 ` Simon Horman
2019-01-16 18:37 ` [PATCH 08/11] clk: renesas: r8a774c0: Add missing CANFD clock Fabrizio Castro
2019-01-16 19:05 ` Geert Uytterhoeven [this message]
2019-01-16 19:24 ` Fabrizio Castro
2019-01-16 18:37 ` [PATCH 09/11] dt-bindings: can: rcar_can: Fix RZ/G2 CAN clocks Fabrizio Castro
2019-01-17 12:01 ` Simon Horman
2019-01-22 1:15 ` Rob Herring
2019-03-01 11:52 ` Fabrizio Castro
2019-01-16 18:37 ` [PATCH 10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes Fabrizio Castro
2019-01-17 12:05 ` Simon Horman
2019-01-28 13:02 ` Simon Horman
2019-03-19 11:12 ` Fabrizio Castro
2019-03-19 11:54 ` Simon Horman
2019-01-16 18:37 ` [PATCH 11/11] dt-bindings: can: rcar_canfd: document r8a774c0 support Fabrizio Castro
2019-01-17 12:11 ` Simon Horman
2019-01-22 1:15 ` Rob Herring
2019-03-01 11:56 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWG6m11eAjvPeFXjsu3jhYnfsxN-EUXw5_SQZ6qMrebYw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=afaerber@suse.de \
--cc=alexandre.belloni@bootlin.com \
--cc=ben.whitten@gmail.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=ebiharaml@si-linux.co.jp \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukma@denx.de \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=michal.vokac@ysoft.com \
--cc=mkl@pengutronix.de \
--cc=monstr@monstr.eu \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=treding@nvidia.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).