From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-phy@lists.infradead.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 05/11] dt-bindings: phy: renesas,usb2-phy: Document RZ/G2L phy bindings
Date: Tue, 22 Jun 2021 17:33:48 +0200 [thread overview]
Message-ID: <CAMuHMdWJhrCtJ8stfNotr5Cfc9HK=Sytn_Tn_U1v3o+kEnwecw@mail.gmail.com> (raw)
In-Reply-To: <20210621093943.12143-6-biju.das.jz@bp.renesas.com>
Hi Biju,
On Mon, Jun 21, 2021 at 11:40 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Document USB phy bindings for RZ/G2L SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> .../bindings/phy/renesas,usb2-phy.yaml | 23 ++++++++++---------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> index 0f358d5b84ef..eebba6c83aec 100644
> --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> @@ -17,17 +17,18 @@ properties:
>
> - items:
> - enum:
> - - renesas,usb2-phy-r7s9210 # RZ/A2
> - - renesas,usb2-phy-r8a774a1 # RZ/G2M
> - - renesas,usb2-phy-r8a774b1 # RZ/G2N
> - - renesas,usb2-phy-r8a774c0 # RZ/G2E
> - - renesas,usb2-phy-r8a774e1 # RZ/G2H
> - - renesas,usb2-phy-r8a7795 # R-Car H3
> - - renesas,usb2-phy-r8a7796 # R-Car M3-W
> - - renesas,usb2-phy-r8a77961 # R-Car M3-W+
> - - renesas,usb2-phy-r8a77965 # R-Car M3-N
> - - renesas,usb2-phy-r8a77990 # R-Car E3
> - - renesas,usb2-phy-r8a77995 # R-Car D3
> + - renesas,usb2-phy-r7s9210 # RZ/A2
> + - renesas,usb2-phy-r8a774a1 # RZ/G2M
> + - renesas,usb2-phy-r8a774b1 # RZ/G2N
> + - renesas,usb2-phy-r8a774c0 # RZ/G2E
> + - renesas,usb2-phy-r8a774e1 # RZ/G2H
> + - renesas,usb2-phy-r8a7795 # R-Car H3
> + - renesas,usb2-phy-r8a7796 # R-Car M3-W
> + - renesas,usb2-phy-r8a77961 # R-Car M3-W+
> + - renesas,usb2-phy-r8a77965 # R-Car M3-N
> + - renesas,usb2-phy-r8a77990 # R-Car E3
> + - renesas,usb2-phy-r8a77995 # R-Car D3
> + - renesas,usb2-phy-r9a07g044 # RZ/G2{L,LC}
> - const: renesas,rcar-gen3-usb2-phy
>
> reg:
As some of the register bits are different, cfr. my comments to
[PATCH v2 10/11], I think you want to add a new oneOf instead:
- items:
- enum:
- renesas,usb2-phy-r9a07g044 # RZ/G2{L,LC}
- const: renesas,rzg2l-usb2-phy
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-06-22 15:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 9:39 [PATCH v2 00/11] Add USB2.0 support Biju Das
2021-06-21 9:39 ` [PATCH v2 01/11] dt-bindings: phy: renesas: Document RZ/G2L USB PHY Control bindings Biju Das
2021-06-21 17:40 ` Rob Herring
2021-06-22 16:58 ` Rob Herring
2021-06-23 13:38 ` Biju Das
2021-06-23 14:13 ` Rob Herring
2021-06-23 14:29 ` Geert Uytterhoeven
2021-06-23 15:45 ` Biju Das
2021-06-25 10:11 ` Biju Das
2021-06-21 9:39 ` [PATCH v2 02/11] drivers: clk: renesas: r9a07g044-cpg: Add USB clocks Biju Das
2021-06-21 9:39 ` [PATCH v2 03/11] phy: renesas: Add RZ/G2L usb phy control driver Biju Das
2021-06-21 9:39 ` [PATCH v2 04/11] arm64: configs: defconfig: Enable RZ/G2L USB PHY " Biju Das
2021-06-21 9:39 ` [PATCH v2 05/11] dt-bindings: phy: renesas,usb2-phy: Document RZ/G2L phy bindings Biju Das
2021-06-22 15:33 ` Geert Uytterhoeven [this message]
2021-06-21 9:39 ` [PATCH v2 06/11] dt-bindings: usb: generic-ohci: Document RZ/G2L SoC bindings Biju Das
2021-06-21 17:40 ` Rob Herring
2021-06-22 10:03 ` Biju Das
2021-06-22 19:30 ` Rob Herring
2021-06-23 14:20 ` Biju Das
2021-06-21 9:39 ` [PATCH v2 07/11] dt-bindings: usb: generic-ehci: " Biju Das
2021-06-21 17:40 ` Rob Herring
2021-06-22 10:04 ` Biju Das
2021-06-21 9:39 ` [PATCH v2 08/11] arm64: dts: renesas: r9a07g044: Add USB2.0 phy and host support Biju Das
2021-06-21 9:39 ` [PATCH v2 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings Biju Das
2021-06-21 9:39 ` [PATCH v2 10/11] phy: renesas: phy-rcar-gen3-usb2: Add OTG support for RZ/G2L Biju Das
2021-06-22 15:29 ` Geert Uytterhoeven
2021-06-23 7:04 ` Yoshihiro Shimoda
2021-06-23 11:52 ` Biju Das
2021-06-23 8:02 ` Yoshihiro Shimoda
2021-06-23 11:54 ` Biju Das
2021-06-21 9:39 ` [PATCH v2 11/11] arm64: dts: renesas: r9a07g044: Add USB2.0 device support Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWJhrCtJ8stfNotr5Cfc9HK=Sytn_Tn_U1v3o+kEnwecw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).