* [PATCH] thermal: rcar_gen3_thermal: Remove unneeded curly brackets
@ 2020-02-12 22:47 Niklas Söderlund
2020-02-13 8:01 ` Yoshihiro Shimoda
2020-02-13 8:17 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Niklas Söderlund @ 2020-02-12 22:47 UTC (permalink / raw)
To: linux-pm, linux-renesas-soc; +Cc: Niklas Söderlund
When devm_add_action() was turned into devm_add_action_or_reset() the
curly brackets for the error case where kept but are not needed, remove
them to match the style of the driver.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/thermal/rcar_gen3_thermal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
index 55d1736f532cdb33..a2bf9d8074cc4fcf 100644
--- a/drivers/thermal/rcar_gen3_thermal.c
+++ b/drivers/thermal/rcar_gen3_thermal.c
@@ -444,9 +444,8 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
goto error_unregister;
ret = devm_add_action_or_reset(dev, rcar_gen3_hwmon_action, zone);
- if (ret) {
+ if (ret)
goto error_unregister;
- }
ret = of_thermal_get_ntrips(tsc->zone);
if (ret < 0)
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] thermal: rcar_gen3_thermal: Remove unneeded curly brackets
2020-02-12 22:47 [PATCH] thermal: rcar_gen3_thermal: Remove unneeded curly brackets Niklas Söderlund
@ 2020-02-13 8:01 ` Yoshihiro Shimoda
2020-02-13 8:17 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2020-02-13 8:01 UTC (permalink / raw)
To: Niklas Söderlund, linux-pm, linux-renesas-soc
Hi Niklas-san,
> From: Niklas Soderlund, Sent: Thursday, February 13, 2020 7:48 AM
>
> When devm_add_action() was turned into devm_add_action_or_reset() the
> curly brackets for the error case where kept but are not needed, remove
> them to match the style of the driver.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: rcar_gen3_thermal: Remove unneeded curly brackets
2020-02-12 22:47 [PATCH] thermal: rcar_gen3_thermal: Remove unneeded curly brackets Niklas Söderlund
2020-02-13 8:01 ` Yoshihiro Shimoda
@ 2020-02-13 8:17 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-02-13 8:17 UTC (permalink / raw)
To: Niklas Söderlund; +Cc: Linux PM list, Linux-Renesas
On Wed, Feb 12, 2020 at 11:48 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> When devm_add_action() was turned into devm_add_action_or_reset() the
> curly brackets for the error case where kept but are not needed, remove
> them to match the style of the driver.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-13 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 22:47 [PATCH] thermal: rcar_gen3_thermal: Remove unneeded curly brackets Niklas Söderlund
2020-02-13 8:01 ` Yoshihiro Shimoda
2020-02-13 8:17 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).