From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Adam Ford <aford173@gmail.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Adam Ford-BE <aford@beaconembedded.com>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Luca Ceresoli <luca@lucaceresoli.net>
Subject: Re: [PATCH 01/18] arm64: dts: renesas: beacon kit: Configure programmable clocks
Date: Wed, 16 Dec 2020 15:55:20 +0100 [thread overview]
Message-ID: <CAMuHMdWRieM1H5WLySVDVQds-xKgsqo-OibegJrXgonfqbAL8g@mail.gmail.com> (raw)
In-Reply-To: <20201213183759.223246-2-aford173@gmail.com>
Hi Adam,
On Sun, Dec 13, 2020 at 7:38 PM Adam Ford <aford173@gmail.com> wrote:
> When the board was added, clock drivers were being updated done at
> the same time to allow the versaclock driver to properly configure
> the modes. Unforutnately, the updates were not applied to the board
Unfortunately
> files at the time they should have been, so do it now.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> @@ -5,6 +5,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/clk/versaclock.h>
>
> / {
> backlight_lvds: backlight-lvds {
> @@ -294,12 +295,12 @@ &du_out_rgb {
> &ehci0 {
> dr_mode = "otg";
> status = "okay";
> - clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>;
> + clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>, <&versaclock5 3>;
Why this change? You said before you don't need this
https://lore.kernel.org/linux-renesas-soc/CAHCN7xJWbP16SA-Ok-5syNnqOZAt8OFJo2_rtg5VrNVsN2-eiQ@mail.gmail.com/
BTW, something I missed in the earlier review: is there an override
needed at all?
> };
>
> &ehci1 {
> status = "okay";
> - clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>;
> + clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>, <&versaclock5 3>;
Same here.
BTW, something I missed in the earlier review: why did you override
clocks = <&cpg CPG_MOD 702>;
by
clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>;
?
> };
>
> &hdmi0 {
> @@ -373,12 +374,40 @@ versaclock6_bb: clock-controller@6a {
> #clock-cells = <1>;
> clocks = <&x304_clk>;
> clock-names = "xin";
> - /* CSI0_MCLK, CSI1_MCLK, AUDIO_CLKIN, USB_HUB_MCLK_BB */
> + clock-output-names = "versaclock6_bb.out0_sel_i2cb",
> + "versaclock6_bb.out1",
> + "versaclock6_bb.out2",
> + "versaclock6_bb.out3",
> + "versaclock6_bb.out4";
Why? IIUIC, the driver doesn't parse clock-output-names
(and it shouldn't).
> assigned-clocks = <&versaclock6_bb 1>,
> <&versaclock6_bb 2>,
> <&versaclock6_bb 3>,
> <&versaclock6_bb 4>;
> assigned-clock-rates = <24000000>, <24000000>, <24000000>, <24576000>;
> +
> + OUT1 {
> + idt,mode = <VC5_CMOS>;
> + idt,voltage-microvolts = <1800000>;
Oops. The DT bindings say "idt,voltage-microvolt", the example in the DT
bindings says "idt,voltage-microvolts", and the driver parses
"idt,voltage-microvolts".
According to Documentation/devicetree/bindings/property-units.txt, the
property name should end in "microvolt".
Patch sent.
https://lore.kernel.org/linux-clk/20201216145231.1344317-1-geert+renesas@glider.be/
> + idt,slew-percent = <100>;
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-12-16 14:56 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 18:37 [PATCH 00/18] arm64: dts: renesas: Cleanup Beacon Kit and support more SoC's Adam Ford
2020-12-13 18:37 ` [PATCH 01/18] arm64: dts: renesas: beacon kit: Configure programmable clocks Adam Ford
2020-12-16 14:55 ` Geert Uytterhoeven [this message]
2020-12-16 17:03 ` Adam Ford
2020-12-17 8:16 ` Geert Uytterhoeven
2020-12-17 11:52 ` Adam Ford
2020-12-18 13:16 ` Geert Uytterhoeven
2020-12-22 1:39 ` Adam Ford
2020-12-22 8:03 ` Geert Uytterhoeven
2020-12-24 13:52 ` Adam Ford
2020-12-28 12:33 ` Geert Uytterhoeven
2020-12-28 14:38 ` Adam Ford
2020-12-28 14:52 ` Geert Uytterhoeven
2021-05-05 12:07 ` Adam Ford
2020-12-13 18:37 ` [PATCH 02/18] arm64: dts: renesas: beacon kit: Fix choppy Bluetooth Audio Adam Ford
2020-12-17 10:41 ` Geert Uytterhoeven
2020-12-17 12:16 ` Adam Ford
2020-12-18 13:00 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 03/18] arm64: dts: renesas: beacon kit: Remove unnecessary nodes Adam Ford
2020-12-17 10:43 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 04/18] arm64: dts: renesas: beacon kit: Fix Audio Clock sources Adam Ford
2020-12-17 10:54 ` Geert Uytterhoeven
2020-12-17 12:01 ` Adam Ford
2020-12-18 13:05 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 05/18] arm64: dts: renesas: beacon: Fix audio-1.8V pin enable Adam Ford
2020-12-17 10:57 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 06/18] arm64: dts: renesas: beacon: Configure Audio CODEC clocks Adam Ford
2020-12-17 11:11 ` Geert Uytterhoeven
2020-12-17 13:33 ` Adam Ford
2020-12-17 17:58 ` Adam Ford
2020-12-18 12:57 ` Geert Uytterhoeven
2020-12-18 14:23 ` Adam Ford
2020-12-13 18:37 ` [PATCH 07/18] arm64: dts: renesas: beacon: Fix LVDS PWM Backlight Adam Ford
2020-12-17 11:14 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 08/18] arm64: dts: renesas: beacon: Enable SCIF4 Adam Ford
2020-12-17 11:20 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 09/18] arm64: dts: renesas: beacon: Fix RGB Display PWM Backlight Adam Ford
2020-12-17 11:24 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 10/18] arm64: dts: renesas: Don't make vccq_sdhi0 always on Adam Ford
2020-12-17 11:24 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 11/18] arm64: dts: renesas: beacon: Remove redundant audio code Adam Ford
2020-12-13 18:37 ` [PATCH 12/18] arm64: dts: renesas: beacon: Better describe keys Adam Ford
2020-12-17 11:31 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 13/18] arm64: dts: renesas: beacon: Enable SPI Adam Ford
2020-12-17 11:34 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 14/18] arm64: dts: renesas: beacon: Correct I2C bus speeds Adam Ford
2020-12-17 11:38 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 15/18] arm64: dts: renesas: beacon-rzg2m-kit: Rearange SoC unique functions Adam Ford
2020-12-17 11:41 ` Geert Uytterhoeven
2020-12-17 11:47 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 16/18] dt-bindings: arm: renesas: Add Beacon RZ/G2N and RZ/G2H boards Adam Ford
2020-12-15 17:03 ` Rob Herring
2020-12-17 11:42 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 17/18] arm64: dts: renesas: Introduce r8a774b1-beacon-rzg2n-kit Adam Ford
2020-12-17 11:49 ` Geert Uytterhoeven
2020-12-22 13:58 ` Adam Ford
2020-12-22 14:26 ` Biju Das
2020-12-13 18:37 ` [PATCH 18/18] arm64: dts: renesas: Introduce r8a774e1-beacon-rzg2h-kit Adam Ford
2020-12-17 11:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWRieM1H5WLySVDVQds-xKgsqo-OibegJrXgonfqbAL8g@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).