Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Prabhakar <prabhakar.csengg@gmail.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 15/17] ARM: dts: r8a7742: Add APMU nodes
Date: Mon, 18 May 2020 13:41:35 +0200
Message-ID: <CAMuHMdWdc5P3UyDZs1BPzAXZzkhvmZM8gVSDUnJBf=-dsH=izg@mail.gmail.com> (raw)
In-Reply-To: <1589555337-5498-16-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi Prabhakar,

reduced CC list
added CPUidle people

On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Add DT nodes for the Advanced Power Management Units (APMU), and use the
> enable-method to point out that the APMU should be used for SMP support.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm/boot/dts/r8a7742.dtsi
> +++ b/arch/arm/boot/dts/r8a7742.dtsi
> @@ -18,6 +18,7 @@
>         cpus {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> +               enable-method = "renesas,apmu";

According to Documentation/devicetree/bindings/arm/cpus.yaml,
"enable-method" should be a property of the individual CPU nodes,
and not of the parent "cpus" container node.

However, so far we always put it in the parents "cpus" node, which works from
secondary CPU bringup, but may cause issues with CPUidle?

See also "[PATCH/RFC v2] ARM: dts: r8a7791: Move enable-method to CPU nodes"
https://lore.kernel.org/linux-arm-kernel/20190514085837.18325-1-geert+renesas@glider.be/
which so far has received no feedback from the DT or CPUidle people.

Thanks!

>                 cpu0: cpu@0 {
>                         device_type = "cpu";
> @@ -305,6 +306,18 @@
>                         #reset-cells = <1>;
>                 };
>
> +               apmu@e6151000 {
> +                       compatible = "renesas,r8a7742-apmu", "renesas,apmu";
> +                       reg = <0 0xe6151000 0 0x188>;
> +                       cpus = <&cpu4 &cpu5 &cpu6 &cpu7>;
> +               };
> +
> +               apmu@e6152000 {
> +                       compatible = "renesas,r8a7742-apmu", "renesas,apmu";
> +                       reg = <0 0xe6152000 0 0x188>;
> +                       cpus = <&cpu0 &cpu1 &cpu2 &cpu3>;
> +               };
> +
>                 rst: reset-controller@e6160000 {
>                         compatible = "renesas,r8a7742-rst";
>                         reg = <0 0xe6160000 0 0x0100>;

Regardless:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
and I'll see what I will queue in renesas-devel for v5.9 ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply index

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 15:08 [PATCH 00/17] RZ/G1H describe I2C, IIC, MMC0, SATA, AVB, RWDT and " Lad Prabhakar
2020-05-15 15:08 ` [PATCH 01/17] dt-bindings: i2c: renesas,i2c: Document r8a7742 support Lad Prabhakar
2020-05-15 17:12   ` Wolfram Sang
2020-05-18  9:56   ` Geert Uytterhoeven
2020-05-28 20:03   ` Rob Herring
2020-05-15 15:08 ` [PATCH 02/17] dt-bindings: i2c: renesas,iic: " Lad Prabhakar
2020-05-15 17:14   ` Wolfram Sang
2020-05-18  9:59   ` Geert Uytterhoeven
2020-05-28 20:03   ` Rob Herring
2020-05-15 15:08 ` [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support Lad Prabhakar
2020-05-15 17:10   ` Wolfram Sang
2020-05-18  8:58     ` Lad, Prabhakar
2020-05-18  9:26       ` Wolfram Sang
2020-05-18  9:43         ` Lad, Prabhakar
2020-05-18  9:53           ` Wolfram Sang
2020-05-18 10:10         ` Geert Uytterhoeven
2020-05-22 19:14           ` Lad, Prabhakar
2020-05-22 20:17             ` Wolfram Sang
2020-05-25  8:23               ` Geert Uytterhoeven
2020-05-15 15:08 ` [PATCH 04/17] dt-bindings: mmc: renesas,sdhi: Document r8a7742 support Lad Prabhakar
2020-05-15 17:17   ` Wolfram Sang
2020-05-18 11:10   ` Geert Uytterhoeven
2020-05-19 15:29   ` Ulf Hansson
2020-05-15 15:08 ` [PATCH 05/17] mmc: renesas_sdhi_sys_dmac: Add support for r8a7742 SoC Lad Prabhakar
2020-05-15 17:17   ` Wolfram Sang
2020-05-18 11:24     ` Geert Uytterhoeven
2020-05-15 15:08 ` [PATCH 06/17] ARM: dts: r8a7742: Add SDHI nodes Lad Prabhakar
2020-05-17 20:53   ` Wolfram Sang
2020-05-18 11:51   ` Geert Uytterhoeven
2020-05-15 15:08 ` [PATCH 07/17] ARM: dts: r8a7742: Add MMC0 node Lad Prabhakar
2020-05-17 20:54   ` Wolfram Sang
2020-05-18 11:52   ` Geert Uytterhoeven
2020-05-15 15:08 ` [PATCH 08/17] dt-bindings: ata: renesas,rcar-sata: Add r8a7742 support Lad Prabhakar
2020-05-17 20:55   ` Wolfram Sang
2020-05-18 11:13   ` Geert Uytterhoeven
2020-05-28 20:04   ` Rob Herring
2020-05-15 15:08 ` [PATCH 09/17] ARM: dts: r8a7742: Add sata nodes Lad Prabhakar
2020-05-17 20:57   ` Wolfram Sang
2020-05-18 11:52   ` Geert Uytterhoeven
2020-05-15 15:08 ` [PATCH 10/17] dt-bindings: net: renesas,ravb: Add support for r8a7742 SoC Lad Prabhakar
2020-05-17 20:58   ` Wolfram Sang
2020-05-18 11:14   ` Geert Uytterhoeven
2020-05-28 20:04   ` Rob Herring
2020-05-15 15:08 ` [PATCH 11/17] dt-bindings: net: renesas,ether: Document R8A7742 SoC Lad Prabhakar
2020-05-17 20:59   ` Wolfram Sang
2020-05-18 11:15   ` Geert Uytterhoeven
2020-05-28 20:04   ` Rob Herring
2020-05-15 15:08 ` [PATCH 12/17] ARM: dts: r8a7742: Add Ethernet AVB support Lad Prabhakar
2020-05-17 21:00   ` Wolfram Sang
2020-05-18 11:53   ` Geert Uytterhoeven
2020-05-15 15:08 ` [PATCH 13/17] ARM: dts: r8a7742: Add Ether support Lad Prabhakar
2020-05-17 21:01   ` Wolfram Sang
2020-05-18 11:53   ` Geert Uytterhoeven
2020-05-15 15:08 ` [PATCH 14/17] dt-bindings: power: renesas,apmu: Document r8a7742 support Lad Prabhakar
2020-05-17 21:01   ` Wolfram Sang
2020-05-18 11:16   ` Geert Uytterhoeven
2020-05-28 20:05   ` Rob Herring
2020-05-15 15:08 ` [PATCH 15/17] ARM: dts: r8a7742: Add APMU nodes Lad Prabhakar
2020-05-17 21:03   ` Wolfram Sang
2020-05-18 11:41   ` Geert Uytterhoeven [this message]
2020-05-15 15:08 ` [PATCH 16/17] dt-bindings: watchdog: renesas,wdt: Document r8a7742 support Lad Prabhakar
2020-05-17 21:03   ` Wolfram Sang
2020-05-18 11:17   ` Geert Uytterhoeven
2020-05-22 14:47   ` Guenter Roeck
2020-05-27  1:31   ` Rob Herring
2020-05-27 11:22     ` Lad, Prabhakar
2020-05-27 14:38       ` Rob Herring
2020-05-27 16:33         ` Prabhakar Mahadev Lad
2020-05-15 15:08 ` [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node Lad Prabhakar
2020-05-17 21:08   ` Wolfram Sang
2020-05-18  9:16     ` Lad, Prabhakar
2020-05-18  9:28       ` Wolfram Sang
2020-05-18 11:47   ` Geert Uytterhoeven
2020-05-18 12:27     ` Lad, Prabhakar
2020-05-18 13:17       ` Sergei Shtylyov
2020-05-18 13:23         ` Lad, Prabhakar
2020-05-18 15:45           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdWdc5P3UyDZs1BPzAXZzkhvmZM8gVSDUnJBf=-dsH=izg@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git