archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <>
To: Wolfram Sang <>
Cc: Linux MMC List <>,
	Linux-Renesas <>,
	Ulf Hansson <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH 2/3] mmc: sh_mmcif: : use proper DMAENGINE API for termination
Date: Wed, 23 Jun 2021 15:55:40 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Wolfram,

On Wed, Jun 23, 2021 at 11:57 AM Wolfram Sang
<> wrote:
> dmaengine_terminate_all() is deprecated in favor of explicitly saying if
> it should be sync or async. Here, we want dmaengine_terminate_sync()
> because there is no other synchronization code in the driver to handle
> an async case.
> Signed-off-by: Wolfram Sang <>

Looks OK, as this driver uses a threaded irq handler.
Reviewed-by: Geert Uytterhoeven <>

Have you tried triggering DMA termination, with lockdep enabled?



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-06-23 13:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  9:57 [PATCH 0/3] mmc: use proper DMAENGINE API for termination Wolfram Sang
2021-06-23  9:57 ` [PATCH 1/3] mmc: renesas_sdhi_sys_dmac: : " Wolfram Sang
2021-06-23  9:57 ` [PATCH 2/3] mmc: sh_mmcif: " Wolfram Sang
2021-06-23 13:55   ` Geert Uytterhoeven [this message]
2021-06-23  9:57 ` [PATCH 3/3] mmc: usdhi6rol0: " Wolfram Sang
2021-06-23 13:56   ` Geert Uytterhoeven
2021-06-29 15:09 ` [PATCH 0/3] mmc: " Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).