From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Simon Horman <horms@verge.net.au>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH v2] arm64: defconfig: Enable R-Car thermal driver
Date: Fri, 4 Jan 2019 10:01:13 +0100 [thread overview]
Message-ID: <CAMuHMdWf=_-WZT9XUqPCZocNs1As3RJnXMYRYc05Y4td6SciFg@mail.gmail.com> (raw)
In-Reply-To: <20190104085720.36ccxhtcbyyzgfrk@verge.net.au>
Hi Simon,
On Fri, Jan 4, 2019 at 9:57 AM Simon Horman <horms@verge.net.au> wrote:
> On Wed, Jan 02, 2019 at 11:45:37AM +0100, Geert Uytterhoeven wrote:
> > On Wed, Jan 2, 2019 at 10:53 AM Simon Horman <horms+renesas@verge.net.au> wrote:
> > > Enable the R-Car thermal driver as a built-in.
> > >
> > > This driver is used in conjunction with the R-Car V3M (r8a77970),
> > > E3 (r8a77990) and D3 (r8a77995) SoCs.
> >
> > > [v2] Enable as a built-in rather than a module as this seems
> > > safer from the point of view of protecting equipment from
> > > overheating.
> >
> > Shouldn't the above paragraph be moved below the ---?
>
> I have recently come to believe that its a matter of taste. And I think in
> this case it captures important information that is worthy of inclusion in
> the changelog.
The rationale behind doing it this way could still be appended to the first line
of the body of the patch decription.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-01-04 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 9:51 [PATCH v2] arm64: defconfig: Enable R-Car thermal driver Simon Horman
2019-01-02 10:45 ` Geert Uytterhoeven
2019-01-04 8:57 ` Simon Horman
2019-01-04 9:01 ` Geert Uytterhoeven [this message]
2019-01-04 9:12 ` Simon Horman
2019-01-04 9:17 ` Geert Uytterhoeven
2019-01-04 13:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWf=_-WZT9XUqPCZocNs1As3RJnXMYRYc05Y4td6SciFg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).