Linux-Renesas-SoC Archive on lore.kernel.org
 help / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH 2/2] i2c: sh_mobile: use new clock calculation formulas for Gen3
Date: Tue, 5 Feb 2019 14:16:33 +0100
Message-ID: <CAMuHMdWp_cJMXpqtwhbziN-E54vGzfp_M2J2_ZogrE41kkFeOQ@mail.gmail.com> (raw)
In-Reply-To: <20190204220010.5671-3-wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Mon, Feb 4, 2019 at 11:00 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We could finally measure the clock on an Ebisu board. The new formula
> gives way better results, i.e. 100kHz instead of 106kHz and 400kHz
> instead of 387kHz. Switch to these formulas for all Gen3 SoCs.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/drivers/i2c/busses/i2c-sh_mobile.c
> +++ b/drivers/i2c/busses/i2c-sh_mobile.c
> @@ -806,11 +806,11 @@ static const struct of_device_id sh_mobile_i2c_dt_ids[] = {
>         { .compatible = "renesas,iic-r8a7792", .data = &fast_clock_dt_config },
>         { .compatible = "renesas,iic-r8a7793", .data = &fast_clock_dt_config },
>         { .compatible = "renesas,iic-r8a7794", .data = &fast_clock_dt_config },
> -       { .compatible = "renesas,iic-r8a7795", .data = &fast_clock_dt_config },
> -       { .compatible = "renesas,iic-r8a77990", .data = &fast_clock_dt_config },
> +       { .compatible = "renesas,iic-r8a7795", .data = &v2_freq_calc_dt_config },
> +       { .compatible = "renesas,iic-r8a77990", .data = &v2_freq_calc_dt_config },
>         { .compatible = "renesas,iic-sh73a0", .data = &fast_clock_dt_config },
>         { .compatible = "renesas,rcar-gen2-iic", .data = &fast_clock_dt_config },
> -       { .compatible = "renesas,rcar-gen3-iic", .data = &fast_clock_dt_config },
> +       { .compatible = "renesas,rcar-gen3-iic", .data = &v2_freq_calc_dt_config },
>         { .compatible = "renesas,rmobile-iic", .data = &default_dt_config },
>         {},

I guess you want to make a similar change for R-Car Gen2 (both SoC-specific
and family-specific)?
Currently only R-Car H2 uses the new formula, which should apply to all
R-Car Gen2/Gen3 SoCs.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 22:00 [PATCH 0/2] i2c: sh_mobile: updates to compatibles Wolfram Sang
2019-02-04 22:00 ` [PATCH 1/2] i2c: sh_mobile: sort compatible entries Wolfram Sang
2019-02-05 13:14   ` Geert Uytterhoeven
2019-02-05 14:31   ` Simon Horman
2019-02-08 21:29   ` Wolfram Sang
2019-02-04 22:00 ` [PATCH 2/2] i2c: sh_mobile: use new clock calculation formulas for Gen3 Wolfram Sang
2019-02-05 13:16   ` Geert Uytterhoeven [this message]
2019-02-05 16:47     ` Wolfram Sang
2019-02-05 14:33   ` Simon Horman
2019-02-08 21:29   ` Wolfram Sang

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdWp_cJMXpqtwhbziN-E54vGzfp_M2J2_ZogrE41kkFeOQ@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox