Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: dts: r7s72100: Add SPIBSC clocks
@ 2020-02-07 16:27 Chris Brandt
  2020-02-10  8:13 ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Chris Brandt @ 2020-02-07 16:27 UTC (permalink / raw)
  To: Geert Uytterhoeven, Rob Herring, Mark Rutland
  Cc: devicetree, linux-renesas-soc, Chris Brandt

Add clocks for SPIBSC blocks

Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
 arch/arm/boot/dts/r7s72100.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index 75b2796ebfca..0a567d8ebc66 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -467,11 +467,12 @@ mstp9_clks: mstp9_clks@fcfe0438 {
 			#clock-cells = <1>;
 			compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0xfcfe0438 4>;
-			clocks = <&p0_clk>, <&p0_clk>, <&p0_clk>, <&p0_clk>;
+			clocks = <&p0_clk>, <&p0_clk>, <&p0_clk>, <&p0_clk>, <&b_clk>, <&b_clk>;
 			clock-indices = <
 				R7S72100_CLK_I2C0 R7S72100_CLK_I2C1 R7S72100_CLK_I2C2 R7S72100_CLK_I2C3
+				R7S72100_CLK_SPIBSC0 R7S72100_CLK_SPIBSC1
 			>;
-			clock-output-names = "i2c0", "i2c1", "i2c2", "i2c3";
+			clock-output-names = "i2c0", "i2c1", "i2c2", "i2c3", "spibsc0", "spibsc1";
 		};
 
 		mstp10_clks: mstp10_clks@fcfe043c {
-- 
2.24.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: r7s72100: Add SPIBSC clocks
  2020-02-07 16:27 [PATCH] ARM: dts: r7s72100: Add SPIBSC clocks Chris Brandt
@ 2020-02-10  8:13 ` Geert Uytterhoeven
  2020-02-10 11:31   ` Chris Brandt
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-02-10  8:13 UTC (permalink / raw)
  To: Chris Brandt
  Cc: Geert Uytterhoeven, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux-Renesas

Hi Chris,

On Fri, Feb 7, 2020 at 5:27 PM Chris Brandt <chris.brandt@renesas.com> wrote:
> Add clocks for SPIBSC blocks
>
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

However, I believe I cannot queue this in renesas-devel yet, as to avoid
a regression, the flash node in r7s72100-gr-peach.dts should gain
appropriate clock and power-domains properties.
And to avoid bisection issues, that should be combined with this patch,
right?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] ARM: dts: r7s72100: Add SPIBSC clocks
  2020-02-10  8:13 ` Geert Uytterhoeven
@ 2020-02-10 11:31   ` Chris Brandt
  2020-02-10 12:10     ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Chris Brandt @ 2020-02-10 11:31 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Geert Uytterhoeven, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux-Renesas

Hi Geert,

On Mon, Feb 10, 2020, Geert Uytterhoeven wrote:
> However, I believe I cannot queue this in renesas-devel yet, as to avoid
> a regression, the flash node in r7s72100-gr-peach.dts should gain
> appropriate clock and power-domains properties.
> And to avoid bisection issues, that should be combined with this patch,
> right?

Are you saying a patch series? Or 1 patch that edits both files?

Thanks,
Chris


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: r7s72100: Add SPIBSC clocks
  2020-02-10 11:31   ` Chris Brandt
@ 2020-02-10 12:10     ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-02-10 12:10 UTC (permalink / raw)
  To: Chris Brandt
  Cc: Geert Uytterhoeven, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux-Renesas

Hi Chris,

On Mon, Feb 10, 2020 at 12:31 PM Chris Brandt <Chris.Brandt@renesas.com> wrote:
> On Mon, Feb 10, 2020, Geert Uytterhoeven wrote:
> > However, I believe I cannot queue this in renesas-devel yet, as to avoid
> > a regression, the flash node in r7s72100-gr-peach.dts should gain
> > appropriate clock and power-domains properties.
> > And to avoid bisection issues, that should be combined with this patch,
> > right?
>
> Are you saying a patch series? Or 1 patch that edits both files?

I meant a single patch that modifies both files.

If the clocks go in first, the SPIBSC clock will be disabled.
If the FLASH update goes in first, the SPIBSC clock cannot be found.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 16:27 [PATCH] ARM: dts: r7s72100: Add SPIBSC clocks Chris Brandt
2020-02-10  8:13 ` Geert Uytterhoeven
2020-02-10 11:31   ` Chris Brandt
2020-02-10 12:10     ` Geert Uytterhoeven

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git